Make sure that a DropdownButton doesn't crash in 0x0 environment #174880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure DropdownButton doesn't crash when rendered in a zero-sized area. The test correctly sets up the scenario using a SizedBox.shrink(). My review includes a suggestion to make the test more comprehensive by also triggering the dropdown menu to open, which was the source of the original crash. This ensures the fix is fully covered.
dkwingsmt
approved these changes
Sep 3, 2025
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
Checklist:
- The test is in the correct file
- The test name goes “does not crash at zero area”
- The target widget is wrapped by
Center(or is fullscreen) - The target widget is not a overlay
- Expect the target widget has a size of exactly
Size.zero
ahmedsameha1
commented
Sep 5, 2025
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(DropdownButton<String>)), Size.zero); |
Contributor
Author
There was a problem hiding this comment.
It would be convenient to test that the DropdownMenuItem has a zero size, but the test fails with a size of (16.1, 0.0).
Contributor
There was a problem hiding this comment.
It's fine and expected. We've encountered many cases where the children of zero-sized parents have non-zero sizes. We should only test the target widget alone. DropdownMenuItem can have its own test in a similar fashion.
ahmedsameha1
force-pushed
the
handle#6537-DropdownButton
branch
from
2644a07 to
17d90cf
Compare
dkwingsmt
force-pushed
the
handle#6537-DropdownButton
branch
from
dcd769e to
70a5d35
Compare
victorsanni
approved these changes
Oct 9, 2025
dkwingsmt
reviewed
Oct 10, 2025
dkwingsmt
added
the
autosubmit
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
flutter-dashboard
bot
removed
the
autosubmit
ahmedsameha1
force-pushed
the
handle#6537-DropdownButton
branch
from
3155278 to
a135ba2
Compare
Contributor
|
Analyze error: error • The named parameter 'items' is required, but there's no corresponding argument • packages/flutter/test/material/dropdown_test.dart:4707:43 • missing_required_argument
error • The named parameter 'onChanged' is required, but there's no corresponding argument • packages/flutter/test/material/dropdown_test.dart:4707:43 • missing_required_argument |
victorsanni
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 20, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 20, 2025
flutter/flutter@891d7d5...2d34167 2025-10-20 [email protected] Cleanup create_updated_flutter_deps.py a bit (flutter/flutter#177162) 2025-10-20 [email protected] Fixed hot reload/restart crashes after closing browser tab on web-server device (flutter/flutter#177026) 2025-10-20 [email protected] Roll Skia from 0a3ace6fde82 to ed4294faecde (2 revisions) (flutter/flutter#177249) 2025-10-20 [email protected] Add DropdownMenu.decorationBuilder (flutter/flutter#176264) 2025-10-20 [email protected] Roll Skia from 05e2f42f533d to 0a3ace6fde82 (1 revision) (flutter/flutter#177242) 2025-10-20 [email protected] Roll Skia from 89abc5393317 to 05e2f42f533d (1 revision) (flutter/flutter#177238) 2025-10-20 [email protected] [ios][engine] Fix autofill context cleanup and view lifecycle management (flutter/flutter#173598) 2025-10-20 [email protected] Fix Image.network not using cache when headers are specified (flutter/flutter#176831) 2025-10-19 [email protected] Roll Dart SDK from a66f334fee2a to 2cd2106f2cef (4 revisions) (flutter/flutter#177190) 2025-10-19 [email protected] Roll Skia from 2d424175a481 to 89abc5393317 (1 revision) (flutter/flutter#177235) 2025-10-19 [email protected] Make sure that a ListTile doesn't crash in 0x0 environment (flutter/flutter#176176) 2025-10-19 [email protected] Make sure that a DropdownButton doesn't crash in 0x0 environment (flutter/flutter#174880) 2025-10-19 [email protected] Roll Skia from 899155871d29 to 2d424175a481 (1 revision) (flutter/flutter#177229) 2025-10-19 [email protected] Roll Skia from b864c56efb66 to 899155871d29 (1 revision) (flutter/flutter#177227) 2025-10-19 [email protected] Roll Fuchsia Linux SDK from M8WT2GMY46e_0fFho... to tKrvmvTOQITL81oOC... (flutter/flutter#177223) 2025-10-19 [email protected] Roll Skia from 0992b560454f to b864c56efb66 (1 revision) (flutter/flutter#177222) 2025-10-18 [email protected] Fix HEIF decoding (flutter/flutter#176860) 2025-10-18 [email protected] Roll Skia from 74df18176924 to 0992b560454f (1 revision) (flutter/flutter#177217) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…tter#174880) This is my attempt to handle flutter#6537 for the DropdownButton widget. --------- Co-authored-by: Tong Mu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the DropdownButton widget.