Skip to content

Mark Linux web_canvaskit_tests_7_last as bringup #174878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdebbar merged 1 commit into from
Sep 3, 2025
Merged

Mark Linux web_canvaskit_tests_7_last as bringup #174878

mdebbar merged 1 commit into from
Sep 3, 2025

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Sep 3, 2025

Unblocks tree while working on #174877

@mdebbar mdebbar added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Sep 3, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 3, 2025

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .ci.yaml configuration file by setting bringup: true for the Linux web_canvaskit_tests_7_last target. This is a standard procedure to temporarily prevent a failing test from blocking the continuous integration pipeline while a fix is being worked on. The change includes a comment that links to the GitHub issue tracking the necessary resharding work. The change is appropriate and follows documented practices for managing CI tests.

@mdebbar mdebbar enabled auto-merge September 3, 2025 15:40
@mdebbar mdebbar added this pull request to the merge queue Sep 3, 2025
Merged via the queue into master with commit 3c84799 Sep 3, 2025
156 of 157 checks passed
@mdebbar mdebbar deleted the mdebbar-patch-4 branch September 3, 2025 17:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2025
@engine-flutter-autoroll
3c8479987 Mark Linux web_canvaskit_tests_7_last as bringup (flutter/f…
5d9902e 
…lutter#174878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2025
@engine-flutter-autoroll
3c8479987 Mark Linux web_canvaskit_tests_7_last as bringup (flutter/f…
8da75c3 
…lutter#174878)
@mdebbar
Copy link
Contributor Author

mdebbar commented Sep 3, 2025

reason for revert: the issue was fixed by #174881

@mdebbar mdebbar added the revert Autorevert PR (with "Reason for revert:" comment) label Sep 3, 2025
auto-submit bot pushed a commit that referenced this pull request Sep 3, 2025
Revert "Mark Linux web_canvaskit_tests_7_last as bringup (#174878)"
5909203 
This reverts commit 3c84799.
@auto-submit auto-submit bot mentioned this pull request Sep 3, 2025
Merged
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Sep 3, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 3, 2025
@auto-submit
Reverts "Mark Linux web_canvaskit_tests_7_last as bringup (#174878)" (#…
d438f2e 
…174897)

<!-- start_original_pr_link -->
Reverts: #174878
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: mdebbar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: the issue was fixed by
#174881
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: mdebbar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Unblocks tree while working on
#174877
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2025
@engine-flutter-autoroll
3c8479987 Mark Linux web_canvaskit_tests_7_last as bringup (flutter/f…
dfef5cf 
…lutter#174878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2025
@engine-flutter-autoroll
3c8479987 Mark Linux web_canvaskit_tests_7_last as bringup (flutter/f…
7a035b6 
…lutter#174878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2025
@engine-flutter-autoroll
3c8479987 Mark Linux web_canvaskit_tests_7_last as bringup (flutter/f…
321171c 
…lutter#174878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2025
@engine-flutter-autoroll
3c8479987 Mark Linux web_canvaskit_tests_7_last as bringup (flutter/f…
bcd5b3c 
…lutter#174878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2025
@engine-flutter-autoroll
3c8479987 Mark Linux web_canvaskit_tests_7_last as bringup (flutter/f…
0e30ad9 
…lutter#174878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2025
@engine-flutter-autoroll
3c8479987 Mark Linux web_canvaskit_tests_7_last as bringup (flutter/f…
bc7f1de 
…lutter#174878)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 5, 2025
@engine-flutter-autoroll
Roll Flutter from 6b18740d5a23 to 87d5b753196c (88 revisions) (#9962)
cab2ac2 
Roll Flutter from 6b18740d5a23 to 87d5b753196c (88 revisions)

flutter/flutter@6b18740...87d5b75

2025-09-05 [email protected] [ Device Lab ] Add regression testing for flutter/flutter#174952 (flutter/flutter#174956)
2025-09-05 [email protected] Roll Skia from 0ca53adfc6cc to 845ec125e94c (2 revisions) (flutter/flutter#174978)
2025-09-05 [email protected] [a11y-app] Fix NavigationRail leading and trailing labels (flutter/flutter#174861)
2025-09-05 [email protected] Roll Skia from d7e99be07d5d to 0ca53adfc6cc (5 revisions) (flutter/flutter#174972)
2025-09-05 [email protected] Roll Fuchsia Linux SDK from izfNA3o_2zL4Cjqmy... to xG_uERsxHvUwFHpF2... (flutter/flutter#174970)
2025-09-04 [email protected] Fix IconButton.color overrided by IconButtomTheme (flutter/flutter#174515)
2025-09-04 [email protected] [web] Reuse chrome instance to run all flutter tests (flutter/flutter#174957)
2025-09-04 [email protected] fix(Semantics): Ensure semantics properties take priority over button's (flutter/flutter#174473)
2025-09-04 [email protected] Make every LLDB Init error message actionable (flutter/flutter#174726)
2025-09-04 [email protected] Fix table cell semantics rect alignment issues.  (flutter/flutter#174914)
2025-09-04 [email protected] Fix: Use route navigator for CupertinoSheetRoute pop (flutter/flutter#173103)
2025-09-04 [email protected] [ Widget Preview] Add `group` property to `Preview` (flutter/flutter#174849)
2025-09-04 [email protected] Allow OverlayPortal.overlayChildLayoutBuilder to choose root Overlay (flutter/flutter#174239)
2025-09-04 [email protected] Roll Skia from 7c2f502e3304 to d7e99be07d5d (18 revisions) (flutter/flutter#174936)
2025-09-04 [email protected] Remove 'terms of use' wording from web_unicode (flutter/flutter#174939)
2025-09-04 [email protected] [ Tool ] Remove leftover Android x86 deprecation warning constant (flutter/flutter#174941)
2025-09-04 [email protected] Prevent potential crash when accessing window in FlutterSceneDelegate (flutter/flutter#174873)
2025-09-04 [email protected] Roll Packages from 42bb347 to 98580c6 (5 revisions) (flutter/flutter#174943)
2025-09-04 [email protected] [ Device Lab ] Fix wakefulness check to only match log entries with string values (flutter/flutter#174953)
2025-09-04 [email protected] Fix expanded DropdownMenu panel is shorter than text field (flutter/flutter#174443)
2025-09-04 [email protected] Add a `viewController` property to the ios/macOS `FlutterPluginRegistrar` protocol  (flutter/flutter#174168)
2025-09-03 [email protected] Roll Fuchsia Linux SDK from J3T_wZqL_57mRfWky... to izfNA3o_2zL4Cjqmy... (flutter/flutter#174908)
2025-09-03 [email protected] Wires up Android API to set section locale (flutter/flutter#173364)
2025-09-03 [email protected] Delete impeller::SPrintF. (flutter/flutter#174900)
2025-09-03 [email protected] Make sure that a DropdownMenuFormField doesn't crash in 0x0 environment (flutter/flutter#174777)
2025-09-03 [email protected] Remove unnecessary `presubmit_max_attempts` from .ci.yaml (flutter/flutter#174885)
2025-09-03 [email protected] Use local canvaskit in `dart_data_asset_test.dart` (flutter/flutter#174891)
2025-09-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark Linux web_canvaskit_tests_7_last as bringup (#174878)" (flutter/flutter#174897)
2025-09-03 [email protected] Correct intrinsics calculation for CupertinoTextField with placeholder (flutter/flutter#174889)
2025-09-03 [email protected] Considers large title height in CupertinoNavigationBar's preferred size (flutter/flutter#173722)
2025-09-03 [email protected] [A11y] Add semantics for CupertinoExpansionTile (flutter/flutter#174480)
2025-09-03 [email protected] Fix LinearProgressIndicator track painting. (flutter/flutter#173108)
2025-09-03 [email protected] update triage documentation to include team-android (flutter/flutter#174850)
2025-09-03 [email protected] Update `test_timeout_secs` to match `timeout` for `Linux web_skwasm_tests_*` and `Linux web_canvaskit_tests_*` (flutter/flutter#174881)
2025-09-03 [email protected] Roll Packages from 5d785a0 to 42bb347 (10 revisions) (flutter/flutter#174876)
2025-09-03 [email protected] Fixup formatting of gn files in the old buildroot. (flutter/flutter#174852)
2025-09-03 [email protected] Roll Dart SDK to 3.10.0-162.1.beta (flutter/flutter#174834)
2025-09-03 [email protected] Mark Linux web_canvaskit_tests_7_last as bringup (flutter/flutter#174878)
2025-09-02 [email protected] [Impeller] Fix overdraw in DrawRect geometry (flutter/flutter#174735)
2025-09-02 [email protected] Patch .clang-format files to specify C++20. (flutter/flutter#174848)
2025-09-02 [email protected] Add data assets (flutter/flutter#174685)
2025-09-02 [email protected] refactors `FlutterPlugin.kt` to use one line statement in the `into` bloc (flutter/flutter#174759)
2025-09-02 [email protected] Ensures initial semantics state is sent to engine (flutter/flutter#174845)
2025-09-02 [email protected] [Android] Break up plugin_test integration tests (flutter/flutter#174728)
2025-09-02 [email protected] Fix: Assertion failure in RawScrollbarState with dynamic controller assignment (flutter/flutter#173156)
2025-09-02 [email protected] Roll Skia from 359f3d7cc7ed to 7c2f502e3304 (1 revision) (flutter/flutter#174844)
...
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@mdebbar @mboetger
Mark Linux web_canvaskit_tests_7_last as bringup (flutter#174878)
0c50162 
Unblocks tree while working on
flutter#174877
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@auto-submit @mboetger
Reverts "Mark Linux web_canvaskit_tests_7_last as bringup (flutter#17…
64cfefe 
…4878)" (flutter#174897)

<!-- start_original_pr_link -->
Reverts: flutter#174878
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: mdebbar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: the issue was fixed by
flutter#174881
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: mdebbar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Unblocks tree while working on
flutter#174877
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
@mdebbar @Jaineel-Mamtora
Mark Linux web_canvaskit_tests_7_last as bringup (flutter#174878)
34ab9ee 
Unblocks tree while working on
flutter#174877
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
@auto-submit @Jaineel-Mamtora
Reverts "Mark Linux web_canvaskit_tests_7_last as bringup (flutter#17…
44c86e1 
…4878)" (flutter#174897)

<!-- start_original_pr_link -->
Reverts: flutter#174878
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: mdebbar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: the issue was fixed by
flutter#174881
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: mdebbar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Unblocks tree while working on
flutter#174877
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
danferreira pushed a commit to danferreira/packages that referenced this pull request Oct 22, 2025
@engine-flutter-autoroll @danferreira
Roll Flutter from 6b18740d5a23 to 87d5b753196c (88 revisions) (flutte…
7646de2 
…r#9962)

Roll Flutter from 6b18740d5a23 to 87d5b753196c (88 revisions)

flutter/flutter@6b18740...87d5b75

2025-09-05 [email protected] [ Device Lab ] Add regression testing for flutter/flutter#174952 (flutter/flutter#174956)
2025-09-05 [email protected] Roll Skia from 0ca53adfc6cc to 845ec125e94c (2 revisions) (flutter/flutter#174978)
2025-09-05 [email protected] [a11y-app] Fix NavigationRail leading and trailing labels (flutter/flutter#174861)
2025-09-05 [email protected] Roll Skia from d7e99be07d5d to 0ca53adfc6cc (5 revisions) (flutter/flutter#174972)
2025-09-05 [email protected] Roll Fuchsia Linux SDK from izfNA3o_2zL4Cjqmy... to xG_uERsxHvUwFHpF2... (flutter/flutter#174970)
2025-09-04 [email protected] Fix IconButton.color overrided by IconButtomTheme (flutter/flutter#174515)
2025-09-04 [email protected] [web] Reuse chrome instance to run all flutter tests (flutter/flutter#174957)
2025-09-04 [email protected] fix(Semantics): Ensure semantics properties take priority over button's (flutter/flutter#174473)
2025-09-04 [email protected] Make every LLDB Init error message actionable (flutter/flutter#174726)
2025-09-04 [email protected] Fix table cell semantics rect alignment issues.  (flutter/flutter#174914)
2025-09-04 [email protected] Fix: Use route navigator for CupertinoSheetRoute pop (flutter/flutter#173103)
2025-09-04 [email protected] [ Widget Preview] Add `group` property to `Preview` (flutter/flutter#174849)
2025-09-04 [email protected] Allow OverlayPortal.overlayChildLayoutBuilder to choose root Overlay (flutter/flutter#174239)
2025-09-04 [email protected] Roll Skia from 7c2f502e3304 to d7e99be07d5d (18 revisions) (flutter/flutter#174936)
2025-09-04 [email protected] Remove 'terms of use' wording from web_unicode (flutter/flutter#174939)
2025-09-04 [email protected] [ Tool ] Remove leftover Android x86 deprecation warning constant (flutter/flutter#174941)
2025-09-04 [email protected] Prevent potential crash when accessing window in FlutterSceneDelegate (flutter/flutter#174873)
2025-09-04 [email protected] Roll Packages from 42bb347 to 98580c6 (5 revisions) (flutter/flutter#174943)
2025-09-04 [email protected] [ Device Lab ] Fix wakefulness check to only match log entries with string values (flutter/flutter#174953)
2025-09-04 [email protected] Fix expanded DropdownMenu panel is shorter than text field (flutter/flutter#174443)
2025-09-04 [email protected] Add a `viewController` property to the ios/macOS `FlutterPluginRegistrar` protocol  (flutter/flutter#174168)
2025-09-03 [email protected] Roll Fuchsia Linux SDK from J3T_wZqL_57mRfWky... to izfNA3o_2zL4Cjqmy... (flutter/flutter#174908)
2025-09-03 [email protected] Wires up Android API to set section locale (flutter/flutter#173364)
2025-09-03 [email protected] Delete impeller::SPrintF. (flutter/flutter#174900)
2025-09-03 [email protected] Make sure that a DropdownMenuFormField doesn't crash in 0x0 environment (flutter/flutter#174777)
2025-09-03 [email protected] Remove unnecessary `presubmit_max_attempts` from .ci.yaml (flutter/flutter#174885)
2025-09-03 [email protected] Use local canvaskit in `dart_data_asset_test.dart` (flutter/flutter#174891)
2025-09-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark Linux web_canvaskit_tests_7_last as bringup (#174878)" (flutter/flutter#174897)
2025-09-03 [email protected] Correct intrinsics calculation for CupertinoTextField with placeholder (flutter/flutter#174889)
2025-09-03 [email protected] Considers large title height in CupertinoNavigationBar's preferred size (flutter/flutter#173722)
2025-09-03 [email protected] [A11y] Add semantics for CupertinoExpansionTile (flutter/flutter#174480)
2025-09-03 [email protected] Fix LinearProgressIndicator track painting. (flutter/flutter#173108)
2025-09-03 [email protected] update triage documentation to include team-android (flutter/flutter#174850)
2025-09-03 [email protected] Update `test_timeout_secs` to match `timeout` for `Linux web_skwasm_tests_*` and `Linux web_canvaskit_tests_*` (flutter/flutter#174881)
2025-09-03 [email protected] Roll Packages from 5d785a0 to 42bb347 (10 revisions) (flutter/flutter#174876)
2025-09-03 [email protected] Fixup formatting of gn files in the old buildroot. (flutter/flutter#174852)
2025-09-03 [email protected] Roll Dart SDK to 3.10.0-162.1.beta (flutter/flutter#174834)
2025-09-03 [email protected] Mark Linux web_canvaskit_tests_7_last as bringup (flutter/flutter#174878)
2025-09-02 [email protected] [Impeller] Fix overdraw in DrawRect geometry (flutter/flutter#174735)
2025-09-02 [email protected] Patch .clang-format files to specify C++20. (flutter/flutter#174848)
2025-09-02 [email protected] Add data assets (flutter/flutter#174685)
2025-09-02 [email protected] refactors `FlutterPlugin.kt` to use one line statement in the `into` bloc (flutter/flutter#174759)
2025-09-02 [email protected] Ensures initial semantics state is sent to engine (flutter/flutter#174845)
2025-09-02 [email protected] [Android] Break up plugin_test integration tests (flutter/flutter#174728)
2025-09-02 [email protected] Fix: Assertion failure in RawScrollbarState with dynamic controller assignment (flutter/flutter#173156)
2025-09-02 [email protected] Roll Skia from 359f3d7cc7ed to 7c2f502e3304 (1 revision) (flutter/flutter#174844)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
@engine-flutter-autoroll
3c8479987 Mark Linux web_canvaskit_tests_7_last as bringup (flutter/f…
3413658 
…lutter#174878)
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@mdebbar @lucaantonelli
Mark Linux web_canvaskit_tests_7_last as bringup (flutter#174878)
1b2035b 
Unblocks tree while working on
flutter#174877
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@auto-submit @lucaantonelli
Reverts "Mark Linux web_canvaskit_tests_7_last as bringup (flutter#17…
746993f 
…4878)" (flutter#174897)

<!-- start_original_pr_link -->
Reverts: flutter#174878
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: mdebbar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: the issue was fixed by
flutter#174881
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: mdebbar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Unblocks tree while working on
flutter#174877
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdebbar @jtmcdole