Add semanticIndexOffset argument to SliverList.builder, SliverGrid.builder, and SliverFixedExtentList.builder #174856

rodrigogmdias · 2025-09-02T23:58:15Z

This pull request adds support for the semanticIndexOffset parameter to the SliverList.builder, SliverFixedExtentList.builder, and SliverGrid.builder constructors in Flutter. This allows developers to offset the starting semantic index for items in these slivers, which is important for accessibility scenarios (such as when combining multiple slivers). The changes are thoroughly tested with new widget tests to ensure correct behavior.

Accessibility improvements:

Added semanticIndexOffset parameter to the constructors of SliverList.builder, SliverFixedExtentList.builder, and SliverGrid.builder, and ensured it is passed to the underlying SliverChildBuilderDelegate. This allows customization of the starting semantic index for sliver children. [1] [2] [3] [4] [5] [6]

Testing:

Added a new test for SliverList.builder to verify that the semanticIndexOffset is respected in the generated semantics tree. [1] [2]
Added a new test for SliverFixedExtentList.builder to verify correct semantics index offsetting.
Added a new test for SliverGrid.builder to ensure it respects the semanticIndexOffset parameter.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

…ilder, and SliverFixedExtentList.builder

google-cla · 2025-09-02T23:58:19Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist

Code Review

This pull request correctly adds the semanticIndexOffset parameter to SliverList.builder, SliverFixedExtentList.builder, and SliverGrid.builder, enhancing accessibility features. The changes are well-tested. My feedback focuses on improving test code quality by reducing duplication and ensuring consistency in test naming.

packages/flutter/test/widgets/slivers_test.dart

Renzo-Olivares

LGTM, thank you for the contribution!

rodrigogmdias · 2025-09-10T14:46:58Z

LGTM, thank you for the contribution!

Hi, @Renzo-Olivares, should I do anything else or just wait?

Renzo-Olivares · 2025-09-12T20:35:38Z

@rodrigogmdias This PR needs a secondary review/approval, i'll try to find one and then we can land this. Thank you for your patience!

packages/flutter/test/widgets/slivers_test.dart

packages/flutter/test/widgets/sliver_list_test.dart

loic-sharma

Thanks for the wonderful contribution!

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

flutter/flutter@f331a55...29a238d 2025-09-15 [email protected] Roll Skia from d84a369255c4 to f950263bb3d4 (1 revision) (flutter/flutter#175354) 2025-09-15 [email protected] Roll Fuchsia Linux SDK from 4ZIBcdI2x_y8trVYz... to wzk_HjPLGu-mlg5hC... (flutter/flutter#175349) 2025-09-15 [email protected] Roll Dart SDK from 24179911b2fe to 50e61e5bff51 (2 revisions) (flutter/flutter#175346) 2025-09-15 [email protected] Roll Skia from 785f8859c7b9 to d84a369255c4 (5 revisions) (flutter/flutter#175342) 2025-09-15 [email protected] Roll Dart SDK from 628b3f869d9b to 24179911b2fe (1 revision) (flutter/flutter#175331) 2025-09-15 [email protected] Roll Skia from 4fb7e988c981 to 785f8859c7b9 (1 revision) (flutter/flutter#175330) 2025-09-14 [email protected] Roll Skia from 64c5ab69997f to 4fb7e988c981 (1 revision) (flutter/flutter#175322) 2025-09-14 [email protected] Roll Fuchsia Linux SDK from TrB_3av7CK7a5Wb0h... to 4ZIBcdI2x_y8trVYz... (flutter/flutter#175319) 2025-09-14 [email protected] Roll Skia from 7b489cee9eca to 64c5ab69997f (1 revision) (flutter/flutter#175316) 2025-09-13 [email protected] Roll Dart SDK from 5deba9e4e108 to 628b3f869d9b (1 revision) (flutter/flutter#175314) 2025-09-13 [email protected] Roll Fuchsia Linux SDK from b1AYfAFOnvBMHSsYL... to TrB_3av7CK7a5Wb0h... (flutter/flutter#175306) 2025-09-13 [email protected] Roll Dart SDK from e82f3fc8b2d5 to 5deba9e4e108 (1 revision) (flutter/flutter#175302) 2025-09-13 [email protected] Roll Skia from 3321829b90dd to 7b489cee9eca (1 revision) (flutter/flutter#175298) 2025-09-13 [email protected] [ios]Do not re-adds delaying recognizer on iOS 26 (flutter/flutter#175097) 2025-09-13 [email protected] Roll Skia from b2cdcf07b2b5 to 3321829b90dd (22 revisions) (flutter/flutter#175295) 2025-09-13 [email protected] Roll Dart SDK from 11dedad2d062 to e82f3fc8b2d5 (3 revisions) (flutter/flutter#175294) 2025-09-12 [email protected] Add semanticIndexOffset argument to SliverList.builder, SliverGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856) 2025-09-12 [email protected] Fix crash when attaching to a device with multiple active flutter apps (flutter/flutter#175147) 2025-09-12 [email protected] Update transformHitTests documentation for clarity (flutter/flutter#174286) 2025-09-12 [email protected] Roll Skia from ead9277819fc to b2cdcf07b2b5 (1 revision) (flutter/flutter#175226) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ilder, and SliverFixedExtentList.builder (flutter#174856) Issue: flutter#173019 This pull request adds support for the `semanticIndexOffset` parameter to the `SliverList.builder`, `SliverFixedExtentList.builder`, and `SliverGrid.builder` constructors in Flutter. This allows developers to offset the starting semantic index for items in these slivers, which is important for accessibility scenarios (such as when combining multiple slivers). The changes are thoroughly tested with new widget tests to ensure correct behavior. **Accessibility improvements:** * Added `semanticIndexOffset` parameter to the constructors of `SliverList.builder`, `SliverFixedExtentList.builder`, and `SliverGrid.builder`, and ensured it is passed to the underlying `SliverChildBuilderDelegate`. This allows customization of the starting semantic index for sliver children. [[1]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR219) [[2]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR228) [[3]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR476) [[4]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR485) [[5]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR751) [[6]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR760) **Testing:** * Added a new test for `SliverList.builder` to verify that the `semanticIndexOffset` is respected in the generated semantics tree. [[1]](diffhunk://#diff-9aec0ee8c35ea1c71be420610fe37f772e45b5c1f715285fe76ac5ba328ea76dR366-R382) [[2]](diffhunk://#diff-9aec0ee8c35ea1c71be420610fe37f772e45b5c1f715285fe76ac5ba328ea76dR446-R474) * Added a new test for `SliverFixedExtentList.builder` to verify correct semantics index offsetting. * Added a new test for `SliverGrid.builder` to ensure it respects the `semanticIndexOffset` parameter. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <[email protected]>

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

…ilder, and SliverFixedExtentList.builder (flutter#174856) Issue: flutter#173019 This pull request adds support for the `semanticIndexOffset` parameter to the `SliverList.builder`, `SliverFixedExtentList.builder`, and `SliverGrid.builder` constructors in Flutter. This allows developers to offset the starting semantic index for items in these slivers, which is important for accessibility scenarios (such as when combining multiple slivers). The changes are thoroughly tested with new widget tests to ensure correct behavior. **Accessibility improvements:** * Added `semanticIndexOffset` parameter to the constructors of `SliverList.builder`, `SliverFixedExtentList.builder`, and `SliverGrid.builder`, and ensured it is passed to the underlying `SliverChildBuilderDelegate`. This allows customization of the starting semantic index for sliver children. [[1]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR219) [[2]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR228) [[3]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR476) [[4]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR485) [[5]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR751) [[6]](diffhunk://#diff-a7ccc8e04affff00abaa0800e680e94c325930dac396f134a70ce5c5c17f8c4dR760) **Testing:** * Added a new test for `SliverList.builder` to verify that the `semanticIndexOffset` is respected in the generated semantics tree. [[1]](diffhunk://#diff-9aec0ee8c35ea1c71be420610fe37f772e45b5c1f715285fe76ac5ba328ea76dR366-R382) [[2]](diffhunk://#diff-9aec0ee8c35ea1c71be420610fe37f772e45b5c1f715285fe76ac5ba328ea76dR446-R474) * Added a new test for `SliverFixedExtentList.builder` to verify correct semantics index offsetting. * Added a new test for `SliverGrid.builder` to ensure it respects the `semanticIndexOffset` parameter. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <[email protected]>

rodrigogmdias added 2 commits September 2, 2025 19:57

Add semanticIndexOffset argument to SliverList.builder, SliverGrid.bu…

b44890d

…ilder, and SliverFixedExtentList.builder

Add tests for semanticIndexOffset in Sliver widgets

9433e9b

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Sep 2, 2025

gemini-code-assist bot reviewed Sep 3, 2025

View reviewed changes

packages/flutter/test/widgets/slivers_test.dart Outdated Show resolved Hide resolved

rodrigogmdias added 3 commits September 2, 2025 21:26

Refactor semantics retrieval in slivers tests

28f11cf

Refactor semantic index retrieval in SliverList test

ce1f981

Merge remote-tracking branch 'upstream/master' into fix173019

a507e94

rodrigogmdias mentioned this pull request Sep 3, 2025

Add semanticIndexOffset argument to SliverList.builder, SliverGrid.builder, and SliverFixedExtentList.builder #173019

Closed

3 tasks

Renzo-Olivares self-requested a review September 3, 2025 19:07

Merge branch 'master' into fix173019

49a34a5

Renzo-Olivares approved these changes Sep 8, 2025

View reviewed changes

Merge branch 'master' into fix173019

18fd2e3

loic-sharma reviewed Sep 12, 2025

View reviewed changes

packages/flutter/test/widgets/slivers_test.dart Outdated Show resolved Hide resolved

Update packages/flutter/test/widgets/slivers_test.dart

bb36dec

loic-sharma reviewed Sep 12, 2025

View reviewed changes

packages/flutter/test/widgets/sliver_list_test.dart Outdated Show resolved Hide resolved

Update packages/flutter/test/widgets/sliver_list_test.dart

f680a51

loic-sharma approved these changes Sep 12, 2025

View reviewed changes

loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2025

auto-submit bot added this pull request to the merge queue Sep 12, 2025

Merged via the queue into flutter:master with commit adca933 Sep 12, 2025
79 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2025

rodrigogmdias deleted the fix173019 branch September 13, 2025 04:03

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

6c331f9

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

engine-flutter-autoroll mentioned this pull request Sep 13, 2025

Roll Flutter from f331a555e20c to 8cbca2381668 (10 revisions) flutter/packages#9999

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

0bdb864

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

engine-flutter-autoroll mentioned this pull request Sep 13, 2025

Roll Flutter from f331a555e20c to 8cbca2381668 (10 revisions) flutter/packages#10000

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

5c89891

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

engine-flutter-autoroll mentioned this pull request Sep 14, 2025

Roll Flutter from f331a555e20c to 59c274a40480 (13 revisions) flutter/packages#10001

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

e6341cf

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

engine-flutter-autoroll mentioned this pull request Sep 14, 2025

Roll Flutter from f331a555e20c to 59c274a40480 (13 revisions) flutter/packages#10002

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

068a0a4

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

engine-flutter-autoroll mentioned this pull request Sep 14, 2025

Roll Flutter from f331a555e20c to 81928eeb91fc (14 revisions) flutter/packages#10003

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

55a3655

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

engine-flutter-autoroll mentioned this pull request Sep 15, 2025

Roll Flutter from f331a555e20c to 0eec486c9507 (17 revisions) flutter/packages#10011

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

7255d4a

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

engine-flutter-autoroll mentioned this pull request Sep 15, 2025

Roll Flutter from f331a555e20c to 5ccb53d1df4b (18 revisions) flutter/packages#10012

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

14db293

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

engine-flutter-autoroll mentioned this pull request Sep 15, 2025

Roll Flutter from f331a555e20c to 2594f40134db (19 revisions) flutter/packages#10013

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

71c4224

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

engine-flutter-autoroll mentioned this pull request Sep 15, 2025

Roll Flutter from f331a555e20c to 29a238d0d506 (20 revisions) flutter/packages#10014

Merged

Piinks mentioned this pull request Sep 19, 2025

Flutter Notable Commits - 2025 #161460

Open

justinmc mentioned this pull request Sep 23, 2025

feat(widgets): add semanticIndexOffset to SliverList/SliverGrid/Fixed/Varied builder constructors + tests #174815

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

adca93396 Add semanticIndexOffset argument to SliverList.builder, Sli…

b38192b

…verGrid.builder, and SliverFixedExtentList.builder (flutter/flutter#174856)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add semanticIndexOffset argument to SliverList.builder, SliverGrid.builder, and SliverFixedExtentList.builder #174856

Add semanticIndexOffset argument to SliverList.builder, SliverGrid.builder, and SliverFixedExtentList.builder #174856

Uh oh!

rodrigogmdias commented Sep 2, 2025 •

edited

Loading

Uh oh!

google-cla bot commented Sep 2, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Uh oh!

rodrigogmdias commented Sep 10, 2025

Uh oh!

Renzo-Olivares commented Sep 12, 2025

Uh oh!

Uh oh!

Uh oh!

loic-sharma left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add semanticIndexOffset argument to SliverList.builder, SliverGrid.builder, and SliverFixedExtentList.builder #174856

Add semanticIndexOffset argument to SliverList.builder, SliverGrid.builder, and SliverFixedExtentList.builder #174856

Uh oh!

Conversation

rodrigogmdias commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

google-cla bot commented Sep 2, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

rodrigogmdias commented Sep 10, 2025

Uh oh!

Renzo-Olivares commented Sep 12, 2025

Uh oh!

Uh oh!

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rodrigogmdias commented Sep 2, 2025 •

edited

Loading