Fix DropdownMenu filtering is broken #174778
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively resolves a filtering issue in the DropdownMenu widget by changing the state management from tracking the selected index to tracking the selected value. This is a robust solution that correctly decouples the selection state from the dynamic list of menu entries, preventing errors when the list is filtered or updated. The implementation is clean, and the addition of a new regression test ensures the fix is well-covered. The changes look good and address the problem described.
9 tasks
bleroux
force-pushed
the
fix_dropdownmenu_filtering_is_broken
branch
from
710727a to
2d21995
Compare
Contributor
Author
|
Closing in favor of #174757. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes DropdownMenu filtering.
The implementation choice is to not rely on storing the selected index and to store the selected value instead.
Related Issue
Fixes DropdownMenu filtering is broken
Tests
Adds 1 test.