Nav bar static components respect ambient MediaQueryData #174673

victorsanni · 2025-08-28T22:49:32Z

Fixes CupertinoSlidingSegmentedControl in CupertinoNavigationBar renders incorrectly in dark brightness (starting 3.35.0)
Fixes [Cupertino] MediaQuery.of(context) returns Size(0,0) inside CupertinoNavigationBar trailing since Flutter 3.35

Bug was introduced in CupertinoSliverNavigationBar respects accessibility text scaling

See #174642 (comment)

gemini-code-assist

Code Review

This pull request correctly addresses an issue where CupertinoNavigationBar components failed to respect ambient MediaQueryData, leading to incorrect rendering in dark mode. The fix, which involves using MediaQuery.of(context).copyWith() instead of creating a new MediaQueryData, is appropriate and well-implemented across all affected components. The new test case effectively validates this change. My review includes a suggestion to improve maintainability by refactoring duplicated code and a high-severity comment to fix a potential bug in the new test to ensure its reliability.

packages/flutter/test/cupertino/nav_bar_test.dart

packages/flutter/lib/src/cupertino/nav_bar.dart

dkwingsmt

LGTM with a minor suggestion

dkwingsmt · 2025-09-04T20:22:43Z

packages/flutter/test/cupertino/nav_bar_test.dart

+            middle: const _ExpectCustomMediaQuery(value: value, index: 0x000100),
+            trailing: CupertinoButton(
+              onPressed: () {},
+              child: const _ExpectCustomMediaQuery(value: value, index: 0x010000),


While the current way is acceptable, I'd prefer if you can explore a better style that writes the expects in the test body instead of in the class, which is hard to find.

Can you make _ExpectCustomMediaQuery accept a void callback instead and define the expects in the callback?

Also probably add a "regression test" comment explaining why these expectations make sense

While the current way is acceptable, I'd prefer if you can explore a better style that writes the expects in the test body instead of in the class, which is hard to find.

Ah. I implemented it that way because it was consistent with the _ExpectStyles class in the same file. But then the _ExpectStyles class is reused across multiple tests. I can explore a solution contained entirely within the test itself.

dkwingsmt · 2025-09-04T21:38:11Z

packages/flutter/test/cupertino/nav_bar_test.dart

+    const double value = 10.0;
+
+    void expectCustomMediaQueryData(BuildContext context) {
+      expect(MediaQuery.platformBrightnessOf(context), Brightness.dark);


This looks great, but is it ok if it doesn't check the value anymore? (Which I'm ok with since the original issue wasn't about custom values)

The problem with that is a future change might copy over only the mediaQueryData brightness leaving the other properties out. And we want to prevent against that regression. But MediaQueryData has many properties, so I'm thinking of testing with a subset of those properties numerous enough to protect against regression.

What do you think is the optimal approach here?

Yeah I think this is sufficient. Just a few is enough to verify our approach here, and thoroughly testing copyWith should be done in MediaQueryData's tests.

MitchellGoodwin

LGTM as well

…lutter/flutter#174673)

flutter/flutter@973320c...a082096 2025-09-09 [email protected] Roll Packages from 24588c6 to 2d651b2 (2 revisions) (flutter/flutter#175130) 2025-09-09 [email protected] Roll Skia from ab13fd19dd32 to 19ba56dde579 (2 revisions) (flutter/flutter#175127) 2025-09-09 [email protected] Roll Skia from 29a015f8712b to ab13fd19dd32 (2 revisions) (flutter/flutter#175108) 2025-09-09 [email protected] Roll Skia from 6a4613b83365 to 29a015f8712b (5 revisions) (flutter/flutter#175106) 2025-09-09 [email protected] Roll Dart SDK from 7b645442db0f to f446144fb7c9 (2 revisions) (flutter/flutter#175104) 2025-09-08 [email protected] Nav bar static components respect ambient MediaQueryData (flutter/flutter#174673) 2025-09-08 [email protected] fix typo in test documentation #2 (flutter/flutter#174707) 2025-09-08 [email protected] Update ImageReaderSurfaceProducer.MAX_IMAGES to include the maximum number of retained dequeued images (flutter/flutter#174971) 2025-09-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 5.0.0 to 6.0.1 in the all-github-actions group (flutter/flutter#175093) 2025-09-08 [email protected] Roll Skia from 25f00cb247f2 to 6a4613b83365 (3 revisions) (flutter/flutter#175087) 2025-09-08 [email protected] Roll Dart SDK from 83c6b6124380 to 7b645442db0f (1 revision) (flutter/flutter#175086) 2025-09-08 [email protected] Impeller: Convert GLProc name field and GLErrorToString to std::string_view (flutter/flutter#173771) 2025-09-08 [email protected] Depend on operator overload synthesis for three-way and equality comparisons. (flutter/flutter#174892) 2025-09-08 [email protected] Define a concept for UniqueObjectTraits. (flutter/flutter#174905) 2025-09-08 [email protected] Roll Skia from 0c2b0a00b7b5 to 25f00cb247f2 (1 revision) (flutter/flutter#175077) 2025-09-08 [email protected] Fix GitHub labeler platform-android typo (flutter/flutter#175076) 2025-09-08 [email protected] [Gradle 9] Removed `minSdkVersion` and only use `minSdk` (flutter/flutter#173892) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Fixes [CupertinoSlidingSegmentedControl in CupertinoNavigationBar renders incorrectly in dark brightness (starting 3.35.0)](flutter#174642) Fixes [[Cupertino] MediaQuery.of(context) returns Size(0,0) inside CupertinoNavigationBar trailing since Flutter 3.35](flutter#174771 (comment)) Bug was introduced in [CupertinoSliverNavigationBar respects accessibility text scaling](flutter#168866) See flutter#174642 (comment)

Fixes menu positioning and animation issues when PullDownButton is used in CupertinoNavigationBar's trailing widget on Flutter 3.35.0+. Root cause: Flutter 3.35.0 introduced a regression where CupertinoNavigationBar wraps children with incomplete MediaQueryData (only textScaler set, causing size to default to Size(0,0)). Solution: Pass overlay context for MediaQuery lookups instead of using the button's context. The overlay always has complete MediaQueryData. Changes: - Add mediaQueryContext parameter to getRect() - Add overlayContext parameter to animationAlignment() - Pass navigator.overlay.context for both MediaQuery lookups This fix is forward-compatible and will continue working when Flutter's fix lands in stable. Related: - flutter/flutter#174771 (MediaQuery returns Size(0,0) in nav bar) - flutter/flutter#174673 (Flutter's fix, not yet in stable) - notDmDrl#74 (Original bug report)

…r#9983) flutter/flutter@973320c...a082096 2025-09-09 [email protected] Roll Packages from 24588c6 to 2d651b2 (2 revisions) (flutter/flutter#175130) 2025-09-09 [email protected] Roll Skia from ab13fd19dd32 to 19ba56dde579 (2 revisions) (flutter/flutter#175127) 2025-09-09 [email protected] Roll Skia from 29a015f8712b to ab13fd19dd32 (2 revisions) (flutter/flutter#175108) 2025-09-09 [email protected] Roll Skia from 6a4613b83365 to 29a015f8712b (5 revisions) (flutter/flutter#175106) 2025-09-09 [email protected] Roll Dart SDK from 7b645442db0f to f446144fb7c9 (2 revisions) (flutter/flutter#175104) 2025-09-08 [email protected] Nav bar static components respect ambient MediaQueryData (flutter/flutter#174673) 2025-09-08 [email protected] fix typo in test documentation flutter#2 (flutter/flutter#174707) 2025-09-08 [email protected] Update ImageReaderSurfaceProducer.MAX_IMAGES to include the maximum number of retained dequeued images (flutter/flutter#174971) 2025-09-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 5.0.0 to 6.0.1 in the all-github-actions group (flutter/flutter#175093) 2025-09-08 [email protected] Roll Skia from 25f00cb247f2 to 6a4613b83365 (3 revisions) (flutter/flutter#175087) 2025-09-08 [email protected] Roll Dart SDK from 83c6b6124380 to 7b645442db0f (1 revision) (flutter/flutter#175086) 2025-09-08 [email protected] Impeller: Convert GLProc name field and GLErrorToString to std::string_view (flutter/flutter#173771) 2025-09-08 [email protected] Depend on operator overload synthesis for three-way and equality comparisons. (flutter/flutter#174892) 2025-09-08 [email protected] Define a concept for UniqueObjectTraits. (flutter/flutter#174905) 2025-09-08 [email protected] Roll Skia from 0c2b0a00b7b5 to 25f00cb247f2 (1 revision) (flutter/flutter#175077) 2025-09-08 [email protected] Fix GitHub labeler platform-android typo (flutter/flutter#175076) 2025-09-08 [email protected] [Gradle 9] Removed `minSdkVersion` and only use `minSdk` (flutter/flutter#173892) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes menu positioning and animation issues when PullDownButton is used in CupertinoNavigationBar's trailing widget on Flutter 3.35.0+. Root cause: Flutter 3.35.0 introduced a regression where CupertinoNavigationBar wraps children with incomplete MediaQueryData (only textScaler set, causing size to default to Size(0,0)). Solution: Pass overlay context for MediaQuery lookups instead of using the button's context. The overlay always has complete MediaQueryData. Changes: - Add mediaQueryContext parameter to getRect() - Add overlayContext parameter to animationAlignment() - Pass navigator.overlay.context for both MediaQuery lookups This fix is forward-compatible and will continue working when Flutter's fix lands in stable. Related: - flutter/flutter#174771 (MediaQuery returns Size(0,0) in nav bar) - flutter/flutter#174673 (Flutter's fix, not yet in stable) - notDmDrl#74 (Original bug report)

…lutter/flutter#174673)

) Fixes [CupertinoSlidingSegmentedControl in CupertinoNavigationBar renders incorrectly in dark brightness (starting 3.35.0)](flutter#174642) Fixes [[Cupertino] MediaQuery.of(context) returns Size(0,0) inside CupertinoNavigationBar trailing since Flutter 3.35](flutter#174771 (comment)) Bug was introduced in [CupertinoSliverNavigationBar respects accessibility text scaling](flutter#168866) See flutter#174642 (comment)

Nav bar static components respect ambient MediaQueryData

e263e68

victorsanni requested review from MitchellGoodwin and dkwingsmt August 28, 2025 22:49

Merge branch 'master' into nav-bar-fix

67893c2

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Aug 28, 2025

gemini-code-assist bot reviewed Aug 28, 2025

View reviewed changes

packages/flutter/test/cupertino/nav_bar_test.dart Show resolved Hide resolved

packages/flutter/lib/src/cupertino/nav_bar.dart Outdated Show resolved Hide resolved

victorsanni added 3 commits August 28, 2025 15:59

Reset count

8635fcd

Apply review suggestions

b8f7ec5

Merge branch 'master' into nav-bar-fix

7a0b971

victorsanni mentioned this pull request Sep 2, 2025

Fix CupertinoNavigationBar MediaQuery regression #174771 #174776

Closed

dkwingsmt approved these changes Sep 4, 2025

View reviewed changes

victorsanni added 3 commits September 4, 2025 14:32

Fix test

9f503f6

Link regression tests

19f7777

Merge branch 'master' into nav-bar-fix

c16ad58

dkwingsmt reviewed Sep 4, 2025

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2025

auto-submit bot added this pull request to the merge queue Sep 8, 2025

victorsanni removed this pull request from the merge queue due to a manual request Sep 8, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2025

MitchellGoodwin approved these changes Sep 8, 2025

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2025

auto-submit bot added this pull request to the merge queue Sep 8, 2025

Merged via the queue into flutter:master with commit d328555 Sep 8, 2025
80 of 81 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2025

engine-flutter-autoroll mentioned this pull request Sep 9, 2025

Roll Flutter from 973320c0270b to 4277a18e139b (15 revisions) flutter/packages#9982

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2025

d32855515 Nav bar static components respect ambient MediaQueryData (f…

c3c4ecb

…lutter/flutter#174673)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2025

d32855515 Nav bar static components respect ambient MediaQueryData (f…

636127d

…lutter/flutter#174673)

engine-flutter-autoroll mentioned this pull request Sep 9, 2025

Roll Flutter from 973320c0270b to a0820964d59c (17 revisions) flutter/packages#9983

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2025

d32855515 Nav bar static components respect ambient MediaQueryData (f…

f61551d

…lutter/flutter#174673)

engine-flutter-autoroll mentioned this pull request Sep 9, 2025

Roll Flutter from 973320c0270b to a0820964d59c (17 revisions) flutter/packages#9984

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2025

d32855515 Nav bar static components respect ambient MediaQueryData (f…

bc29b09

…lutter/flutter#174673)

engine-flutter-autoroll mentioned this pull request Sep 9, 2025

Roll Flutter from 973320c0270b to 53f8432312ed (18 revisions) flutter/packages#9985

Closed

victorsanni deleted the nav-bar-fix branch September 9, 2025 19:31

lukemmtt mentioned this pull request Oct 9, 2025

Fix: menu positioning in CupertinoNavigationBar on Flutter 3.35.x notDmDrl/pull_down_button#76

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

d32855515 Nav bar static components respect ambient MediaQueryData (f…

bfd309a

…lutter/flutter#174673)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Nav bar static components respect ambient MediaQueryData #174673

Nav bar static components respect ambient MediaQueryData #174673

Uh oh!

victorsanni commented Aug 28, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

dkwingsmt left a comment

Uh oh!

dkwingsmt Sep 4, 2025

Uh oh!

dkwingsmt Sep 4, 2025

Uh oh!

victorsanni Sep 4, 2025

Uh oh!

dkwingsmt Sep 4, 2025 •

edited

Loading

Uh oh!

victorsanni Sep 4, 2025

Uh oh!

dkwingsmt Sep 4, 2025

Uh oh!

Uh oh!

MitchellGoodwin left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Nav bar static components respect ambient MediaQueryData #174673

Nav bar static components respect ambient MediaQueryData #174673

Uh oh!

Conversation

victorsanni commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victorsanni Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

victorsanni commented Aug 28, 2025 •

edited

Loading

dkwingsmt Sep 4, 2025 •

edited

Loading