Add a gn --ccache argument #174621
Add a gn --ccache argument #174621
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a --ccache argument to the gn script, enabling the use of ccache to speed up local builds on Linux and macOS. The changes include modifications to the gn Python script to parse this new argument and an update to the Compiling-the-engine.md documentation to explain its usage. My review focuses on improving the developer experience by adding a help message for the new command-line flag and refining the documentation for better clarity.
This enables the use of ccache on Linux and Mac systems.
robert-ancell
force-pushed
the
ccache-build-option
branch
from
9649d86 to
1c79941
Compare
|
test-exempt: build configuration |
robert-ancell
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/174621, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
robert-ancell
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/174621, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
robert-ancell
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/174621, because - The status or check suite Mac tool_integration_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/flutter@29a238d...8d0b31d 2025-09-16 [email protected] Roll Packages from fcd5f68 to 0255ac9 (2 revisions) (flutter/flutter#175427) 2025-09-16 [email protected] Adds a11y section locale support for iOS (flutter/flutter#175005) 2025-09-16 [email protected] Roll Skia from 4e9c86d4a6d9 to 7d160bbf9403 (3 revisions) (flutter/flutter#175404) 2025-09-16 [email protected] [native_assets] Find more `CCompilerConfig` on Linux (flutter/flutter#175323) 2025-09-16 [email protected] Roll Dart SDK from 50e61e5bff51 to 700de52f29a9 (3 revisions) (flutter/flutter#175395) 2025-09-16 [email protected] Fix default overlay color in `TabBar` (flutter/flutter#175270) 2025-09-16 [email protected] Migrate to widget state (flutter/flutter#175242) 2025-09-16 [email protected] Roll Skia from 01b0ede33ae9 to 4e9c86d4a6d9 (1 revision) (flutter/flutter#175387) 2025-09-15 [email protected] Merge the engine README into the README of the old buildroot. (flutter/flutter#175384) 2025-09-15 [email protected] Marks Mac_ios microbenchmarks_ios to be unflaky (flutter/flutter#171146) 2025-09-15 [email protected] Deprecate Objective-C plugin template (flutter/flutter#174003) 2025-09-15 [email protected] Add a gn --ccache argument (flutter/flutter#174621) 2025-09-15 [email protected] Update `build.gradle` to remove deprecation warning in `flutter\engine\src\flutter\shell\platform\android` (flutter/flutter#175305) 2025-09-15 [email protected] Show cursor after swipe only if TextField has focus (flutter/flutter#175044) 2025-09-15 [email protected] Roll Skia from f950263bb3d4 to 01b0ede33ae9 (7 revisions) (flutter/flutter#175373) 2025-09-15 [email protected] Update Chromium sysroot to pick up RISC-V support. (flutter/flutter#173671) 2025-09-15 [email protected] Set Gemini Code Assist `include_drafts` to false (flutter/flutter#175098) 2025-09-15 [email protected] Roll Packages from 15e7e89 to fcd5f68 (3 revisions) (flutter/flutter#175366) 2025-09-15 [email protected] Remove 'v' Open DevTools from help on web in profile/release mode (flutter/flutter#172829) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This enables the use of ccache on Linux and Mac systems. --------- Co-authored-by: Loïc Sharma <[email protected]>
This enables the use of ccache on Linux and Mac systems. --------- Co-authored-by: Loïc Sharma <[email protected]>
This enables the use of ccache on Linux and Mac systems.
This enables the use of ccache on Linux and Mac systems. --------- Co-authored-by: Loïc Sharma <[email protected]>
This enables the use of ccache on Linux and Mac systems. --------- Co-authored-by: Loïc Sharma <[email protected]>
4 participants
This enables the use of ccache on Linux and Mac systems.