[CP-stable][ Tool ] Roll 24.4.0+2 hotfix release of package:dwds #174599
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
the
tool
bkonyi
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request rolls a hotfix for the dwds package, updating it to version 24.4.0+2. The change, isolated to pubspec.yaml, is intended to resolve an issue with excessive console error messages during Flutter web debugging. The update is straightforward and aligns with the PR's objective. I've reviewed the change and found no issues. The repository's style guide notes that cherry-picks like this one have typically been reviewed on the master branch already.
matanlurey
added
the
autosubmit
2 participants
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#174437
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
When running a Flutter web application in debug mode, the console is spammed with non-fatal error messages.
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
When running a Flutter web application in debug mode, the console is spammed with
DebugService: Error serving requestsError: Unsupported operation: Cannot send Null.Workaround:
Is there a workaround for this issue?
Manually patching
$PUB_CACHE/hosted/pub.dev/dwds-24.4.0+1/lib/src/services/debug_service.dartas described in #174437 (comment).Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Run
flutter run -d chromeand see that the console spam is gone.