Repository navigation
Explicitly specify softfp ABI for armv7 builds - #17453
Merged
Merged
Conversation
Member
Author
|
Fixes #17387 |
tvolkert
reviewed
May 10, 2018
Member
Author
There was a problem hiding this comment.
Looks like I forgot to re-push after I killed that block. On my phone though so will re-push in the morning.
This reverts flutter#17147, which was safe under the assumption that getArtifactPath() returns a platform-specific gen_snapshot instance (which have the correct default set for this flag) -- it turns out that though we pass the platform to getArtifactPath(), we always return the host gen_snapshot for Android. A followup patch will update getArtifactPath and revert this patch.
tvolkert
approved these changes
May 10, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This reverts flutter#17147, which was safe under the assumption that getArtifactPath() returns a platform-specific gen_snapshot instance (which have the correct default set for this flag) -- it turns out that though we pass the platform to getArtifactPath(), we always return the host gen_snapshot for Android. A followup patch will update getArtifactPath and revert this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #17147, which was safe under the assumption that
getArtifactPath() returns a platform-specific gen_snapshot instance
(which have the correct default set for this flag) -- it turns out that
though we pass the platform to getArtifactPath(), we always return the
host gen_snapshot for Android.
A followup patch will update getArtifactPath() and revert this patch.