[CP-stable]_downloadArtifacts (Web SDK) uses content-aware hashing in post-submit
#174309
Conversation
…mit (flutter#174236) Towards flutter#174225. Will need to get cherry-picked into 3.35 and 3.36.
|
@matanlurey please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
engine
matanlurey
added
autosubmit
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces content-aware hashing for downloading Web SDK artifacts in post-submit builds. It adds a mechanism to calculate a hash based on the content of the engine source files and uses this hash to construct the download URL for artifacts from Google Cloud Storage. This replaces the use of git revision hashes for post-submit builds, enabling more reliable and reproducible artifact fetching. The changes involve adding a new contentHash variable, updating the Environment to be aware of the Flutter root directory, and modifying the artifact download step to use the new hash. My review suggests adding documentation to the new public contentHash variable to align with the project's style guide.
…343c4e79ac133bedd3cf32a1cf
matanlurey
added
the
autosubmit
auto-submit
bot
merged commit a8bfdfc
into
flutter:flutter-3.35-candidate.0
…e hashing in post-submit (flutter/flutter#174309)
2 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
< Replace with issue link here >
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
< Replace with changelog description here >
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
< Replace with impact description here >
Workaround:
Is there a workaround for this issue?
< Replace with workaround here >
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
< Replace with validation steps here >