Clarify how Gemini should handle conflicting guidelines #174294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
matanlurey
approved these changes
Aug 22, 2025
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Let's see if it works!
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 25, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 25, 2025
flutter/flutter@edd434a...a4cb00a 2025-08-25 [email protected] Clarify how Gemini should handle conflicting guidelines (flutter/flutter#174294) 2025-08-25 [email protected] [skwasm] Port to `DisplayList` objects (flutter/flutter#172314) 2025-08-25 [email protected] Roll Packages from 092d832 to fe66130 (4 revisions) (flutter/flutter#174373) 2025-08-25 [email protected] Roll Dart SDK from 4f9623f024ab to e283a9e88242 (8 revisions) (flutter/flutter#174358) 2025-08-25 [email protected] Roll Skia from 3bcd0a1d8c48 to da724d312e65 (1 revision) (flutter/flutter#174357) 2025-08-25 [email protected] Roll Skia from 8689a1169a32 to 3bcd0a1d8c48 (4 revisions) (flutter/flutter#174353) 2025-08-25 [email protected] Roll Fuchsia Linux SDK from 21v1vYTYWmyEHu-eP... to UiY8gj468PZUj6QTm... (flutter/flutter#174349) 2025-08-24 [email protected] Roll Skia from 61169c1f6f7c to 8689a1169a32 (2 revisions) (flutter/flutter#174343) 2025-08-24 [email protected] Roll Fuchsia Linux SDK from XLSNQCsY1VkIthSjt... to 21v1vYTYWmyEHu-eP... (flutter/flutter#174332) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
I ran into a case where [Gemini gave me bad code style advice](flutter#174291 (review)) that it got from Effective Dart even though it conflicted with the Flutter styleguide. This is my attempt to remedy that. Fixes flutter#174293
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
I ran into a case where [Gemini gave me bad code style advice](flutter#174291 (review)) that it got from Effective Dart even though it conflicted with the Flutter styleguide. This is my attempt to remedy that. Fixes flutter#174293
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
I ran into a case where [Gemini gave me bad code style advice](flutter#174291 (review)) that it got from Effective Dart even though it conflicted with the Flutter styleguide. This is my attempt to remedy that. Fixes flutter#174293
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
I ran into a case where [Gemini gave me bad code style advice](flutter#174291 (review)) that it got from Effective Dart even though it conflicted with the Flutter styleguide. This is my attempt to remedy that. Fixes flutter#174293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a case where Gemini gave me bad code style advice that it got from Effective Dart even though it conflicted with the Flutter styleguide. This is my attempt to remedy that.
Fixes #174293