-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Migrate more files to WidgetStateProperty
#174268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate more files to WidgetStateProperty
#174268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request continues the migration from MaterialStateProperty to WidgetStateProperty across various files. The changes are mostly correct and align with the goal of the PR. I've added a few suggestions to also replace the deprecated MaterialStatePropertyAll with its successor WidgetStatePropertyAll for consistency. This will help complete the migration in the touched files.
| backgroundColor, | ||
| disabledBackgroundColor, | ||
| )) { | ||
| (_?, null) => MaterialStatePropertyAll<Color?>(backgroundColor), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| }; | ||
| final MaterialStateProperty<Color?>? iconColorProp = switch ((iconColor, disabledIconColor)) { | ||
| final WidgetStateProperty<Color?>? iconColorProp = switch ((iconColor, disabledIconColor)) { | ||
| (_?, null) => MaterialStatePropertyAll<Color?>(iconColor), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const WidgetStateProperty<TextStyle> textStyle = MaterialStatePropertyAll<TextStyle>( | ||
| TextStyle(fontSize: 10), | ||
| ); | ||
| const MaterialStateProperty<Color> backgroundColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> backgroundColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff1), | ||
| ); | ||
| const MaterialStateProperty<Color> foregroundColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> foregroundColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff2), | ||
| ); | ||
| const MaterialStateProperty<Color> overlayColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> overlayColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff3), | ||
| ); | ||
| const MaterialStateProperty<Color> shadowColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> shadowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff4), | ||
| ); | ||
| const MaterialStateProperty<Color> surfaceTintColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> surfaceTintColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff5), | ||
| ); | ||
| const MaterialStateProperty<double> elevation = MaterialStatePropertyAll<double>(1); | ||
| const MaterialStateProperty<EdgeInsets> padding = MaterialStatePropertyAll<EdgeInsets>( | ||
| const WidgetStateProperty<double> elevation = MaterialStatePropertyAll<double>(1); | ||
| const WidgetStateProperty<EdgeInsets> padding = MaterialStatePropertyAll<EdgeInsets>( | ||
| EdgeInsets.all(1), | ||
| ); | ||
| const MaterialStateProperty<Size> minimumSize = MaterialStatePropertyAll<Size>(Size(1, 2)); | ||
| const MaterialStateProperty<Size> fixedSize = MaterialStatePropertyAll<Size>(Size(3, 4)); | ||
| const MaterialStateProperty<Size> maximumSize = MaterialStatePropertyAll<Size>(Size(5, 6)); | ||
| const MaterialStateProperty<Color> iconColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Size> minimumSize = MaterialStatePropertyAll<Size>(Size(1, 2)); | ||
| const WidgetStateProperty<Size> fixedSize = MaterialStatePropertyAll<Size>(Size(3, 4)); | ||
| const WidgetStateProperty<Size> maximumSize = MaterialStatePropertyAll<Size>(Size(5, 6)); | ||
| const WidgetStateProperty<Color> iconColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff6), | ||
| ); | ||
| const MaterialStateProperty<double> iconSize = MaterialStatePropertyAll<double>(48.0); | ||
| const MaterialStateProperty<BorderSide> side = MaterialStatePropertyAll<BorderSide>( | ||
| const WidgetStateProperty<double> iconSize = MaterialStatePropertyAll<double>(48.0); | ||
| const WidgetStateProperty<BorderSide> side = MaterialStatePropertyAll<BorderSide>( | ||
| BorderSide(), | ||
| ); | ||
| const MaterialStateProperty<OutlinedBorder> shape = MaterialStatePropertyAll<OutlinedBorder>( | ||
| const WidgetStateProperty<OutlinedBorder> shape = MaterialStatePropertyAll<OutlinedBorder>( | ||
| StadiumBorder(), | ||
| ); | ||
| const MaterialStateProperty<MouseCursor> mouseCursor = MaterialStatePropertyAll<MouseCursor>( | ||
| const WidgetStateProperty<MouseCursor> mouseCursor = MaterialStatePropertyAll<MouseCursor>( | ||
| SystemMouseCursors.forbidden, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of the migration to WidgetStateProperty, please also replace the deprecated MaterialStatePropertyAll with WidgetStatePropertyAll for consistency.
const WidgetStateProperty<TextStyle> textStyle = WidgetStatePropertyAll<TextStyle>(
TextStyle(fontSize: 10),
);
const WidgetStateProperty<Color> backgroundColor = WidgetStatePropertyAll<Color>(
Color(0xfffffff1),
);
const WidgetStateProperty<Color> foregroundColor = WidgetStatePropertyAll<Color>(
Color(0xfffffff2),
);
const WidgetStateProperty<Color> overlayColor = WidgetStatePropertyAll<Color>(
Color(0xfffffff3),
);
const WidgetStateProperty<Color> shadowColor = WidgetStatePropertyAll<Color>(
Color(0xfffffff4),
);
const WidgetStateProperty<Color> surfaceTintColor = WidgetStatePropertyAll<Color>(
Color(0xfffffff5),
);
const WidgetStateProperty<double> elevation = WidgetStatePropertyAll<double>(1);
const WidgetStateProperty<EdgeInsets> padding = WidgetStatePropertyAll<EdgeInsets>(
EdgeInsets.all(1),
);
const WidgetStateProperty<Size> minimumSize = WidgetStatePropertyAll<Size>(Size(1, 2));
const WidgetStateProperty<Size> fixedSize = WidgetStatePropertyAll<Size>(Size(3, 4));
const WidgetStateProperty<Size> maximumSize = WidgetStatePropertyAll<Size>(Size(5, 6));
const WidgetStateProperty<Color> iconColor = WidgetStatePropertyAll<Color>(
Color(0xfffffff6),
);
const WidgetStateProperty<double> iconSize = WidgetStatePropertyAll<double>(48.0);
const WidgetStateProperty<BorderSide> side = WidgetStatePropertyAll<BorderSide>(
BorderSide(),
);
const WidgetStateProperty<OutlinedBorder> shape = WidgetStatePropertyAll<OutlinedBorder>(
StadiumBorder(),
);
const WidgetStateProperty<MouseCursor> mouseCursor = WidgetStatePropertyAll<MouseCursor>(
SystemMouseCursors.forbidden,
);| const WidgetStateProperty<Color> dataRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff1), | ||
| ); | ||
| const double minMaxDataRowHeight = 41.0; | ||
| const TextStyle dataTextStyle = TextStyle(fontSize: 12.5); | ||
| const MaterialStateProperty<Color> headingRowColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> headingRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff2), | ||
| ); | ||
| const double headingRowHeight = 52.0; | ||
| const TextStyle headingTextStyle = TextStyle(fontSize: 14.5); | ||
| const double horizontalMargin = 3.0; | ||
| const double columnSpacing = 4.0; | ||
| const double dividerThickness = 5.0; | ||
| const MaterialStateProperty<MouseCursor> headingCellCursor = | ||
| const WidgetStateProperty<MouseCursor> headingCellCursor = | ||
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.grab); | ||
| const MaterialStateProperty<MouseCursor> dataRowCursor = MaterialStatePropertyAll<MouseCursor>( | ||
| const WidgetStateProperty<MouseCursor> dataRowCursor = MaterialStatePropertyAll<MouseCursor>( | ||
| SystemMouseCursors.forbidden, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the migration to WidgetStateProperty, please also replace the deprecated MaterialStatePropertyAll with WidgetStatePropertyAll.
| const WidgetStateProperty<Color> dataRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double minMaxDataRowHeight = 41.0; | |
| const TextStyle dataTextStyle = TextStyle(fontSize: 12.5); | |
| const MaterialStateProperty<Color> headingRowColor = MaterialStatePropertyAll<Color>( | |
| const WidgetStateProperty<Color> headingRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff2), | |
| ); | |
| const double headingRowHeight = 52.0; | |
| const TextStyle headingTextStyle = TextStyle(fontSize: 14.5); | |
| const double horizontalMargin = 3.0; | |
| const double columnSpacing = 4.0; | |
| const double dividerThickness = 5.0; | |
| const MaterialStateProperty<MouseCursor> headingCellCursor = | |
| const WidgetStateProperty<MouseCursor> headingCellCursor = | |
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.grab); | |
| const MaterialStateProperty<MouseCursor> dataRowCursor = MaterialStatePropertyAll<MouseCursor>( | |
| const WidgetStateProperty<MouseCursor> dataRowCursor = MaterialStatePropertyAll<MouseCursor>( | |
| SystemMouseCursors.forbidden, | |
| ); | |
| const WidgetStateProperty<Color> dataRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double minMaxDataRowHeight = 41.0; | |
| const TextStyle dataTextStyle = TextStyle(fontSize: 12.5); | |
| const WidgetStateProperty<Color> headingRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff2), | |
| ); | |
| const double headingRowHeight = 52.0; | |
| const TextStyle headingTextStyle = TextStyle(fontSize: 14.5); | |
| const double horizontalMargin = 3.0; | |
| const double columnSpacing = 4.0; | |
| const double dividerThickness = 5.0; | |
| const WidgetStateProperty<MouseCursor> headingCellCursor = | |
| WidgetStatePropertyAll<MouseCursor>(SystemMouseCursors.grab); | |
| const WidgetStateProperty<MouseCursor> dataRowCursor = WidgetStatePropertyAll<MouseCursor>( | |
| SystemMouseCursors.forbidden, | |
| ); |
| const WidgetStateProperty<Color> themeDataRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff0), | ||
| ); | ||
| const double minMaxThemeDataRowHeight = 50.0; | ||
| const TextStyle themeDataTextStyle = TextStyle(fontSize: 11.5); | ||
| const MaterialStateProperty<Color> themeHeadingRowColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> themeHeadingRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff1), | ||
| ); | ||
| const double themeHeadingRowHeight = 51.0; | ||
| const TextStyle themeHeadingTextStyle = TextStyle(fontSize: 13.5); | ||
| const double themeHorizontalMargin = 2.0; | ||
| const double themeColumnSpacing = 3.0; | ||
| const double themeDividerThickness = 4.0; | ||
| const MaterialStateProperty<MouseCursor> themeHeadingCellCursor = | ||
| const WidgetStateProperty<MouseCursor> themeHeadingCellCursor = | ||
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.copy); | ||
| const MaterialStateProperty<MouseCursor> themeDataRowCursor = | ||
| const WidgetStateProperty<MouseCursor> themeDataRowCursor = | ||
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.copy); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the migration to WidgetStateProperty, please also replace the deprecated MaterialStatePropertyAll with WidgetStatePropertyAll.
| const WidgetStateProperty<Color> themeDataRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff0), | |
| ); | |
| const double minMaxThemeDataRowHeight = 50.0; | |
| const TextStyle themeDataTextStyle = TextStyle(fontSize: 11.5); | |
| const MaterialStateProperty<Color> themeHeadingRowColor = MaterialStatePropertyAll<Color>( | |
| const WidgetStateProperty<Color> themeHeadingRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double themeHeadingRowHeight = 51.0; | |
| const TextStyle themeHeadingTextStyle = TextStyle(fontSize: 13.5); | |
| const double themeHorizontalMargin = 2.0; | |
| const double themeColumnSpacing = 3.0; | |
| const double themeDividerThickness = 4.0; | |
| const MaterialStateProperty<MouseCursor> themeHeadingCellCursor = | |
| const WidgetStateProperty<MouseCursor> themeHeadingCellCursor = | |
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.copy); | |
| const MaterialStateProperty<MouseCursor> themeDataRowCursor = | |
| const WidgetStateProperty<MouseCursor> themeDataRowCursor = | |
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.copy); | |
| const WidgetStateProperty<Color> themeDataRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff0), | |
| ); | |
| const double minMaxThemeDataRowHeight = 50.0; | |
| const TextStyle themeDataTextStyle = TextStyle(fontSize: 11.5); | |
| const WidgetStateProperty<Color> themeHeadingRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double themeHeadingRowHeight = 51.0; | |
| const TextStyle themeHeadingTextStyle = TextStyle(fontSize: 13.5); | |
| const double themeHorizontalMargin = 2.0; | |
| const double themeColumnSpacing = 3.0; | |
| const double themeDividerThickness = 4.0; | |
| const WidgetStateProperty<MouseCursor> themeHeadingCellCursor = | |
| WidgetStatePropertyAll<MouseCursor>(SystemMouseCursors.copy); | |
| const WidgetStateProperty<MouseCursor> themeDataRowCursor = | |
| WidgetStatePropertyAll<MouseCursor>(SystemMouseCursors.copy); |
| const WidgetStateProperty<Color> dataRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff1), | ||
| ); | ||
| const double minMaxDataRowHeight = 51.0; | ||
| const TextStyle dataTextStyle = TextStyle(fontSize: 12.5); | ||
| const MaterialStateProperty<Color> headingRowColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> headingRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff2), | ||
| ); | ||
| const double headingRowHeight = 52.0; | ||
| const TextStyle headingTextStyle = TextStyle(fontSize: 14.5); | ||
| const double horizontalMargin = 3.0; | ||
| const double columnSpacing = 4.0; | ||
| const double dividerThickness = 5.0; | ||
| const MaterialStateProperty<MouseCursor> headingCellCursor = | ||
| const WidgetStateProperty<MouseCursor> headingCellCursor = | ||
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.forbidden); | ||
| const MaterialStateProperty<MouseCursor> dataRowCursor = MaterialStatePropertyAll<MouseCursor>( | ||
| const WidgetStateProperty<MouseCursor> dataRowCursor = MaterialStatePropertyAll<MouseCursor>( | ||
| SystemMouseCursors.forbidden, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the migration to WidgetStateProperty, please also replace the deprecated MaterialStatePropertyAll with WidgetStatePropertyAll.
| const WidgetStateProperty<Color> dataRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double minMaxDataRowHeight = 51.0; | |
| const TextStyle dataTextStyle = TextStyle(fontSize: 12.5); | |
| const MaterialStateProperty<Color> headingRowColor = MaterialStatePropertyAll<Color>( | |
| const WidgetStateProperty<Color> headingRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff2), | |
| ); | |
| const double headingRowHeight = 52.0; | |
| const TextStyle headingTextStyle = TextStyle(fontSize: 14.5); | |
| const double horizontalMargin = 3.0; | |
| const double columnSpacing = 4.0; | |
| const double dividerThickness = 5.0; | |
| const MaterialStateProperty<MouseCursor> headingCellCursor = | |
| const WidgetStateProperty<MouseCursor> headingCellCursor = | |
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.forbidden); | |
| const MaterialStateProperty<MouseCursor> dataRowCursor = MaterialStatePropertyAll<MouseCursor>( | |
| const WidgetStateProperty<MouseCursor> dataRowCursor = MaterialStatePropertyAll<MouseCursor>( | |
| SystemMouseCursors.forbidden, | |
| ); | |
| const WidgetStateProperty<Color> dataRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double minMaxDataRowHeight = 51.0; | |
| const TextStyle dataTextStyle = TextStyle(fontSize: 12.5); | |
| const WidgetStateProperty<Color> headingRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff2), | |
| ); | |
| const double headingRowHeight = 52.0; | |
| const TextStyle headingTextStyle = TextStyle(fontSize: 14.5); | |
| const double horizontalMargin = 3.0; | |
| const double columnSpacing = 4.0; | |
| const double dividerThickness = 5.0; | |
| const WidgetStateProperty<MouseCursor> headingCellCursor = | |
| WidgetStatePropertyAll<MouseCursor>(SystemMouseCursors.forbidden); | |
| const WidgetStateProperty<MouseCursor> dataRowCursor = WidgetStatePropertyAll<MouseCursor>( | |
| SystemMouseCursors.forbidden, | |
| ); |
| const WidgetStateProperty<Color> globalThemeDataRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff0), | ||
| ); | ||
| const double minMaxGlobalThemeDataRowHeight = 50.0; | ||
| const TextStyle globalThemeDataTextStyle = TextStyle(fontSize: 11.5); | ||
| const MaterialStateProperty<Color> globalThemeHeadingRowColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> globalThemeHeadingRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff1), | ||
| ); | ||
| const double globalThemeHeadingRowHeight = 51.0; | ||
| const TextStyle globalThemeHeadingTextStyle = TextStyle(fontSize: 13.5); | ||
| const double globalThemeHorizontalMargin = 2.0; | ||
| const double globalThemeColumnSpacing = 3.0; | ||
| const double globalThemeDividerThickness = 4.0; | ||
| const MaterialStateProperty<MouseCursor> globalHeadingCellCursor = | ||
| const WidgetStateProperty<MouseCursor> globalHeadingCellCursor = | ||
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.allScroll); | ||
| const MaterialStateProperty<MouseCursor> globalDataRowCursor = | ||
| const WidgetStateProperty<MouseCursor> globalDataRowCursor = | ||
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.allScroll); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the migration to WidgetStateProperty, please also replace the deprecated MaterialStatePropertyAll with WidgetStatePropertyAll.
| const WidgetStateProperty<Color> globalThemeDataRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff0), | |
| ); | |
| const double minMaxGlobalThemeDataRowHeight = 50.0; | |
| const TextStyle globalThemeDataTextStyle = TextStyle(fontSize: 11.5); | |
| const MaterialStateProperty<Color> globalThemeHeadingRowColor = MaterialStatePropertyAll<Color>( | |
| const WidgetStateProperty<Color> globalThemeHeadingRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double globalThemeHeadingRowHeight = 51.0; | |
| const TextStyle globalThemeHeadingTextStyle = TextStyle(fontSize: 13.5); | |
| const double globalThemeHorizontalMargin = 2.0; | |
| const double globalThemeColumnSpacing = 3.0; | |
| const double globalThemeDividerThickness = 4.0; | |
| const MaterialStateProperty<MouseCursor> globalHeadingCellCursor = | |
| const WidgetStateProperty<MouseCursor> globalHeadingCellCursor = | |
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.allScroll); | |
| const MaterialStateProperty<MouseCursor> globalDataRowCursor = | |
| const WidgetStateProperty<MouseCursor> globalDataRowCursor = | |
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.allScroll); | |
| const WidgetStateProperty<Color> globalThemeDataRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff0), | |
| ); | |
| const double minMaxGlobalThemeDataRowHeight = 50.0; | |
| const TextStyle globalThemeDataTextStyle = TextStyle(fontSize: 11.5); | |
| const WidgetStateProperty<Color> globalThemeHeadingRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double globalThemeHeadingRowHeight = 51.0; | |
| const TextStyle globalThemeHeadingTextStyle = TextStyle(fontSize: 13.5); | |
| const double globalThemeHorizontalMargin = 2.0; | |
| const double globalThemeColumnSpacing = 3.0; | |
| const double globalThemeDividerThickness = 4.0; | |
| const WidgetStateProperty<MouseCursor> globalHeadingCellCursor = | |
| WidgetStatePropertyAll<MouseCursor>(SystemMouseCursors.allScroll); | |
| const WidgetStateProperty<MouseCursor> globalDataRowCursor = | |
| WidgetStatePropertyAll<MouseCursor>(SystemMouseCursors.allScroll); |
| const WidgetStateProperty<Color> localThemeDataRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff1), | ||
| ); | ||
| const double minMaxLocalThemeDataRowHeight = 51.0; | ||
| const TextStyle localThemeDataTextStyle = TextStyle(fontSize: 12.5); | ||
| const MaterialStateProperty<Color> localThemeHeadingRowColor = MaterialStatePropertyAll<Color>( | ||
| const WidgetStateProperty<Color> localThemeHeadingRowColor = MaterialStatePropertyAll<Color>( | ||
| Color(0xfffffff2), | ||
| ); | ||
| const double localThemeHeadingRowHeight = 52.0; | ||
| const TextStyle localThemeHeadingTextStyle = TextStyle(fontSize: 14.5); | ||
| const double localThemeHorizontalMargin = 3.0; | ||
| const double localThemeColumnSpacing = 4.0; | ||
| const double localThemeDividerThickness = 5.0; | ||
| const MaterialStateProperty<MouseCursor> localHeadingCellCursor = | ||
| const WidgetStateProperty<MouseCursor> localHeadingCellCursor = | ||
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.move); | ||
| const MaterialStateProperty<MouseCursor> localDataRowCursor = | ||
| const WidgetStateProperty<MouseCursor> localDataRowCursor = | ||
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.move); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the migration to WidgetStateProperty, please also replace the deprecated MaterialStatePropertyAll with WidgetStatePropertyAll.
| const WidgetStateProperty<Color> localThemeDataRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double minMaxLocalThemeDataRowHeight = 51.0; | |
| const TextStyle localThemeDataTextStyle = TextStyle(fontSize: 12.5); | |
| const MaterialStateProperty<Color> localThemeHeadingRowColor = MaterialStatePropertyAll<Color>( | |
| const WidgetStateProperty<Color> localThemeHeadingRowColor = MaterialStatePropertyAll<Color>( | |
| Color(0xfffffff2), | |
| ); | |
| const double localThemeHeadingRowHeight = 52.0; | |
| const TextStyle localThemeHeadingTextStyle = TextStyle(fontSize: 14.5); | |
| const double localThemeHorizontalMargin = 3.0; | |
| const double localThemeColumnSpacing = 4.0; | |
| const double localThemeDividerThickness = 5.0; | |
| const MaterialStateProperty<MouseCursor> localHeadingCellCursor = | |
| const WidgetStateProperty<MouseCursor> localHeadingCellCursor = | |
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.move); | |
| const MaterialStateProperty<MouseCursor> localDataRowCursor = | |
| const WidgetStateProperty<MouseCursor> localDataRowCursor = | |
| MaterialStatePropertyAll<MouseCursor>(SystemMouseCursors.move); | |
| const WidgetStateProperty<Color> localThemeDataRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff1), | |
| ); | |
| const double minMaxLocalThemeDataRowHeight = 51.0; | |
| const TextStyle localThemeDataTextStyle = TextStyle(fontSize: 12.5); | |
| const WidgetStateProperty<Color> localThemeHeadingRowColor = WidgetStatePropertyAll<Color>( | |
| Color(0xfffffff2), | |
| ); | |
| const double localThemeHeadingRowHeight = 52.0; | |
| const TextStyle localThemeHeadingTextStyle = TextStyle(fontSize: 14.5); | |
| const double localThemeHorizontalMargin = 3.0; | |
| const double localThemeColumnSpacing = 4.0; | |
| const double localThemeDividerThickness = 5.0; | |
| const WidgetStateProperty<MouseCursor> localHeadingCellCursor = | |
| WidgetStatePropertyAll<MouseCursor>(SystemMouseCursors.move); | |
| const WidgetStateProperty<MouseCursor> localDataRowCursor = | |
| WidgetStatePropertyAll<MouseCursor>(SystemMouseCursors.move); |
|
About gemini's comments, I was planning to tackle them 1 by 1. Right now, I'm working on What do you think about that plan? |
7e4466c to
3f3a26a
Compare
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . I'm on board with your plan, so you can ignore Gemini's comments for now. Thanks for doing all of this migration!
flutter/flutter@26bb33b...edd434a 2025-08-23 [email protected] Roll Skia from 6f710e0b38f7 to 61169c1f6f7c (1 revision) (flutter/flutter#174325) 2025-08-23 [email protected] Roll Fuchsia Linux SDK from Z-ZaFQ7jAqJ1OrIBf... to XLSNQCsY1VkIthSjt... (flutter/flutter#174318) 2025-08-23 [email protected] Roll Skia from ebb6051e8bb1 to 6f710e0b38f7 (1 revision) (flutter/flutter#174317) 2025-08-22 [email protected] [web] Expose rasterizers in Renderer (flutter/flutter#174308) 2025-08-22 [email protected] Update some semantics flags updated to use enum (engine, framework, web) (flutter/flutter#170696) 2025-08-22 [email protected] [ Tool ] Don't emit artifact downloading messages when --machine is provided (flutter/flutter#174301) 2025-08-22 [email protected] Roll Skia from cb15e1452399 to ebb6051e8bb1 (5 revisions) (flutter/flutter#174296) 2025-08-22 [email protected] `_downloadArtifacts` (Web SDK) uses content-aware hashing in post-submit (flutter/flutter#174236) 2025-08-22 [email protected] Refactor text and runtime effect to separate skia and impeller implementations. (flutter/flutter#174219) 2025-08-22 [email protected] Roll Packages from 58c02e0 to 092d832 (4 revisions) (flutter/flutter#174295) 2025-08-22 [email protected] [ Widget Preview ] Add support for DevTools configuration (flutter/flutter#174272) 2025-08-22 [email protected] Migrate more files to `WidgetStateProperty` (flutter/flutter#174268) 2025-08-22 [email protected] [ Tool ] Ensure `--dds-port=<port>` is respected when targeting web devices (flutter/flutter#174278) 2025-08-22 [email protected] Marks Mac_ios ios_debug_workflow to be unflaky (flutter/flutter#174104) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Follow up of #174268 Final PR to migrate the usages of `MaterialStateProperty` to `WidgetStateProperty` I'll work on the other elements of `packages/flutter/lib/src/material/material_state.dart` into other PRs ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Another batch of files migrated to use WidgetStateProperty Follow up of flutter#174176 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Follow up of flutter#174268 Final PR to migrate the usages of `MaterialStateProperty` to `WidgetStateProperty` I'll work on the other elements of `packages/flutter/lib/src/material/material_state.dart` into other PRs ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Another batch of files migrated to use WidgetStateProperty Follow up of flutter#174176 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Follow up of flutter#174268 Final PR to migrate the usages of `MaterialStateProperty` to `WidgetStateProperty` I'll work on the other elements of `packages/flutter/lib/src/material/material_state.dart` into other PRs ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Another batch of files migrated to use WidgetStateProperty Follow up of flutter#174176 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Follow up of flutter#174268 Final PR to migrate the usages of `MaterialStateProperty` to `WidgetStateProperty` I'll work on the other elements of `packages/flutter/lib/src/material/material_state.dart` into other PRs ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Another batch of files migrated to use WidgetStateProperty Follow up of flutter#174176 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Follow up of flutter#174268 Final PR to migrate the usages of `MaterialStateProperty` to `WidgetStateProperty` I'll work on the other elements of `packages/flutter/lib/src/material/material_state.dart` into other PRs ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Another batch of files migrated to use WidgetStateProperty
Follow up of #174176
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.