Allow OverlayPortal.overlayChildLayoutBuilder to choose root Overlay #174239

chunhtai · 2025-08-21T20:43:02Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

chunhtai · 2025-08-21T20:44:34Z

packages/flutter/lib/src/widgets/overlay.dart

  /// Creates an [OverlayPortal] that renders the widget [overlayChildBuilder]
  /// builds on the root [Overlay] when [OverlayPortalController.show] is
  /// called.
+  @Deprecated(


I am neutral on whether to remove this. I did it now to remove redundancy and also can help clean up the code _targetRootOverlay if this eventually gets removed

I'm leaning towards deprecating this (and re-implement the underlying logic using the new API).

not possible since we need context to do Overlay.of(rootOverlay: true)

There are other alternatives, but that will make constructor non null (by using a OverlayState getter)

Ah I see yeah you don't have access to the root overlay until mounted.

gemini-code-assist

Code Review

This pull request introduces the ability for an OverlayPortal to target a specific Overlay via the new targetsOverlay property. This is a useful feature that provides more control over where the portal's child is rendered. The implementation is solid, involving passing the OverlayState down to the render objects and updating the lookup logic for the _RenderTheaterMarker. The OverlayPortal.targetsRootOverlay constructor is now correctly deprecated with a clear migration path. The changes are well-tested, including a new test case for targeting an arbitrary overlay.

I have one suggestion to improve the error message when a targeted Overlay is not found as an ancestor, which will enhance the developer experience.

gemini-code-assist · 2025-08-21T20:45:56Z

packages/flutter/lib/src/widgets/overlay.dart

+    if (marker == null) {
+      throw FlutterError.fromParts(<DiagnosticsNode>[
+        ErrorSummary('No Overlay widget found.'),
+        ErrorDescription(
+          '${context.widget.runtimeType} widgets require an Overlay widget ancestor.\n'
+          'An overlay lets widgets float on top of other widget children.',
+        ),
+        ErrorHint(
+          'To introduce an Overlay widget, you can either directly '
+          'include one, or use a widget that contains an Overlay itself, '
+          'such as a Navigator, WidgetApp, MaterialApp, or CupertinoApp.',
+        ),
+        ...context.describeMissingAncestor(expectedAncestorType: Overlay),
+      ]);
+    }


The error message thrown when an Overlay is not found could be more specific. If an OverlayState is found (either via targetsOverlay or Overlay.maybeOf), but its corresponding _RenderTheaterMarker is not an ancestor, the current error message "No Overlay widget found" can be misleading. A more precise error message would improve the debugging experience by clarifying that an Overlay was found, but it's not an ancestor of the OverlayPortal.¹

if (marker == null) { if (state != null) { throw FlutterError.fromParts(<DiagnosticsNode>[ ErrorSummary('The OverlayPortal could not find the target Overlay in its ancestors.'), ErrorDescription( 'The OverlayPortal widget must be a descendant of the Overlay it targets. ' 'The OverlayPortal was built with a context that does not include the specified Overlay.' ), if (widget.targetsOverlay != null) DiagnosticsProperty<OverlayState>('The targeted Overlay was', widget.targetsOverlay), ...context.describeMissingAncestor(expectedAncestorType: Overlay), ]); } throw FlutterError.fromParts(<DiagnosticsNode>[ ErrorSummary('No Overlay widget found.'), ErrorDescription( '${context.widget.runtimeType} widgets require an Overlay widget ancestor.\n' 'An overlay lets widgets float on top of other widget children.', ), ErrorHint( 'To introduce an Overlay widget, you can either directly ' 'include one, or use a widget that contains an Overlay itself, ' 'such as a Navigator, WidgetApp, MaterialApp, or CupertinoApp.', ), ...context.describeMissingAncestor(expectedAncestorType: Overlay), ]); }

Style Guide References

Footnotes

Error messages should be useful to help developers debug issues. The current error message can be misleading when a target Overlay is specified but not found as an ancestor. (link) ↩

LongCatIsLooong · 2025-08-21T22:18:18Z

packages/flutter/lib/src/widgets/overlay.dart

    super.key,
    required this.controller,
    required this.overlayChildBuilder,
+    this.targetsOverlay,


targetOverlay as a noun instead of a phrase?

yeah, has been reading too much objective c code

LongCatIsLooong · 2025-08-21T22:26:32Z

packages/flutter/lib/src/widgets/overlay.dart

+/// Use [targetsOverlay] to choose which [Overlay] this overlay portal
+/// attaches to. Consider using [GlobalKey] or [Overlay.of] with appropriate
+/// [BuildContext] to get the [OverlayState]. One can also use
+/// `Overlay.of(context, rootOverlay: true)` to pick the root [Overlay]. If


Hmm calling Overlay.of doesn't establish a dependency (it's not using an inheritedWidget). So if an OverlayPortal gets reparented to a different subtree where it can't see the old target Overlay, it's not guaranteed that the OverlayPortal's parent will rebuild to update the targetsOverlay parameter (e.g., if you cache the widget).

See: https://main-api.flutter.dev/flutter/widgets/Overlay/maybeOf.html

(I thought I had a test for this but apparently all tests are passing)

In that case, it is the consumer of this widget to ensure it grabs the correct overlay state when it change? (in State.activate)

not entirely sure what else we can do. using globalkey is not feasible unless we expose root overlay's globalkey all the way to WidgetsApp

it is the consumer of this widget to ensure it grabs the correct overlay state when it change

Yeah if the creator of the OverlayPortal widget rebuilds. But the problem is what if that widget doesn't rebuild because the user cached the widget, or the widget is a const instance? I think we need an alternative version of Overlay.of that establishes a dependency (i.e. an InheritedWidget for Overlay). To prevent these kind of bugs maybe the new of method should use a different type from OverlayState so people can't use Overlay.of for this API.

Looking at the code, I think the statefulElement will be rebuild when globalkey reparent. but not StatelessWidget. not sure why this is the case.

flutter/packages/flutter/lib/src/widgets/framework.dart

Line 6019 in 7130981

markNeedsBuild();

Can the overlay.of create dependency be another pr?

If you had dependencies before getting reparented, you'll rebuilt on activation (via didChangeDependencies):

flutter/packages/flutter/lib/src/widgets/framework.dart

Lines 4758 to 4772 in f0f208d

final bool hadDependencies =

(_dependencies?.isNotEmpty ?? false) || _hadUnsatisfiedDependencies;

_lifecycleState = _ElementLifecycle.active;

// We unregistered our dependencies in deactivate, but never cleared the list.

// Since we're going to be reused, let's clear our list now.

_dependencies?.clear();

_hadUnsatisfiedDependencies = false;

_updateInheritance();

attachNotificationTree();

if (_dirty) {

owner!.scheduleBuildFor(this);

}

if (hadDependencies) {

didChangeDependencies();

}

I think the statefulElement will be rebuild when globalkey reparent.

Looks like the issue was #2901, but I'm not sure as to why that was needed (given that elements with dependencies already rebuild on activation, and that both the old parent Element and new parent Element rebuild)?

Can the overlay.of create dependency be another pr?

Yeah but I think the Overlay.of that establishes dependencies a prerequisite for this PR?

that both the old parent Element and new parent Element rebuild)?

If you don't have dependecy, but have some specialize logic to update state in activate, then this makes sense. My guess is that since State has access to to activate callback, this is necessary to make it not a footgun.

Yeah but I think the Overlay.of that establishes dependencies a prerequisite for this PR?

sgtm

chunhtai · 2025-08-26T23:38:46Z

a reminder to myself on how to write test that swap overlay
https://gist.github.com/chunhtai/6107ecfd30c95f00a6e4da00e6cbe86e

davidhicks980 · 2025-08-28T04:11:38Z

Before this lands, how are you thinking this could be integrated into a widget like RawMenuAnchor?

For RawMenuAnchor, there currently is only one constructor:

const RawMenuAnchor({
    super.key,
    this.childFocusNode,
    this.consumeOutsideTaps = false,
    this.onOpen,
    this.onClose,
    this.onOpenRequested = _defaultOnOpenRequested,
    this.onCloseRequested = _defaultOnCloseRequested,
    this.useRootOverlay = false,
    this.builder,
    required this.controller,
    Widget Function(BuildContext context, RawMenuOverlayInfo info)  required this.overlayBuilder,
    this.child,
  });

Some users of RawMenuAnchor support a follower layer (e.g. MenuAnchor), so using OverlayPortal.overlayChildLayoutBuilder within RawMenuAnchor would require an additional constructor on RawMenuAnchor -- one using overlayChildLayoutBuilder and one using the default constructor.

The reason why I mentioned making _OverlayChildLayoutBuilder public (see here) is because only a single OverlayPortal AND a single RawMenuAnchor constructor would be required -- there would no longer be the need for OverlayPortal.overlayChildLayoutBuilder since users of RawMenuAnchor could just insert a OverlayChildLayoutBuilder in their overlay. Choosing whether to use the OverlayChildLayoutBuilder would be the responsibility of downstream widgets (e.g. MenuAnchor) rather than upstream widgets (e.g. RawMenuAnchor).

Either way works for me, but I figure it's better to get your opinions on this now rather than after this lands.

LongCatIsLooong · 2025-08-28T18:10:02Z

Before this lands, how are you thinking this could be integrated into a widget like RawMenuAnchor?

For RawMenuAnchor, there currently is only one constructor:
const RawMenuAnchor({
    super.key,
    this.childFocusNode,
    this.consumeOutsideTaps = false,
    this.onOpen,
    this.onClose,
    this.onOpenRequested = _defaultOnOpenRequested,
    this.onCloseRequested = _defaultOnCloseRequested,
    this.useRootOverlay = false,
    this.builder,
    required this.controller,
    Widget Function(BuildContext context, RawMenuOverlayInfo info)  required this.overlayBuilder,
    this.child,
  });
Some users of RawMenuAnchor support a follower layer (e.g. MenuAnchor), so using OverlayPortal.overlayChildLayoutBuilder within RawMenuAnchor would require an additional constructor on RawMenuAnchor -- one using overlayChildLayoutBuilder and one using the default constructor.

The reason why I mentioned making _OverlayChildLayoutBuilder public (see here) is because only a single OverlayPortal AND a single RawMenuAnchor constructor would be required -- there would no longer be the need for OverlayPortal.overlayChildLayoutBuilder since users of RawMenuAnchor could just insert a OverlayChildLayoutBuilder in their overlay. Choosing whether to use the OverlayChildLayoutBuilder would be the responsibility of downstream widgets (e.g. MenuAnchor) rather than upstream widgets (e.g. RawMenuAnchor).

Either way works for me, but I figure it's better to get your opinions on this now rather than after this lands.

OverlayChildLayoutBuilder doesn't work outside of OverlayPortal. I think exposing that as a generic widget makes it harder to discover and much easier to misuse (like the way parentData can be misused in which case you'll get a runtime error).

davidhicks980 · 2025-08-29T05:19:36Z

@LongCatIsLooong Yeah, that makes sense. IIRC only calculating/passing layout info if dependence is established (e.g. OverlayPortal.childLayoutOf(context)) also wouldn't work since _computeNewLayoutInfo() would need to have been called prior to dependence. So, the current approach sounds good.

chunhtai · 2025-08-29T22:18:40Z

Turns out, the _RenderTheaderMarker.of already register dependencies, so swapping out overlay won't be a problem. I added more test regardless

LongCatIsLooong

The implementation lgtm.

I'm not very sure how best to evolve the API. I'm hoping we can add new locations to the OverlayLocation and eventually enable #136769, but now the controller argument gets in the way since it was introduced to track the z-index.

LongCatIsLooong · 2025-08-29T22:30:43Z

packages/flutter/lib/src/widgets/overlay.dart

  }
 }

+/// The location of the [Overlay] that a [OverlayPortal] attaches its overlay


nit: an [OverlayPortal].

Maybe something like "A type that represents the target [Overlay], which an [OverlayPortal] should render its overlay child on"?

I'm a bit torn on wether we should mention OverlayEntry here. Currently the overlay child is paint above the OverlayPortal's OverlayEntry and beneath the next OverlayEntry in the paint order, but it's already documented in the OverlayPortal class documentation, so I guess we can keep it simple for now (since the API that allows you to target a different OverlayEntry doesn't exist yet)?

LongCatIsLooong · 2025-08-29T23:29:17Z

packages/flutter/lib/src/widgets/overlay.dart

+///
+/// This is typically used in [OverlayPortal].
+enum OverlayLocation {
+  /// The [OverlayPortal] attaches to the immediate [Overlay] above the widget


The [OverlayPortal] renders its overlay child on the closest ancestor [Overlay], or some such?

LongCatIsLooong · 2025-08-29T23:32:03Z

packages/flutter/lib/src/widgets/overlay.dart

+enum OverlayLocation {
+  /// The [OverlayPortal] attaches to the immediate [Overlay] above the widget
+  /// tree.
+  nearest,


nearestOverlay in case we expose the ability to change the z-offset within an Overlay?

(also rootOverlay)

LongCatIsLooong · 2025-08-29T23:39:59Z

packages/flutter/lib/src/widgets/overlay.dart

+/// entry to.
+///
+/// This is typically used in [OverlayPortal].
+enum OverlayLocation {


maybe: OverlayChildLocation?

deminearchiver · 2025-08-30T03:36:36Z

Hello. I am not a contributor, but a developer using Flutter. When I first spotted this PR, the changes looked like they would allow passing an arbitrary OverlayState value to OverlayPortal.childLayoutBuilder. There even were tests for that, if I recall correctly. But now only the nearest or the root ancestor overlay locations are supported, which makes this PR less useful, probably. I was thought that it would be possible to pass a custom overlay that resides, for example, between the root overlay and the nearest ancestor, via a GlobalKey, or even in an arbitrary location in the tree since _OverlayChildLayoutBuilder establishes paint transform to the target overlay. I suppose there were some concerns about this implementation? I would be thankful if somebody explained why the API was nerfed so drastically from the initial changes.

chunhtai · 2025-09-02T16:37:35Z

the controller argument gets in the way since it was introduced to track the z-index.

If we want to be declarative, do we still need a controller?

chunhtai · 2025-09-02T17:02:54Z

@deminearchiver

The problem is that we still not sure how to implement it correctly. The previous implementation uses OverlayState as input, but the Overlay.of won't listen to overlayState changes in case of global key reparenting. We can make Overlay.of() to use dependsOnInheritedWidgetOfExactType to listen for OverlayState change, but it would be a breaking change if someone call Overlay.of in initState. This also brought the question whether takes an OverlayState as input is the best way to solve this problem.

Also the #136769, if we want to be fulling declarative, we not only need the OverlayState, we also need a way to specify z-index. That is why we decided to hold it back until we figure that out.

For now, we decided to solve the immediate issue first that the overlayChildLayoutBuilder to be able to choose the root overlay and keep the option open (using an enum class) for future improvement.

LongCatIsLooong

LGTM with nits

LongCatIsLooong · 2025-09-02T20:27:37Z

packages/flutter/test/widgets/overlay_portal_test.dart

+    final RenderObject newParentTheater = _ancestorRenderTheaters(
+      tester.renderObject(find.byKey(overlayPortal)),
+    ).single;
+    expect(parentTheater != newParentTheater, isTrue);


nit: expect(parentTheater, isNot(newParentTheater)) gives a better error message.

LongCatIsLooong · 2025-09-02T20:28:44Z

packages/flutter/test/widgets/overlay_portal_test.dart

+    );
+
+    controller1.show();
+    await tester.pumpAndSettle();


why pumpAndSettle? Shouldn't pump suffice here?

davidhicks980 · 2025-09-02T20:58:38Z

packages/flutter/lib/src/widgets/raw_menu_anchor.dart

+    return OverlayPortal(
+      controller: _overlayController,
+      overlayChildBuilder: _buildOverlay,
+      overlayLocation: useRootOverlay


At some point we should replace the useRootOverlay boolean with an overlayChildLocation param on RawMenuAnchor. I can also do this on a future PR since it's a breaking change.

LongCatIsLooong · 2025-09-03T21:54:32Z

Oh does this change break any registered test?

chunhtai · 2025-09-03T22:00:47Z

no, but deprecating the constructor must have broken someone's code.

LongCatIsLooong · 2025-09-03T22:05:58Z

no, but deprecating the constructor must have broken someone's code.

Would it be possible to apply a dart fix?

chunhtai · 2025-09-03T22:43:49Z

I don't think the dart fix can change name and add parameter. but I am not too familiar with the syntax

_Description of what this PR is changing or adding, and why:_ flutter/flutter#174239 _Issues fixed by this PR (if any):_ flutter/flutter#168785 ## Presubmit checklist - [ ] If you are unwilling, or unable, to sign the CLA, even for a _tiny_, one-word PR, please file an issue instead of a PR. - [ ] If this PR is not meant to land until a future stable release, mark it as draft with an explanation. - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style)—for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first-person pronouns). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour <[email protected]>

…t Overlay (flutter/flutter#174239)

Roll Flutter from 6b18740d5a23 to 87d5b753196c (88 revisions) flutter/flutter@6b18740...87d5b75 2025-09-05 [email protected] [ Device Lab ] Add regression testing for flutter/flutter#174952 (flutter/flutter#174956) 2025-09-05 [email protected] Roll Skia from 0ca53adfc6cc to 845ec125e94c (2 revisions) (flutter/flutter#174978) 2025-09-05 [email protected] [a11y-app] Fix NavigationRail leading and trailing labels (flutter/flutter#174861) 2025-09-05 [email protected] Roll Skia from d7e99be07d5d to 0ca53adfc6cc (5 revisions) (flutter/flutter#174972) 2025-09-05 [email protected] Roll Fuchsia Linux SDK from izfNA3o_2zL4Cjqmy... to xG_uERsxHvUwFHpF2... (flutter/flutter#174970) 2025-09-04 [email protected] Fix IconButton.color overrided by IconButtomTheme (flutter/flutter#174515) 2025-09-04 [email protected] [web] Reuse chrome instance to run all flutter tests (flutter/flutter#174957) 2025-09-04 [email protected] fix(Semantics): Ensure semantics properties take priority over button's (flutter/flutter#174473) 2025-09-04 [email protected] Make every LLDB Init error message actionable (flutter/flutter#174726) 2025-09-04 [email protected] Fix table cell semantics rect alignment issues. (flutter/flutter#174914) 2025-09-04 [email protected] Fix: Use route navigator for CupertinoSheetRoute pop (flutter/flutter#173103) 2025-09-04 [email protected] [ Widget Preview] Add `group` property to `Preview` (flutter/flutter#174849) 2025-09-04 [email protected] Allow OverlayPortal.overlayChildLayoutBuilder to choose root Overlay (flutter/flutter#174239) 2025-09-04 [email protected] Roll Skia from 7c2f502e3304 to d7e99be07d5d (18 revisions) (flutter/flutter#174936) 2025-09-04 [email protected] Remove 'terms of use' wording from web_unicode (flutter/flutter#174939) 2025-09-04 [email protected] [ Tool ] Remove leftover Android x86 deprecation warning constant (flutter/flutter#174941) 2025-09-04 [email protected] Prevent potential crash when accessing window in FlutterSceneDelegate (flutter/flutter#174873) 2025-09-04 [email protected] Roll Packages from 42bb347 to 98580c6 (5 revisions) (flutter/flutter#174943) 2025-09-04 [email protected] [ Device Lab ] Fix wakefulness check to only match log entries with string values (flutter/flutter#174953) 2025-09-04 [email protected] Fix expanded DropdownMenu panel is shorter than text field (flutter/flutter#174443) 2025-09-04 [email protected] Add a `viewController` property to the ios/macOS `FlutterPluginRegistrar` protocol (flutter/flutter#174168) 2025-09-03 [email protected] Roll Fuchsia Linux SDK from J3T_wZqL_57mRfWky... to izfNA3o_2zL4Cjqmy... (flutter/flutter#174908) 2025-09-03 [email protected] Wires up Android API to set section locale (flutter/flutter#173364) 2025-09-03 [email protected] Delete impeller::SPrintF. (flutter/flutter#174900) 2025-09-03 [email protected] Make sure that a DropdownMenuFormField doesn't crash in 0x0 environment (flutter/flutter#174777) 2025-09-03 [email protected] Remove unnecessary `presubmit_max_attempts` from .ci.yaml (flutter/flutter#174885) 2025-09-03 [email protected] Use local canvaskit in `dart_data_asset_test.dart` (flutter/flutter#174891) 2025-09-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark Linux web_canvaskit_tests_7_last as bringup (#174878)" (flutter/flutter#174897) 2025-09-03 [email protected] Correct intrinsics calculation for CupertinoTextField with placeholder (flutter/flutter#174889) 2025-09-03 [email protected] Considers large title height in CupertinoNavigationBar's preferred size (flutter/flutter#173722) 2025-09-03 [email protected] [A11y] Add semantics for CupertinoExpansionTile (flutter/flutter#174480) 2025-09-03 [email protected] Fix LinearProgressIndicator track painting. (flutter/flutter#173108) 2025-09-03 [email protected] update triage documentation to include team-android (flutter/flutter#174850) 2025-09-03 [email protected] Update `test_timeout_secs` to match `timeout` for `Linux web_skwasm_tests_*` and `Linux web_canvaskit_tests_*` (flutter/flutter#174881) 2025-09-03 [email protected] Roll Packages from 5d785a0 to 42bb347 (10 revisions) (flutter/flutter#174876) 2025-09-03 [email protected] Fixup formatting of gn files in the old buildroot. (flutter/flutter#174852) 2025-09-03 [email protected] Roll Dart SDK to 3.10.0-162.1.beta (flutter/flutter#174834) 2025-09-03 [email protected] Mark Linux web_canvaskit_tests_7_last as bringup (flutter/flutter#174878) 2025-09-02 [email protected] [Impeller] Fix overdraw in DrawRect geometry (flutter/flutter#174735) 2025-09-02 [email protected] Patch .clang-format files to specify C++20. (flutter/flutter#174848) 2025-09-02 [email protected] Add data assets (flutter/flutter#174685) 2025-09-02 [email protected] refactors `FlutterPlugin.kt` to use one line statement in the `into` bloc (flutter/flutter#174759) 2025-09-02 [email protected] Ensures initial semantics state is sent to engine (flutter/flutter#174845) 2025-09-02 [email protected] [Android] Break up plugin_test integration tests (flutter/flutter#174728) 2025-09-02 [email protected] Fix: Assertion failure in RawScrollbarState with dynamic controller assignment (flutter/flutter#173156) 2025-09-02 [email protected] Roll Skia from 359f3d7cc7ed to 7c2f502e3304 (1 revision) (flutter/flutter#174844) ...

…r#9962) Roll Flutter from 6b18740d5a23 to 87d5b753196c (88 revisions) flutter/flutter@6b18740...87d5b75 2025-09-05 [email protected] [ Device Lab ] Add regression testing for flutter/flutter#174952 (flutter/flutter#174956) 2025-09-05 [email protected] Roll Skia from 0ca53adfc6cc to 845ec125e94c (2 revisions) (flutter/flutter#174978) 2025-09-05 [email protected] [a11y-app] Fix NavigationRail leading and trailing labels (flutter/flutter#174861) 2025-09-05 [email protected] Roll Skia from d7e99be07d5d to 0ca53adfc6cc (5 revisions) (flutter/flutter#174972) 2025-09-05 [email protected] Roll Fuchsia Linux SDK from izfNA3o_2zL4Cjqmy... to xG_uERsxHvUwFHpF2... (flutter/flutter#174970) 2025-09-04 [email protected] Fix IconButton.color overrided by IconButtomTheme (flutter/flutter#174515) 2025-09-04 [email protected] [web] Reuse chrome instance to run all flutter tests (flutter/flutter#174957) 2025-09-04 [email protected] fix(Semantics): Ensure semantics properties take priority over button's (flutter/flutter#174473) 2025-09-04 [email protected] Make every LLDB Init error message actionable (flutter/flutter#174726) 2025-09-04 [email protected] Fix table cell semantics rect alignment issues. (flutter/flutter#174914) 2025-09-04 [email protected] Fix: Use route navigator for CupertinoSheetRoute pop (flutter/flutter#173103) 2025-09-04 [email protected] [ Widget Preview] Add `group` property to `Preview` (flutter/flutter#174849) 2025-09-04 [email protected] Allow OverlayPortal.overlayChildLayoutBuilder to choose root Overlay (flutter/flutter#174239) 2025-09-04 [email protected] Roll Skia from 7c2f502e3304 to d7e99be07d5d (18 revisions) (flutter/flutter#174936) 2025-09-04 [email protected] Remove 'terms of use' wording from web_unicode (flutter/flutter#174939) 2025-09-04 [email protected] [ Tool ] Remove leftover Android x86 deprecation warning constant (flutter/flutter#174941) 2025-09-04 [email protected] Prevent potential crash when accessing window in FlutterSceneDelegate (flutter/flutter#174873) 2025-09-04 [email protected] Roll Packages from 42bb347 to 98580c6 (5 revisions) (flutter/flutter#174943) 2025-09-04 [email protected] [ Device Lab ] Fix wakefulness check to only match log entries with string values (flutter/flutter#174953) 2025-09-04 [email protected] Fix expanded DropdownMenu panel is shorter than text field (flutter/flutter#174443) 2025-09-04 [email protected] Add a `viewController` property to the ios/macOS `FlutterPluginRegistrar` protocol (flutter/flutter#174168) 2025-09-03 [email protected] Roll Fuchsia Linux SDK from J3T_wZqL_57mRfWky... to izfNA3o_2zL4Cjqmy... (flutter/flutter#174908) 2025-09-03 [email protected] Wires up Android API to set section locale (flutter/flutter#173364) 2025-09-03 [email protected] Delete impeller::SPrintF. (flutter/flutter#174900) 2025-09-03 [email protected] Make sure that a DropdownMenuFormField doesn't crash in 0x0 environment (flutter/flutter#174777) 2025-09-03 [email protected] Remove unnecessary `presubmit_max_attempts` from .ci.yaml (flutter/flutter#174885) 2025-09-03 [email protected] Use local canvaskit in `dart_data_asset_test.dart` (flutter/flutter#174891) 2025-09-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark Linux web_canvaskit_tests_7_last as bringup (#174878)" (flutter/flutter#174897) 2025-09-03 [email protected] Correct intrinsics calculation for CupertinoTextField with placeholder (flutter/flutter#174889) 2025-09-03 [email protected] Considers large title height in CupertinoNavigationBar's preferred size (flutter/flutter#173722) 2025-09-03 [email protected] [A11y] Add semantics for CupertinoExpansionTile (flutter/flutter#174480) 2025-09-03 [email protected] Fix LinearProgressIndicator track painting. (flutter/flutter#173108) 2025-09-03 [email protected] update triage documentation to include team-android (flutter/flutter#174850) 2025-09-03 [email protected] Update `test_timeout_secs` to match `timeout` for `Linux web_skwasm_tests_*` and `Linux web_canvaskit_tests_*` (flutter/flutter#174881) 2025-09-03 [email protected] Roll Packages from 5d785a0 to 42bb347 (10 revisions) (flutter/flutter#174876) 2025-09-03 [email protected] Fixup formatting of gn files in the old buildroot. (flutter/flutter#174852) 2025-09-03 [email protected] Roll Dart SDK to 3.10.0-162.1.beta (flutter/flutter#174834) 2025-09-03 [email protected] Mark Linux web_canvaskit_tests_7_last as bringup (flutter/flutter#174878) 2025-09-02 [email protected] [Impeller] Fix overdraw in DrawRect geometry (flutter/flutter#174735) 2025-09-02 [email protected] Patch .clang-format files to specify C++20. (flutter/flutter#174848) 2025-09-02 [email protected] Add data assets (flutter/flutter#174685) 2025-09-02 [email protected] refactors `FlutterPlugin.kt` to use one line statement in the `into` bloc (flutter/flutter#174759) 2025-09-02 [email protected] Ensures initial semantics state is sent to engine (flutter/flutter#174845) 2025-09-02 [email protected] [Android] Break up plugin_test integration tests (flutter/flutter#174728) 2025-09-02 [email protected] Fix: Assertion failure in RawScrollbarState with dynamic controller assignment (flutter/flutter#173156) 2025-09-02 [email protected] Roll Skia from 359f3d7cc7ed to 7c2f502e3304 (1 revision) (flutter/flutter#174844) ...

…t Overlay (flutter/flutter#174239)

chunhtai requested a review from LongCatIsLooong August 21, 2025 20:43

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 21, 2025

chunhtai commented Aug 21, 2025

View reviewed changes

gemini-code-assist bot reviewed Aug 21, 2025

View reviewed changes

chunhtai force-pushed the issues/168785 branch from a0f57e3 to bbc5601 Compare August 21, 2025 21:33

LongCatIsLooong reviewed Aug 21, 2025

View reviewed changes

chunhtai mentioned this pull request Aug 22, 2025

Implement Overlay.of with inherited widget #174315

Merged

9 tasks

chunhtai force-pushed the issues/168785 branch from b33031c to 4864d05 Compare August 29, 2025 18:57

chunhtai requested a review from LongCatIsLooong August 29, 2025 22:16

LongCatIsLooong reviewed Aug 29, 2025

View reviewed changes

chunhtai force-pushed the issues/168785 branch from ad529aa to 807eb44 Compare September 2, 2025 17:24

chunhtai changed the title ~~Adds the ability to choose Overlay when building OverlayPortal~~ Allow OverlayPortal.overlayChildLayoutBuilder to choose root Overlay Sep 2, 2025

chunhtai requested a review from LongCatIsLooong September 2, 2025 19:21

LongCatIsLooong approved these changes Sep 2, 2025

View reviewed changes

davidhicks980 reviewed Sep 2, 2025

View reviewed changes

chunhtai added 3 commits September 3, 2025 14:22

update

87393ff

update

72bdd6b

update

46dd725

chunhtai force-pushed the issues/168785 branch from 5faf27b to 46dd725 Compare September 3, 2025 21:23

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2025

auto-submit bot added this pull request to the merge queue Sep 4, 2025

Merged via the queue into flutter:master with commit ae3eb26 Sep 4, 2025
78 of 79 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2025

engine-flutter-autoroll mentioned this pull request Sep 5, 2025

Roll Flutter from 6b18740d5a23 to dbc119c5f59e (87 revisions) flutter/packages#9961

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2025

ae3eb2623 Allow OverlayPortal.overlayChildLayoutBuilder to choose roo…

3edd1cc

…t Overlay (flutter/flutter#174239)

engine-flutter-autoroll mentioned this pull request Sep 5, 2025

Roll Flutter from 6b18740d5a23 to 87d5b753196c (88 revisions) flutter/packages#9962

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2025

ae3eb2623 Allow OverlayPortal.overlayChildLayoutBuilder to choose roo…

c54c8c0

…t Overlay (flutter/flutter#174239)

Piinks mentioned this pull request Sep 19, 2025

Flutter Notable Commits - 2025 #161460

Open

victorsanni mentioned this pull request Sep 25, 2025

Migrate usage of OverlayPortal with RenderBox.localToGlobal to OverlayPortal.overlayChildLayoutBuilder #173440

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

ae3eb2623 Allow OverlayPortal.overlayChildLayoutBuilder to choose roo…

ae5abc4

…t Overlay (flutter/flutter#174239)

	final bool hadDependencies =
	(_dependencies?.isNotEmpty ?? false) \|\| _hadUnsatisfiedDependencies;
	_lifecycleState = _ElementLifecycle.active;
	// We unregistered our dependencies in deactivate, but never cleared the list.
	// Since we're going to be reused, let's clear our list now.
	_dependencies?.clear();
	_hadUnsatisfiedDependencies = false;
	_updateInheritance();
	attachNotificationTree();
	if (_dirty) {
	owner!.scheduleBuildFor(this);
	}
	if (hadDependencies) {
	didChangeDependencies();
	}

Allow OverlayPortal.overlayChildLayoutBuilder to choose root Overlay #174239

Allow OverlayPortal.overlayChildLayoutBuilder to choose root Overlay #174239

Conversation

chunhtai commented Aug 21, 2025

Pre-launch Checklist

Uh oh!

chunhtai Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 21, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai commented Aug 26, 2025

Uh oh!

davidhicks980 commented Aug 28, 2025

Uh oh!

LongCatIsLooong commented Aug 28, 2025

Uh oh!

davidhicks980 commented Aug 29, 2025

Uh oh!

chunhtai commented Aug 29, 2025

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 21, 2025 •

edited

Loading

chunhtai Aug 22, 2025 •

edited

Loading

chunhtai Aug 21, 2025 •

edited

Loading

LongCatIsLooong Aug 21, 2025 •

edited

Loading

chunhtai Aug 22, 2025 •

edited

Loading

deminearchiver commented Aug 30, 2025 •

edited

Loading

chunhtai commented Sep 3, 2025 •

edited

Loading