Update description in _LastFinderMixin to properly describe finding last #174232

FufferKS · 2025-08-21T19:15:25Z

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

flutter-dashboard · 2025-08-21T19:15:28Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

google-cla · 2025-08-21T19:15:30Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist

Code Review

This pull request correctly fixes a typo in the description message for _LastFinderMixin. The original message incorrectly stated it was ignoring all but the 'first' element, when it should be the 'last'. My feedback includes a suggestion to add a regression test to verify this description in failure messages, improving test coverage for finder descriptions.

gemini-code-assist · 2025-08-21T19:16:23Z

packages/flutter_test/lib/src/finders.dart

  String describeMatch(Plurality plurality) {
-    return '${parent.describeMatch(plurality)} (ignoring all but first)';
+    return '${parent.describeMatch(plurality)} (ignoring all but last)';
  }


This correctly fixes the description for _LastFinderMixin. To prevent this from regressing and to ensure the description is tested, it would be great to add a test case that verifies the finder's description in a failure message.¹

For example, a test that expects a widget that doesn't exist using .last and then asserts on the TestFailure.message content. A similar test exists for find.descendant in finders_test.dart which you can use as a reference.

Style Guide References

Footnotes

Code should be tested and follow the guidance described in the writing effective tests guide and the running and writing tests guide. (link) ↩

that's an overkill mr AI

added the test

justinmc

LGTM 👍 You're right it should say "last". Thanks for fixing.

You'll have to get a test exception. I think you're probably correct that we shouldn't test this... I don't see the test that Gemini is referring to.

justinmc · 2025-09-16T22:16:00Z

@FufferKS Are you able to get a test exception? See the bot's comment above. #174232 (comment)

FufferKS · 2025-09-17T09:25:56Z

Thanks for the reminder - I was on holidays and forgot about this side quest. Logging into discord now 🫡

FufferKS · 2025-09-17T15:37:27Z

The request for an exemption was rejected, I'll add the test at some point when I find a moment to fork and play around with it...

justinmc · 2025-09-17T16:45:46Z

Sounds good, yeah I would just add a quick test that verifies the string.

FufferKS · 2025-09-18T08:42:16Z

@justinmc the tests are now added

FufferKS · 2025-09-24T10:12:24Z

@justinmc is there anything else I need to do to get this merged?

dkwingsmt

LGTM

… finding last (flutter/flutter#174232)

…10160) Manual roll requested by [email protected] flutter/flutter@c9608e2...7811e89 2025-10-01 [email protected] Migrate to `WidgetStateTextStyle` (flutter/flutter#176330) 2025-10-01 [email protected] Migrate to `WidgetStateOutlinedBorder` (flutter/flutter#176270) 2025-10-01 [email protected] [win32] Runloop should use high resolution timer and avoid deadlock (flutter/flutter#176023) 2025-10-01 [email protected] Roll Packages from 287739d to 321a584 (3 revisions) (flutter/flutter#176357) 2025-10-01 [email protected] Add SwiftUI support for UIScene migration (flutter/flutter#176230) 2025-10-01 [email protected] Roll Skia from ecaff95f51aa to c44a36470d07 (4 revisions) (flutter/flutter#176336) 2025-10-01 [email protected] [native assets] Enable build hooks and code assets on stable (flutter/flutter#176285) 2025-10-01 [email protected] [native assets] Roll dependencies (flutter/flutter#176287) 2025-10-01 [email protected] Roll Dart SDK from 527333cfe4cf to 8ffec1435cf3 (1 revision) (flutter/flutter#176334) 2025-10-01 [email protected] Roll Skia from 6998b06397c5 to ecaff95f51aa (1 revision) (flutter/flutter#176333) 2025-10-01 [email protected] Update description in _LastFinderMixin to properly describe finding last (flutter/flutter#174232) 2025-10-01 [email protected] Roll Skia from b242cc09488d to 6998b06397c5 (2 revisions) (flutter/flutter#176331) 2025-10-01 [email protected] Roll Dart SDK from af31d2637b6b to 527333cfe4cf (17 revisions) (flutter/flutter#176325) 2025-10-01 [email protected] Stop using deprecated analyzer 7.x.y APIs. (flutter/flutter#176242) 2025-10-01 [email protected] Fix docs referencing deprecated radio properties (flutter/flutter#176244) 2025-09-30 [email protected] Roll Skia from bb3b6bd4be0d to b242cc09488d (22 revisions) (flutter/flutter#176320) 2025-09-30 [email protected] Roll Fuchsia Linux SDK from rcOl0yxJb4znJ903Y... to 1Ai6VL4vb_GdGnWhg... (flutter/flutter#176315) 2025-09-30 [email protected] Adds dart ui API for setting application level locale (flutter/flutter#175100) 2025-09-30 [email protected] replace `onPop` usage with `onPopWithResult` in `navigation_bar.2.dart ` (flutter/flutter#174841) 2025-09-30 [email protected] [ Widget Preview ] Forward Widget Inspector navigation events via DTD (flutter/flutter#176218) 2025-09-30 [email protected] Add verbose logs to module_uiscene_test_ios (flutter/flutter#176306) 2025-09-30 [email protected] Web semantics: Fix email field selection/cursor by using type="text" + inputmode="email" (flutter/flutter#175876) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ast (flutter#174232)  *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Tong Mu <[email protected]>

… finding last (flutter/flutter#174232)

…ast (flutter#174232)  *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Tong Mu <[email protected]>

Update description in _LastFinderMixin to properly describe finding last

b7c61f4

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 21, 2025

gemini-code-assist bot reviewed Aug 21, 2025

View reviewed changes

Merge branch 'master' into patch-1

3e76fa7

justinmc approved these changes Aug 26, 2025

View reviewed changes

justinmc requested a review from dkwingsmt September 16, 2025 22:15

Merge branch 'master' into patch-1

393c5a5

FufferKS added 2 commits September 18, 2025 10:00

add tests for first and last logs

cffc8df

Merge branch 'master' into patch-1

92bbea6

dkwingsmt approved these changes Oct 1, 2025

View reviewed changes

Merge branch 'master' into patch-1

869a3cd

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2025

auto-submit bot added this pull request to the merge queue Oct 1, 2025

Merged via the queue into flutter:master with commit bb07841 Oct 1, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2025

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from 96fe3b3df509 to 72eec03e860a (43 revisions) flutter/packages#10156

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

bb07841a7 Update description in _LastFinderMixin to properly describe…

cd828be

… finding last (flutter/flutter#174232)

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from 96fe3b3df509 to 80496d7662ac (44 revisions) flutter/packages#10157

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

bb07841a7 Update description in _LastFinderMixin to properly describe…

cc46861

… finding last (flutter/flutter#174232)

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from 96fe3b3df509 to 7519cfd2515c (45 revisions) flutter/packages#10158

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

bb07841a7 Update description in _LastFinderMixin to properly describe…

eb589f1

… finding last (flutter/flutter#174232)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

bb07841a7 Update description in _LastFinderMixin to properly describe…

1548f35

… finding last (flutter/flutter#174232)

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from c9608e28d01a to 77a581a19e06 (20 revisions) flutter/packages#10159

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

bb07841a7 Update description in _LastFinderMixin to properly describe…

df2abc8

… finding last (flutter/flutter#174232)

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Manual roll Flutter from c9608e28d01a to 7811e8982355 (22 revisions) flutter/packages#10160

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

bb07841a7 Update description in _LastFinderMixin to properly describe…

441254c

… finding last (flutter/flutter#174232)

Update description in _LastFinderMixin to properly describe finding last #174232

Update description in _LastFinderMixin to properly describe finding last #174232

Uh oh!

Conversation

FufferKS commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 21, 2025

Uh oh!

google-cla bot commented Aug 21, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 21, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

FufferKS Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

FufferKS Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc commented Sep 16, 2025

Uh oh!

FufferKS commented Sep 17, 2025

Uh oh!

FufferKS commented Sep 17, 2025

Uh oh!

justinmc commented Sep 17, 2025

Uh oh!

FufferKS commented Sep 18, 2025

Uh oh!

FufferKS commented Sep 24, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

FufferKS commented Aug 21, 2025 •

edited

Loading

justinmc left a comment •

edited

Loading