Skip to content

Conversation

@matanlurey
Copy link
Contributor

Because this only runs every 6 commits, it being flaky takes a long time to recover.

It's not a priority to keep green and un-flaky at the moment.

@matanlurey matanlurey added autosubmit Merge PR when tree becomes green via auto submit App emergency Jump the queue; land PR in front of all others; only use for emergencies labels Aug 20, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

1 similar comment
@flutter-dashboard

This comment was marked as duplicate.

@matanlurey matanlurey added this pull request to the merge queue Aug 20, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves the Linux coverage test to bringup mode to handle its flakiness. My feedback is to add a TODO with a tracking issue for this flaky test, as per the repository's guidelines for managing test flakiness. This will help ensure the issue is not forgotten.

Merged via the queue into flutter:master with commit e757a22 Aug 21, 2025
17 of 158 checks passed
@matanlurey matanlurey deleted the re-disable-lin-coverage branch August 21, 2025 00:36
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 21, 2025
flutter/flutter@960d107...d2ac021

2025-08-21 [email protected] [web] Delete unused utils (flutter/flutter#174160)
2025-08-21 [email protected] Directly generate a Mach-O dynamic library using gen_snapshot. (flutter/flutter#171626)
2025-08-21 [email protected] Update the text input team's issue triage query (flutter/flutter#173999)
2025-08-21 [email protected] Roll Fuchsia Linux SDK from V1A1J6uXZ62Q10i9u... to Z-ZaFQ7jAqJ1OrIBf... (flutter/flutter#174170)
2025-08-21 [email protected] whitespace (flutter/flutter#174210)
2025-08-21 [email protected] Add review agent style guidelines to .gemini/styleguide.md (flutter/flutter#174000)
2025-08-20 [email protected] Move `Linux coverage` back to bringup (flutter/flutter#174171)
2025-08-20 [email protected] Engine build setup for Android RISCV64. (flutter/flutter#173672)
2025-08-20 [email protected] [ios][tools] do not print out bonjour key not found in non-verbose mode (flutter/flutter#174001)
2025-08-20 [email protected] Make sure that an Autocomplete doesn't crash in 0x0 environment (flutter/flutter#172732)
2025-08-20 [email protected] Migrate some files to use `WidgetStateProperty` (flutter/flutter#174109)
2025-08-20 [email protected] Fix `onSelect` called twice in `DropdownMenuFormField` (flutter/flutter#174053)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
Because this only runs every 6 commits, it being flaky takes a long time
to recover.

It's not a priority to keep green and un-flaky at the moment.
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
Because this only runs every 6 commits, it being flaky takes a long time
to recover.

It's not a priority to keep green and un-flaky at the moment.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
Because this only runs every 6 commits, it being flaky takes a long time
to recover.

It's not a priority to keep green and un-flaky at the moment.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
Because this only runs every 6 commits, it being flaky takes a long time
to recover.

It's not a priority to keep green and un-flaky at the moment.
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
Because this only runs every 6 commits, it being flaky takes a long time
to recover.

It's not a priority to keep green and un-flaky at the moment.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
Because this only runs every 6 commits, it being flaky takes a long time
to recover.

It's not a priority to keep green and un-flaky at the moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants