[web] Delete unused utils #174160
[web] Delete unused utils #174160
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a cleanup effort that removes a significant amount of unused utility functions from util.dart. The deletions are consistent with the removal of associated imports. The only other changes are minor documentation comment fixes, which correctly update references to public members. Overall, this is a good refactoring that improves code maintainability by removing dead code.
mdebbar
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/174160, because - The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label. |
mdebbar
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
flutter/flutter@960d107...d2ac021 2025-08-21 [email protected] [web] Delete unused utils (flutter/flutter#174160) 2025-08-21 [email protected] Directly generate a Mach-O dynamic library using gen_snapshot. (flutter/flutter#171626) 2025-08-21 [email protected] Update the text input team's issue triage query (flutter/flutter#173999) 2025-08-21 [email protected] Roll Fuchsia Linux SDK from V1A1J6uXZ62Q10i9u... to Z-ZaFQ7jAqJ1OrIBf... (flutter/flutter#174170) 2025-08-21 [email protected] whitespace (flutter/flutter#174210) 2025-08-21 [email protected] Add review agent style guidelines to .gemini/styleguide.md (flutter/flutter#174000) 2025-08-20 [email protected] Move `Linux coverage` back to bringup (flutter/flutter#174171) 2025-08-20 [email protected] Engine build setup for Android RISCV64. (flutter/flutter#173672) 2025-08-20 [email protected] [ios][tools] do not print out bonjour key not found in non-verbose mode (flutter/flutter#174001) 2025-08-20 [email protected] Make sure that an Autocomplete doesn't crash in 0x0 environment (flutter/flutter#172732) 2025-08-20 [email protected] Migrate some files to use `WidgetStateProperty` (flutter/flutter#174109) 2025-08-20 [email protected] Fix `onSelect` called twice in `DropdownMenuFormField` (flutter/flutter#174053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
No description provided.