[CP-stable][web] Fix error in ClickDebouncer when using VoiceOver #174129
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a crash in the ClickDebouncer when dealing with rapid sequences of pointer events, such as those from VoiceOver. The core change to initialize the debouncer state immediately upon receiving a pointerdown event is a solid approach to prevent null pointer exceptions. The accompanying test updates and the new test case for same-event-loop events are thorough and ensure the fix is robust. My feedback focuses on minor readability improvements by relocating large comment blocks to enhance code clarity, in line with the repository's style guide.
matanlurey
added
the
autosubmit
auto-submit
bot
merged commit d345538
into
flutter:flutter-3.35-candidate.0
2 participants
This pull request was cherry-picked manually from #174046
Issue Link:
#173741
Changelog Description:
Fix a bug that prevents screen readers from pressing buttons through keyboard shortcut.
Impact Description:
A11y for buttons (or any tappables) is broken in Flutter Web.
Workaround:
Is there a workaround for this issue?
No.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Follow repro steps in #173741