-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Marks Mac_ios ios_debug_workflow to be unflaky #174104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request marks the Mac_ios ios_debug_workflow test as unflaky by removing the bringup: true flag from its CI configuration. This change is justified by the test's successful track record over 50 consecutive runs. The modification is correct and aligns with the repository's standard practices for promoting tests. The change is approved.
flutter/flutter@26bb33b...edd434a 2025-08-23 [email protected] Roll Skia from 6f710e0b38f7 to 61169c1f6f7c (1 revision) (flutter/flutter#174325) 2025-08-23 [email protected] Roll Fuchsia Linux SDK from Z-ZaFQ7jAqJ1OrIBf... to XLSNQCsY1VkIthSjt... (flutter/flutter#174318) 2025-08-23 [email protected] Roll Skia from ebb6051e8bb1 to 6f710e0b38f7 (1 revision) (flutter/flutter#174317) 2025-08-22 [email protected] [web] Expose rasterizers in Renderer (flutter/flutter#174308) 2025-08-22 [email protected] Update some semantics flags updated to use enum (engine, framework, web) (flutter/flutter#170696) 2025-08-22 [email protected] [ Tool ] Don't emit artifact downloading messages when --machine is provided (flutter/flutter#174301) 2025-08-22 [email protected] Roll Skia from cb15e1452399 to ebb6051e8bb1 (5 revisions) (flutter/flutter#174296) 2025-08-22 [email protected] `_downloadArtifacts` (Web SDK) uses content-aware hashing in post-submit (flutter/flutter#174236) 2025-08-22 [email protected] Refactor text and runtime effect to separate skia and impeller implementations. (flutter/flutter#174219) 2025-08-22 [email protected] Roll Packages from 58c02e0 to 092d832 (4 revisions) (flutter/flutter#174295) 2025-08-22 [email protected] [ Widget Preview ] Add support for DevTools configuration (flutter/flutter#174272) 2025-08-22 [email protected] Migrate more files to `WidgetStateProperty` (flutter/flutter#174268) 2025-08-22 [email protected] [ Tool ] Ensure `--dds-port=<port>` is respected when targeting web devices (flutter/flutter#174278) 2025-08-22 [email protected] Marks Mac_ios ios_debug_workflow to be unflaky (flutter/flutter#174104) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios ios_debug_workflow"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20ios_debug_workflow%22).
This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios ios_debug_workflow"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20ios_debug_workflow%22).
This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios ios_debug_workflow"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20ios_debug_workflow%22).
This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios ios_debug_workflow"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20ios_debug_workflow%22).
This test can be marked as unflaky.
The test has been passing for 50 consecutive runs.
This test can be marked as unflaky.