[Impeller] Make sure inline passes always do a clear action. #174083

gaaclarke · 2025-08-19T23:30:33Z

The assumption they could avoid this is no longer valid.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

…could avoid this is no longer valid.

gaaclarke · 2025-08-20T18:38:26Z

dropping this out of draft to check goldens

flutter-dashboard · 2025-08-20T20:35:06Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard · 2025-08-20T22:58:28Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #174083 at sha a444447

gaaclarke · 2025-08-20T23:06:18Z

@flar @chinmaygarde can you guys give this a look. I've done a bit of debugging of this issue in #171772

This is a bummer of a change since it seems to work fine on some devices, like metal. But it clearly doesn't work for vulkan. I was hoping you might know something I don't know about how this optimization is supposed to work. I went back and it's been broken for almost a year so maybe it never did for these devices.

flar

LNTTM...

(Looks Non-Threatening To Me)

flar · 2025-08-20T23:12:37Z

engine/src/flutter/impeller/entity/inline_pass_context.cc

-    // drawing the previous pass texture, and so we don't have to clear it and
-    // can use kDontCare.
-    color0.load_action = is_msaa ? LoadAction::kDontCare : LoadAction::kLoad;
+    color0.load_action = is_msaa ? LoadAction::kClear : LoadAction::kLoad;


Perhaps add a comment that we should be able to use kDontCare here and it's not clear why that doesn't work - with an issue to follow up when we have the time?

chinmaygarde

lgtm. I don't know from context how the statement "... end up overriding the entire backdrop ..." is supposed to be guaranteed. Perhaps for specific use cases but not in general.

chinmaygarde · 2025-08-25T18:29:32Z

This looks good to go. May I land this?

flar · 2025-08-25T20:10:41Z

here to view and triage

Feel free, I think we were waiting for your feedback to be sure...

gaaclarke · 2025-08-26T15:47:54Z

Sorry, thought i left it on autosubmit before I left town.

flutter/flutter#174083)

flutter/flutter@c65f01d...da5523a 2025-08-27 [email protected] [native assets] Roll dependencies (flutter/flutter#174522) 2025-08-27 [email protected] Roll Skia from 8cf2faada2b5 to 7e6da45059c5 (5 revisions) (flutter/flutter#174523) 2025-08-27 [email protected] [Android] Restrict AOT shared library engine flag to trusted paths (flutter/flutter#173359) 2025-08-27 [email protected] Roll Fuchsia Linux SDK from L5zGzsIWIS8N36AFQ... to bHYRvLv2Dg56RWZF2... (flutter/flutter#174518) 2025-08-27 [email protected] Roll Packages from 1ef712e to 86fbeec (7 revisions) (flutter/flutter#174521) 2025-08-27 [email protected] Roll Skia from 448a0d0e57e3 to 8cf2faada2b5 (1 revision) (flutter/flutter#174510) 2025-08-27 [email protected] Roll Skia from 4703976a4dae to 448a0d0e57e3 (3 revisions) (flutter/flutter#174494) 2025-08-27 [email protected] Fix SliverMainAxisGroup and SliverCrossAxisGroup gestures' local positions. (flutter/flutter#174265) 2025-08-27 [email protected] Fix lock up when window resized with merged UI and platform threads. (flutter/flutter#172893) 2025-08-27 [email protected] Roll Skia from dc2872de506f to 4703976a4dae (1 revision) (flutter/flutter#174489) 2025-08-27 [email protected] Roll Dart SDK from db45c0ce46f9 to 89023922f96d (2 revisions) (flutter/flutter#174481) 2025-08-27 [email protected] Migrate examples and defaults to `WidgetState` (flutter/flutter#174421) 2025-08-27 [email protected] Roll Skia from 8e48b9e6d67b to dc2872de506f (7 revisions) (flutter/flutter#174479) 2025-08-27 [email protected] SnackBar with action no longer auto-dismiss (flutter/flutter#173084) 2025-08-26 [email protected] Roll Dart SDK from 9054cd8af73c to db45c0ce46f9 (1 revision) (flutter/flutter#174438) 2025-08-26 [email protected] Roll Skia from f941bfab7c09 to 8e48b9e6d67b (4 revisions) (flutter/flutter#174468) 2025-08-26 [email protected] Fix bug in test_golden_comparator, add an e2e test. (flutter/flutter#174459) 2025-08-26 [email protected] fix typo in test_profile/README.md (flutter/flutter#174384) 2025-08-26 [email protected] Remove CP labels on not-merged PRs, and explain why (flutter/flutter#174448) 2025-08-26 [email protected] Increase testing coverage and maintainability of android manifest parsing logic (flutter/flutter#174070) 2025-08-26 [email protected] [web] Add test that pictures are not rasterized when clipped out (flutter/flutter#174452) 2025-08-26 [email protected] Roll Skia from 538260c45b4a to f941bfab7c09 (3 revisions) (flutter/flutter#174450) 2025-08-26 [email protected] fixes the vulkan image layout transitions for mipmap generation (flutter/flutter#173884) 2025-08-26 [email protected] Move flakey iOS tests to bringup (flutter/flutter#174446) 2025-08-26 [email protected] [Impeller] Make sure inline passes always do a clear action. (flutter/flutter#174083) 2025-08-26 [email protected] Roll Skia from 21214d63fc40 to 538260c45b4a (2 revisions) (flutter/flutter#174441) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter#174083)

flutter/flutter#174083)

Make sure inline passes always do a load_action. The assumption they …

5448ca2

…could avoid this is no longer valid.

github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Aug 19, 2025

gaaclarke force-pushed the inline-pass-load branch from 777611c to 596c1e2 Compare August 20, 2025 18:01

gaaclarke marked this pull request as ready for review August 20, 2025 18:38

gaaclarke force-pushed the inline-pass-load branch from 596c1e2 to a0ec261 Compare August 20, 2025 18:40

adds test

bebd734

gaaclarke force-pushed the inline-pass-load branch from a0ec261 to bebd734 Compare August 20, 2025 18:41

gaaclarke marked this pull request as draft August 20, 2025 20:31

switched back to clear/load for metal tests

a444447

gaaclarke marked this pull request as ready for review August 20, 2025 20:40

gaaclarke mentioned this pull request Aug 20, 2025

UI glitches when Impeller is enabled on some Android devices. #171772

Closed

gaaclarke changed the title ~~[Impeller] Make sure inline passes always do a load action.~~ [Impeller] Make sure inline passes always do a clear action. Aug 20, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label Aug 20, 2025

gaaclarke requested review from chinmaygarde and flar August 20, 2025 23:03

flar approved these changes Aug 20, 2025

View reviewed changes

chinmaygarde approved these changes Aug 20, 2025

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2025

auto-submit bot added this pull request to the merge queue Aug 26, 2025

Merged via the queue into flutter:master with commit 84f5d26 Aug 26, 2025
187 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2025

gaaclarke mentioned this pull request Aug 26, 2025

Android: Blur widget causes UI flickering #173622

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2025

84f5d2625 [Impeller] Make sure inline passes always do a clear action. (

42ad686

flutter/flutter#174083)

engine-flutter-autoroll mentioned this pull request Aug 27, 2025

Roll Flutter from c65f01dc373c to 562ff056cb11 (21 revisions) flutter/packages#9896

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2025

84f5d2625 [Impeller] Make sure inline passes always do a clear action. (

5e13803

flutter/flutter#174083)

engine-flutter-autoroll mentioned this pull request Aug 27, 2025

Roll Flutter from c65f01dc373c to 31085d38c0c8 (22 revisions) flutter/packages#9899

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2025

84f5d2625 [Impeller] Make sure inline passes always do a clear action. (

33d9ec9

flutter/flutter#174083)

engine-flutter-autoroll mentioned this pull request Aug 27, 2025

Roll Flutter from c65f01dc373c to e1315d392b10 (23 revisions) flutter/packages#9900

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2025

84f5d2625 [Impeller] Make sure inline passes always do a clear action. (

94d5ad9

flutter/flutter#174083)

engine-flutter-autoroll mentioned this pull request Aug 27, 2025

Roll Flutter from c65f01dc373c to daadbba85611 (24 revisions) flutter/packages#9901

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2025

84f5d2625 [Impeller] Make sure inline passes always do a clear action. (

d1d1f66

flutter/flutter#174083)

engine-flutter-autoroll mentioned this pull request Aug 27, 2025

Roll Flutter from c65f01dc373c to 1a5ec4ddacac (25 revisions) flutter/packages#9902

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2025

84f5d2625 [Impeller] Make sure inline passes always do a clear action. (

b5fa94c

flutter/flutter#174083)

engine-flutter-autoroll mentioned this pull request Aug 27, 2025

Roll Flutter from c65f01dc373c to da5523afc3c1 (26 revisions) flutter/packages#9903

Merged

engine-flutter-autoroll mentioned this pull request Aug 28, 2025

Roll Flutter from c65f01dc373c to 0628f86a780d (41 revisions) flutter/packages#9918

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2025

84f5d2625 [Impeller] Make sure inline passes always do a clear action. (

3882e5c

flutter/flutter#174083)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

84f5d2625 [Impeller] Make sure inline passes always do a clear action. (

6c6ee94

flutter/flutter#174083)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Make sure inline passes always do a clear action. #174083

[Impeller] Make sure inline passes always do a clear action. #174083

Uh oh!

gaaclarke commented Aug 19, 2025

Uh oh!

gaaclarke commented Aug 20, 2025

Uh oh!

flutter-dashboard bot commented Aug 20, 2025

Uh oh!

flutter-dashboard bot commented Aug 20, 2025

Uh oh!

gaaclarke commented Aug 20, 2025

Uh oh!

flar left a comment

Uh oh!

flar Aug 20, 2025

Uh oh!

chinmaygarde left a comment

Uh oh!

chinmaygarde commented Aug 25, 2025

Uh oh!

flar commented Aug 25, 2025

Uh oh!

gaaclarke commented Aug 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Impeller] Make sure inline passes always do a clear action. #174083

[Impeller] Make sure inline passes always do a clear action. #174083

Uh oh!

Conversation

gaaclarke commented Aug 19, 2025

Pre-launch Checklist

Uh oh!

gaaclarke commented Aug 20, 2025

Uh oh!

flutter-dashboard bot commented Aug 20, 2025

Uh oh!

flutter-dashboard bot commented Aug 20, 2025

Uh oh!

gaaclarke commented Aug 20, 2025

Uh oh!

flar left a comment

Choose a reason for hiding this comment

Uh oh!

flar Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde commented Aug 25, 2025

Uh oh!

flar commented Aug 25, 2025

Uh oh!

gaaclarke commented Aug 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants