[CP-stable]Add open_jdk to Linux analyze
#174076
Conversation
Towards flutter#173986. This build _never_ declared (either directly or through `platform_properties`) that it required the Java JDK, and appears to have been "accidentally" getting it installed via a (now expired) cache of the Java JDK.
|
@matanlurey please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds OpenJDK 21 as a dependency for the Linux analyze CI job. My review focuses on ensuring the stability and reproducibility of the build environment, which is particularly important for a stable branch. I've added one comment regarding the versioning of the new dependency to improve build hermeticity.
| [ | ||
| {"dependency": "ktlint", "version": "version_1_5_0"} | ||
| {"dependency": "ktlint", "version": "version_1_5_0"}, | ||
| {"dependency": "open_jdk", "version": "version:21"} |
There was a problem hiding this comment.
The OpenJDK dependency uses the version tag version:21. This tag might resolve to different minor or patch versions of JDK 21 over time, which could lead to non-reproducible builds. On a stable branch, it's generally safer to pin dependencies to a specific version to ensure hermetic builds.
Consider using a more specific version tag (e.g., version:21.0.2) or a CIPD instance ID if available, to ensure that the same JDK version is always used.
jtmcdole
merged commit 794ba1c
into
flutter:flutter-3.35-candidate.0
|
@matanlurey asked for these to land to unbreak releases |
3 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
Stablize infrastructure.
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
N/A
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Failed pre-submit/post-submit builds that are not actionable.
Workaround:
Is there a workaround for this issue?
No
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
You can merge PRs.