Make sure that a Dialog doesn't crash in 0x0 environment #174023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a regression test to prevent a crash when a Dialog is rendered in a zero-sized environment. The added test case is clear and covers the intended scenario. I've suggested an improvement to make the test more robust by adding an assertion, in line with the repository's testing guidelines. Note that the fix for the underlying crash is not included in this pull request; I assume it is handled separately.
victorsanni
approved these changes
Aug 22, 2025
Contributor
victorsanni
left a comment
victorsanni
left a comment
There was a problem hiding this comment.
LGTM, but following up from the discussion here, I'm not sure how to proceed, wdyt @LongCatIsLooong ?
victorsanni
added
the
autosubmit
LongCatIsLooong
removed
the
autosubmit
LongCatIsLooong
requested changes
Aug 26, 2025
Contributor
LongCatIsLooong
left a comment
LongCatIsLooong
left a comment
There was a problem hiding this comment.
Could you apply the same change you did for #173928 (adding a Center between MaterialApp and SizedBox.shrink) here too?
ahmedsameha1
force-pushed
the
handle#6537-Dialog
branch
from
f971746 to
3066296
Compare
LongCatIsLooong
approved these changes
Aug 28, 2025
Contributor
LongCatIsLooong
left a comment
LongCatIsLooong
left a comment
There was a problem hiding this comment.
LGTM. Thanks for updating the PR!
dkwingsmt
added
the
autosubmit
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
flutter-dashboard
bot
removed
the
autosubmit
victorsanni
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
) This is my attempt to handle flutter#6537 for the Dialog UI control. Co-authored-by: Tong Mu <[email protected]>
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
) This is my attempt to handle flutter#6537 for the Dialog UI control. Co-authored-by: Tong Mu <[email protected]>
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
) This is my attempt to handle flutter#6537 for the Dialog UI control. Co-authored-by: Tong Mu <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
) This is my attempt to handle flutter#6537 for the Dialog UI control. Co-authored-by: Tong Mu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the Dialog UI control.