-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Update the text input team's issue triage query #173999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request correctly updates the issue triage query for the text input team to be more accurate. This is a great improvement. I've added one suggestion to further refine the query by adding sorting and filtering parameters to align it with the queries used by most other teams in the document. This should help improve the triage process's consistency and effectiveness.
| - [P0 list](https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22a%3A+text+input%22%2Cteam-text-input%2Cfyi-text-input+sort%3Aupdated-asc+label%3AP0+) | ||
| - [PR list](https://github.com/flutter/flutter/pulls?q=is%3Aopen+is%3Apr+sort%3Acreated-desc+draft%3Afalse+label%3A%22a%3A+text+input%22%2Cteam-text-input%2Cfyi-text-input+) | ||
| - [Incoming issue list](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22a%3A+text+input%22%2Cteam-text-input%2Cfyi-text-input+no%3Aassignee+-label%3A%22triaged-design%22+-label%3A%22triaged-framework%22+-label%3A%22triaged-linux%22+-label%3A%22triaged-macos%22+-label%3A%22triaged-windows%22+-label%3A%22triaged-android%22+-label%3A%22triaged-ios%22+-label%3A%22triaged-web%22+-label%3A%22triaged-ecosystem%22+-label%3A%22triaged-engine%22+-label%3A%22triaged-tool%22+-label%3A%22triaged-text-input%22+-project%3Aflutter%2F111+) | ||
| - [Incoming issue list](https://github.com/flutter/flutter/issues?q=is%3Aopen%20is%3Aissue%20label%3Ateam-text-input%2Cfyi-text-input%20no%3Aassignee%20-label%3Atriaged-text-input) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new query is a great improvement! For consistency with most other teams and to potentially improve the triage process, consider a couple of adjustments:
- Add sorting and filtering: Including
sort:updated-ascwill sort the oldest issues first, which is a common and effective triage strategy. Adding-label:"will need additional triage"will filter out issues that are meant for the separate "critical triage" meeting, as described in this document. Most other teams' "Incoming issue list" queries include these parameters. - URL encoding: The current URL contains spaces, which can be problematic. For consistency with other links in this file, it's better to use
+to encode spaces.
Here is a suggested update that incorporates these changes:
| - [Incoming issue list](https://github.com/flutter/flutter/issues?q=is%3Aopen%20is%3Aissue%20label%3Ateam-text-input%2Cfyi-text-input%20no%3Aassignee%20-label%3Atriaged-text-input) | |
| - [Incoming issue list](https://github.com/flutter/flutter/issues?q=is:issue+is:open+label:team-text-input,fyi-text-input+no:assignee+-label:triaged-text-input+-label:"will need additional triage"+sort:updated-asc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Renzo-Olivares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this and sorry for setting you up with a bad issue query! 😊
Not at all! I think looking at all untriaged issues regardless of which team the issue is assigned to would be the ideal workflow. It's unfortunate we can't have a query to do that easily! |
flutter/flutter@960d107...d2ac021 2025-08-21 [email protected] [web] Delete unused utils (flutter/flutter#174160) 2025-08-21 [email protected] Directly generate a Mach-O dynamic library using gen_snapshot. (flutter/flutter#171626) 2025-08-21 [email protected] Update the text input team's issue triage query (flutter/flutter#173999) 2025-08-21 [email protected] Roll Fuchsia Linux SDK from V1A1J6uXZ62Q10i9u... to Z-ZaFQ7jAqJ1OrIBf... (flutter/flutter#174170) 2025-08-21 [email protected] whitespace (flutter/flutter#174210) 2025-08-21 [email protected] Add review agent style guidelines to .gemini/styleguide.md (flutter/flutter#174000) 2025-08-20 [email protected] Move `Linux coverage` back to bringup (flutter/flutter#174171) 2025-08-20 [email protected] Engine build setup for Android RISCV64. (flutter/flutter#173672) 2025-08-20 [email protected] [ios][tools] do not print out bonjour key not found in non-verbose mode (flutter/flutter#174001) 2025-08-20 [email protected] Make sure that an Autocomplete doesn't crash in 0x0 environment (flutter/flutter#172732) 2025-08-20 [email protected] Migrate some files to use `WidgetStateProperty` (flutter/flutter#174109) 2025-08-20 [email protected] Fix `onSelect` called twice in `DropdownMenuFormField` (flutter/flutter#174053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to. Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet. ### Motivation The text input team missed July's triage process self-test: flutter#171486. The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (flutter#171486) or `fyi-text-input` issues that another team marked as triaged.
Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to. Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet. ### Motivation The text input team missed July's triage process self-test: flutter#171486. The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (flutter#171486) or `fyi-text-input` issues that another team marked as triaged.
Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to. Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet. ### Motivation The text input team missed July's triage process self-test: flutter#171486. The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (flutter#171486) or `fyi-text-input` issues that another team marked as triaged.
Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to. Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet. ### Motivation The text input team missed July's triage process self-test: flutter#171486. The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (flutter#171486) or `fyi-text-input` issues that another team marked as triaged.
Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to. Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet. ### Motivation The text input team missed July's triage process self-test: flutter#171486. The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (flutter#171486) or `fyi-text-input` issues that another team marked as triaged.
Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to. Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet. ### Motivation The text input team missed July's triage process self-test: flutter#171486. The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (flutter#171486) or `fyi-text-input` issues that another team marked as triaged.

Before, we looked at all untriaged text input issues, regardless of which team they’re assigned to.
Now, we look at all issues assigned to the text input team that have not been triaged by the text input team yet.
Motivation
The text input team missed July's triage process self-test: #171486.
The previous triage query was incompatible with issues that are assigned to another team. For example, an issue that is assigned to multiple teams (#171486) or
fyi-text-inputissues that another team marked as triaged.