Skip to content

Conversation

@loic-sharma
Copy link
Member

No description provided.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Aug 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds helpful documentation on how to run Google Test executables directly, including examples for filtering and repeating tests. The changes are clear and useful. I've only found a minor typo.

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Aug 18, 2025
Merged via the queue into master with commit 461ce17 Aug 18, 2025
73 checks passed
@auto-submit auto-submit bot deleted the loic-sharma-patch-1 branch August 18, 2025 20:17
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 19, 2025
flutter/flutter@2265d94...e65380a

2025-08-19 [email protected] Roll Dart SDK from 502455ee300b to 9105d946af95 (3 revisions) (flutter/flutter#174002)
2025-08-18 [email protected] Add `open_jdk` to `Linux analyze` (flutter/flutter#173988)
2025-08-18 [email protected] Add "team-ios" label to iOS team triage query (flutter/flutter#173997)
2025-08-18 [email protected] Migrate deeplink json creation to public AGP api (flutter/flutter#173794)
2025-08-18 [email protected] [ Widget Preview ] Don't crash when directory watcher restarts on Windows (flutter/flutter#173987)
2025-08-18 [email protected] [ Widget Preview ] Don't try to instantiate invalid `@Preview()` applications (flutter/flutter#173984)
2025-08-18 [email protected] Explain how to run Google Test tests directly (flutter/flutter#173978)
2025-08-18 [email protected] [flutter_tools] Use DWDS 25.0.1 (flutter/flutter#173777)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
WillBLogical pushed a commit to WillBLogical/packages that referenced this pull request Aug 20, 2025
…#9850)

flutter/flutter@2265d94...e65380a

2025-08-19 [email protected] Roll Dart SDK from 502455ee300b to 9105d946af95 (3 revisions) (flutter/flutter#174002)
2025-08-18 [email protected] Add `open_jdk` to `Linux analyze` (flutter/flutter#173988)
2025-08-18 [email protected] Add "team-ios" label to iOS team triage query (flutter/flutter#173997)
2025-08-18 [email protected] Migrate deeplink json creation to public AGP api (flutter/flutter#173794)
2025-08-18 [email protected] [ Widget Preview ] Don't crash when directory watcher restarts on Windows (flutter/flutter#173987)
2025-08-18 [email protected] [ Widget Preview ] Don't try to instantiate invalid `@Preview()` applications (flutter/flutter#173984)
2025-08-18 [email protected] Explain how to run Google Test tests directly (flutter/flutter#173978)
2025-08-18 [email protected] [flutter_tools] Use DWDS 25.0.1 (flutter/flutter#173777)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gmackall pushed a commit to gmackall/flutter that referenced this pull request Aug 21, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants