Post libtxt/post iOS 11 fidelity fine tuning #17366
Conversation
|
|
|
cc @tvolkert @jason-simmons , I tried to repro the tests on Linux. Different visible here in pink: It seems like there's a minute difference in font rendering here to cause an error from the golden. |
|
@xster it looks like we should enable the |
|
@xster I tried again after having picked up 30abc54, but it still fails on Linux. It's one of the following reasons:
I'm trying to find out which of these is the case. |
|
I've ruled out #1 and #2 from above (the pixel values are indeed different, and
|
|
Looking at the images, it doesn't appear as if shadows are even in play here, so #4 can be safely ruled out... |
|
Zoomed up on the upper right corner of one of those boxes, here's what the diff looks like:
That's a noticeable rendering difference, so although it's unclear where the bug is, it looks like this did catch a potentially real issue... |
|
I wonder if we could make the issue clearer if we used another proper font that's available on both platforms. |
|
@chinmaygarde says that the screenshotter always uses software rendering, so I'm fresh out of ideas beyond #3 (Skia isn't deterministic even when |
There was a problem hiding this comment.
Was discussing this with @Hixie. For now at least, we'll skip the golden file tests on non-Linux platforms (and require that developers update their goldens while running on Linux).
So tldr: add a skip: !Platform.isLinux to these new testWidgets() methods
There was a problem hiding this comment.
cool, thanks for following up. I'll update the goldens
* master: Add a golden image test for centered text (flutter#17517) Gallery a11y fix: give the categories and demos pages "route" scope (flutter#17516) Stop Gallery the logo to back-button cross fade shaking (flutter#17513) Correct a typo in InputDecorator, affects computeMinIntrinsicHeight() (flutter#17512) don't fail a test when there are issues deleting a temp dir (flutter#17498) Roll engine to 9ae10ef (flutter#17503) Roll engine to b856303 (flutter#17499) Rebase after package:isolate fixes. (flutter#17289) Add more unit tests for AOT snapshotting (flutter#17493) Update a TODO with issue number (flutter#17494) Fix backdrop demo margin for iPhone X (flutter#17480) Post libtxt/post iOS 11 fidelity fine tuning (flutter#17366) Add onChangeStart and onChangeEnd to slider. (flutter#17298) Use deprecated I/O constants (flutter#17491) Augment `flutter screenshot` with all supported screenshot types (flutter#17478) Roll engine to fade83c (flutter#17488) Fix handling of null body2 text style for chip and slider (flutter#17311) Roll engine to 37e20af (flutter#17481) Mark test as flaky (flutter#17486)
4 participants
Matched with screenshots of native apps