Disable shadows when taking goldens #17363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
changed the title
Contributor
Author
|
Fixes #17262 |
Contributor
|
Bots aren't happy - among the failures is "MergeableMaterial paints shadows", so it seems like some tests need updating. |
tvolkert
reviewed
May 8, 2018
Contributor
Author
There was a problem hiding this comment.
To make the difference more obvious. It was just a guess as to what would look good, I'm happy to change it to 1.0 if you like.
Contributor
There was a problem hiding this comment.
That's what I was figuring. 2.0 sgtm
tvolkert
approved these changes
May 8, 2018
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
LGTM!
(modulo existing tests that need updating)
Contributor
|
Also, see discussion in #17366 |
Hixie
force-pushed
the
shadows
branch
3 times, most recently
from
76c7485 to
0bdca4d
Compare
Contributor
|
LGTM |
tvolkert
approved these changes
May 10, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New goldens: flutter/goldens@a3923c1