Add scroll anchor for Block #1736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
There was a problem hiding this comment.
assert that at least one of the axes has the same dimension in the content and container
Contributor
There was a problem hiding this comment.
and add a comment saying that if we ever change that, ViewportAnchor needs to deal with more than "start" and "end", since there's many places you could try to anchor to (e.g. center bottom, top right, etc)
abarth
force-pushed
the
scroll_anchor3
branch
from
04b522d to
e8834fa
Compare
Contributor
|
lgtm |
This patch teaches block how to anchor its scrolling to the end rather than the start. Fixes flutter#136
abarth
force-pushed
the
scroll_anchor3
branch
from
e8834fa to
f0276d0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches block how to anchor its scrolling to the end rather than the
start.
Fixes #136