Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" #173568
Conversation
github-actions
bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reapplies a change to make WebServerDevice debuggable when using a DWDS WebSocket connection. The changes include refactoring the debuggability logic in ResidentWebRunner, introducing a WebServerDevice in the devicelab framework, and updating tests accordingly. A new integration test for the WebSocket hot reload flow is also added. The changes look good and the refactoring improves clarity. I've found one potential null pointer exception to address.
|
|
||
| /// WebServer device is debuggable when running with --start-paused. | ||
| bool get deviceIsDebuggable => device!.device is! WebServerDevice || debuggingOptions.startPaused; | ||
| late final useDwdsWebSocketConnection = device!.device is! ChromiumDevice; |
There was a problem hiding this comment.
My only concern about this change is that I hope this doesn't break the DDCLibraryBundle/Web-server/Chromium path described here: https://docs.google.com/spreadsheets/d/1M5OfuSfLOaoanp1d_D_2m419Zp3CukX8bgJ9307dT8I/edit?resourcekey=0-hywN0w4hRS0iRpByOKXLnQ&gid=0#gid=0
I'll run some local test to make sure of this
There was a problem hiding this comment.
We do still need to support running without the DdcLibraryBundle format for now. You can do it by disabling the hot reload support:
flutter run --no-web-experimental-hot-reload -d chrome
flutter drive --no-web-experimental-hot-reload -d chrome
And using the -d web-server device as well.
| // Step 3: Launch headless Chrome to connect to DWDS | ||
| debugPrint('Step 3: Launching headless Chrome to connect to DWDS...'); | ||
| chromeProcess = await _launchHeadlessChrome(debugUrl); | ||
| debugPrint('✓ Headless Chrome launched and connecting to DWDS'); |
There was a problem hiding this comment.
Should we remove this part of the test now? It seems like we don't need another chrome session involved since we removed the race condition?
There was a problem hiding this comment.
No, this is still required to actually initialize DWDS for the application. Breaking the deadlock just fixed the flutter drive case where the test driver couldn't start until the service was available, but the service couldn't become available until an initial connection had been made to the server.
There was a problem hiding this comment.
OK thanks. IIUC this test simulates flutter run -d web-server which doesn't launch a browser itself so instead the test launches a headless chrome instance to connect to it and trigger the machinery to start the application.
flutter-dashboard
bot
removed
the
autosubmit
|
A reason for requesting a revert of flutter/flutter/173568 could |
auto-submit
bot
removed
the
revert
|
Reason for revert: Chrome isn't configured for the test configuration and is causing failures. |
auto-submit
bot
removed
the
revert
|
Unable to create the revert pull request due to ProcessException: Standard error |
auto-submit
bot
removed
the
revert
…on is true … (#173551)" (flutter/flutter#173568)
…on is true … (#173551)" (flutter/flutter#173568)
|
@bkonyi Are you still trying to revert the reland? I'm looking into publishing a new version of dwds and use that in Flutter but I'm waiting until Flutter is updated with the current newest version of DWDS (this PR). If this is okay and you don't expect to revert it, I'll go ahead and work on that. |
This has relanded in #173628 😁 |
|
Hah, okay. Hopefully that should be the last of that, thank you both for dealing with all the back and forth! |
…on is true … (#173551)" (flutter/flutter#173568)
…on is true … (#173551)" (flutter/flutter#173568)
…on is true … (#173551)" (flutter/flutter#173568)
…on is true … (#173551)" (flutter/flutter#173568)
…on is true … (#173551)" (flutter/flutter#173568)
…on is true … (#173551)" (flutter/flutter#173568)
Roll Flutter from e2a347b14a18 to 34c2a3b158b2 (41 revisions) flutter/flutter@e2a347b...34c2a3b 2025-08-13 [email protected] [ Tool ] Mark Linux_pixel_7pro linux_chrome_dev_mode as bringup (flutter/flutter#173646) 2025-08-13 [email protected] [ Widget Preview ] Move `--dtd-url` from a global flag to a `widget-preview start` option (flutter/flutter#173712) 2025-08-13 [email protected] Null aware elements clean-ups (flutter/flutter#173074) 2025-08-13 [email protected] Roll Skia from 29e3e1ab7f62 to f7fdda3cd0e6 (3 revisions) (flutter/flutter#173709) 2025-08-13 [email protected] Regular windows win32 engine (flutter/flutter#173424) 2025-08-13 [email protected] Roll Dart SDK from a098cb676fd6 to 73153bdc1459 (1 revision) (flutter/flutter#173708) 2025-08-13 [email protected] Roll Fuchsia Linux SDK from vgv-rTf7i9PfcDq2Y... to I1TfNmsqTp7t3rO8e... (flutter/flutter#173690) 2025-08-13 [email protected] Roll Skia from 1170405c30cf to 29e3e1ab7f62 (2 revisions) (flutter/flutter#173689) 2025-08-13 [email protected] Roll Dart SDK from e2b7aec7333e to a098cb676fd6 (4 revisions) (flutter/flutter#173683) 2025-08-13 [email protected] Roll Skia from d06fdf03c6a1 to 1170405c30cf (4 revisions) (flutter/flutter#173681) 2025-08-13 [email protected] Roll Skia from 9ed4b4e53db2 to d06fdf03c6a1 (11 revisions) (flutter/flutter#173661) 2025-08-12 [email protected] Fix GTK redraw call being called from non-GTK thread. (flutter/flutter#173602) 2025-08-12 [email protected] [Impeller] Apply Y coordinate scaling when sampling from the destination texture in framebuffer advanced blends (flutter/flutter#173639) 2025-08-12 [email protected] Fix directional focus in nested scrollables with different axis (flutter/flutter#172875) 2025-08-12 [email protected] [ios][tools]do not log "bonjour not found" at all (unless verbose) (flutter/flutter#173569) 2025-08-12 [email protected] Remove jetifier usages (flutter/flutter#173548) 2025-08-12 [email protected] [ Tool ] Fix run_linux_chrome_dev_mode (flutter/flutter#173647) 2025-08-12 [email protected] [ios] Update iOS code signing CIPD instruction command (flutter/flutter#171173) 2025-08-12 [email protected] Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" (flutter/flutter#173628) 2025-08-12 [email protected] Roll Clang to 8c7a2ce01a77c96028fe2c8566f65c45ad9408d3 (flutter/flutter#173429) 2025-08-12 [email protected] [web] Fallback to CanvasKit when WebGL is not available (flutter/flutter#173629) 2025-08-12 [email protected] Roll Packages from a114ac2 to 08a9b2c (3 revisions) (flutter/flutter#173625) 2025-08-12 [email protected] [ Tool ] Fix crash from possible DDS startup race (flutter/flutter#173362) 2025-08-12 [email protected] Roll Skia from a2936eff2179 to 9ed4b4e53db2 (3 revisions) (flutter/flutter#173611) 2025-08-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4 to 5 in the all-github-actions group (flutter/flutter#173606) 2025-08-12 [email protected] Roll Dart SDK from c5fe48aee60d to e2b7aec7333e (1 revision) (flutter/flutter#173604) 2025-08-12 [email protected] Roll Skia from 44bb9d908ee4 to a2936eff2179 (21 revisions) (flutter/flutter#173603) 2025-08-12 [email protected] Fix the issue of over-scrolling in SliverMainAxisGroup with a PinnedHeaderSliver. (flutter/flutter#173349) 2025-08-12 [email protected] Roll Dart SDK from b2a23936f968 to c5fe48aee60d (2 revisions) (flutter/flutter#173596) 2025-08-11 [email protected] Update CanRenderTiledTexture unit tests (flutter/flutter#173553) 2025-08-11 [email protected] Update integration test for iOS deployment workflows (flutter/flutter#173566) 2025-08-11 [email protected] Enables vulkan for PowerVR B-Series (flutter/flutter#173561) 2025-08-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" (#173568)" (flutter/flutter#173587) 2025-08-11 [email protected] Roll Dart SDK from 8e882349fcab to b2a23936f968 (2 revisions) (flutter/flutter#173571) 2025-08-11 [email protected] Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" (flutter/flutter#173568) 2025-08-11 [email protected] Update CI iOS tests (flutter/flutter#173563) 2025-08-11 [email protected] Roll Packages from 34948d1 to a114ac2 (4 revisions) (flutter/flutter#173556) 2025-08-11 [email protected] Roll Fuchsia Linux SDK from HclTm0V8hgSpfqmtG... to vgv-rTf7i9PfcDq2Y... (flutter/flutter#173505) 2025-08-11 [email protected] Roll Dart SDK from 6a7ae1ffd1c9 to 8e882349fcab (2 revisions) (flutter/flutter#173499) 2025-08-11 [email protected] Update `ExpansibleController` in `ExpansionTile` `didUpdateWidget` (flutter/flutter#173175) 2025-08-11 [email protected] add format cmd to tools instruction (flutter/flutter#173428) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human ...
… … (flutter#173551)" (flutter#173568) This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.
…n is true … (flutter#173551)" (flutter#173568)" (flutter#173587) <!-- start_original_pr_link --> Reverts: flutter#173568 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: bkonyi <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Chrome isn't configured for the test configuration and is causing failures. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: bkonyi <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jyameo, matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
… … (flutter#173551)" (flutter#173568) This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.
…n is true … (flutter#173551)" (flutter#173568)" (flutter#173587) <!-- start_original_pr_link --> Reverts: flutter#173568 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: bkonyi <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Chrome isn't configured for the test configuration and is causing failures. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: bkonyi <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jyameo, matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
… … (flutter#173551)" (flutter#173568) This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.
…n is true … (flutter#173551)" (flutter#173568)" (flutter#173587) <!-- start_original_pr_link --> Reverts: flutter#173568 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: bkonyi <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Chrome isn't configured for the test configuration and is causing failures. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: bkonyi <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jyameo, matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
…on is true … (#173551)" (flutter/flutter#173568)
… … (flutter#173551)" (flutter#173568) This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.
…n is true … (flutter#173551)" (flutter#173568)" (flutter#173587) <!-- start_original_pr_link --> Reverts: flutter#173568 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: bkonyi <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Chrome isn't configured for the test configuration and is causing failures. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: bkonyi <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jyameo, matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
5 participants
This reverts commit e2a347b.
Previously reverted due to
*_chrome_dev_modetests failing on all platforms.