Marks Windows plugin_test to be unflaky #173339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
c: flake
github-actions
bot
removed
the
c: tech-debt
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly marks the Windows plugin_test as stable by removing the bringup: true flag from the .ci.yaml configuration file. This change is well-supported by the information in the pull request description, which notes that the associated flakiness issue has been resolved and the test has been passing consistently. The change is straightforward and correct. As a potential follow-up, since this test is now considered stable, it might be worth investigating whether the TODO and the hardcoded 10-second delay related to Windows flakiness in the _FlutterProject.delete() method within dev/devicelab/lib/tasks/plugin_tests.dart are still necessary.
stuartmorgan-g
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 6, 2025
flutter/flutter@59fc766...9de63a0 2025-08-06 [email protected] Roll Packages from 83ae18a to f0b2726 (4 revisions) (flutter/flutter#173350) 2025-08-06 [email protected] Marks Windows plugin_test to be unflaky (flutter/flutter#173339) 2025-08-06 [email protected] Roll Fuchsia Linux SDK from XEsjoUSNHijML1i9h... to 2Mo76-tiDj4ZCZbPv... (flutter/flutter#173329) 2025-08-05 [email protected] Add radius clamping to web `RSuperellipse` (flutter/flutter#172254) 2025-08-05 [email protected] licenses_cpp: moved is_minimal_linux to pkgconfig usage (flutter/flutter#173248) 2025-08-05 [email protected] Roll Dart SDK from 1553753fee86 to 5b44a0f0b380 (3 revisions) (flutter/flutter#173306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows plugin_test"
}
-->
The issue flutter#148834 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test%22).
This test can be marked as unflaky.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows plugin_test"
}
-->
The issue flutter#148834 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test%22).
This test can be marked as unflaky.
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows plugin_test"
}
-->
The issue flutter#148834 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test%22).
This test can be marked as unflaky.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows plugin_test"
}
-->
The issue flutter#148834 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test%22).
This test can be marked as unflaky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue #148834 has been closed, and the test has been passing for 50 consecutive runs.
This test can be marked as unflaky.