fix: content_aware_hash tag for fuchsia merge / upload #173253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the CIPD package upload process to fix a race condition when tagging with content_aware_hash. The change separates the package creation and tagging steps. I've identified a critical issue where an incorrect package name is being used for the new tagging logic, which will likely cause failures. I've also suggested adding a docstring to the new helper function to adhere to the project's style guide. The Flutter style guide specifies that Python code should follow the Google Python Style Guide. The Google guide requires docstrings for public modules, functions, classes, and methods.
engine/src/flutter/tools/fuchsia/merge_and_upload_debug_symbols.py
Outdated
Show resolved
Hide resolved
engine/src/flutter/tools/fuchsia/merge_and_upload_debug_symbols.py
Outdated
Show resolved
Hide resolved
matanlurey
approved these changes
Aug 5, 2025
Member
Author
|
jason-simmons
approved these changes
Aug 5, 2025
chingjun
approved these changes
Aug 5, 2025
jtmcdole
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
danilozhang
pushed a commit
to danilozhang/flutter
that referenced
this pull request
Aug 6, 2025
Also tag after the upload, similar to flutter#173140 fixes: flutter#173137
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
Also tag after the upload, similar to flutter#173140 fixes: flutter#173137
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
Also tag after the upload, similar to flutter#173140 fixes: flutter#173137
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
Also tag after the upload, similar to flutter#173140 fixes: flutter#173137
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
Also tag after the upload, similar to flutter#173140 fixes: flutter#173137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tag after the upload, similar to #173140
fixes: #173137