[dync_modules] enable iOS ddm build in the merge queue #173094
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the Mac mac_ios_engine_ddm build in the merge queue, making it a required check for changes on the master branch. This is achieved by removing the bringup: true property, which is the standard procedure for promoting a CI build from an experimental to a required status. The change also adds release_build: "true" and removes backfill: false, which appear to be appropriate adjustments for this build's new role. The changes look correct and align with the goal of having these builds always available.
sigmundch
left a comment
sigmundch
left a comment
There was a problem hiding this comment.
(oops didn't click approve)
|
@jtmcdole friendly ping |
|
This will require 5 machines for every commit in the commit queue (until we turn off builds for non-engine changes). While it takes 17 minutes now in the bring-up true, that is only because its using We can enable this now, but if the queue times go up we might want to consider non-bringup true, release false, and backfill. |
|
Example showing increased time in the queue (29 minutes) - though we didn't have to wait for resources. |
Similar to flutter#168233, but this time for iOS Follow-up to flutter#168717 As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.
Similar to flutter#168233, but this time for iOS Follow-up to flutter#168717 As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.
Similar to flutter#168233, but this time for iOS Follow-up to flutter#168717 As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.
Similar to flutter#168233, but this time for iOS Follow-up to flutter#168717 As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.
Similar to flutter#168233, but this time for iOS Follow-up to flutter#168717 As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.
3 participants
Similar to #168233, but this time for iOS
Follow-up to #168717
As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.