Add onChangeStart and onChangeEnd to slider. #17298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
force-pushed
the
slider_callback
branch
from
e332efb to
78f470c
Compare
srawlins
added a commit
to srawlins/flutter
that referenced
this pull request
May 11, 2018
* master: Add a golden image test for centered text (flutter#17517) Gallery a11y fix: give the categories and demos pages "route" scope (flutter#17516) Stop Gallery the logo to back-button cross fade shaking (flutter#17513) Correct a typo in InputDecorator, affects computeMinIntrinsicHeight() (flutter#17512) don't fail a test when there are issues deleting a temp dir (flutter#17498) Roll engine to 9ae10ef (flutter#17503) Roll engine to b856303 (flutter#17499) Rebase after package:isolate fixes. (flutter#17289) Add more unit tests for AOT snapshotting (flutter#17493) Update a TODO with issue number (flutter#17494) Fix backdrop demo margin for iPhone X (flutter#17480) Post libtxt/post iOS 11 fidelity fine tuning (flutter#17366) Add onChangeStart and onChangeEnd to slider. (flutter#17298) Use deprecated I/O constants (flutter#17491) Augment `flutter screenshot` with all supported screenshot types (flutter#17478) Roll engine to fade83c (flutter#17488) Fix handling of null body2 text style for chip and slider (flutter#17311) Roll engine to 37e20af (flutter#17481) Mark test as flaky (flutter#17486)
ghost
mentioned this pull request
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This fixes flutter#17169 by adding onChangeStart and onChangeEnd to the slider. These will be called when the user starts a change, and when they end a change, regardless of whether that change is a tap or a drag. These differ from onChanged, in that they only report when the user starts and ends an interaction, not at every slight change.
|
I am having an issue, I am trying to get the end value of a slider, but for some reason, the onChangeEnd is hired 2 times, when user moves the slider |
zoechi
added
framework
|
Same problem as @bahrinb55 here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #17169 by adding onChangeStart and onChangeEnd to the slider. These will be called when the user starts a change, and when they end a change, regardless of whether that change is a tap or a drag.
These differ from onChanged, in that they only report when the user starts and ends an interaction, not at every slight change.