Skip to content

Conversation

@scheglov
Copy link
Contributor

@scheglov scheglov commented May 4, 2018

This will bring @isTest and @isTestGroup annotations that we can then use to annotate testWidgets() so that it is displayed in IDE outline (flutter/flutter-intellij#2055).

@scheglov scheglov requested review from Hixie and tvolkert May 4, 2018 17:00
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@scheglov
Copy link
Contributor Author

scheglov commented May 4, 2018

Sigh, there are problems with package:isolate version, package:analyzer with the current version 0.31.1 wants isolate 0.31.1, and flutter update-packages --force-upgrade pulls in 2.0.0. Only two packages - examples/stocks and dev/benchmarks/microbenchmarks get updated to pull isolate 2.0.0, so in theory we could revert isolate version changes for them. But IIUC we don't do this in Flutter, and fixing transitive dependencies is the way to do things. So, for now I will postpone this PR and will will try to fix analyzer dependencies first.

@devoncarew
Copy link
Contributor

@scheglov, the isolate deps should have been addressed by #17479

@scheglov scheglov merged commit 9b65fc6 into flutter:master May 11, 2018
@scheglov scheglov deleted the update-meta-1.1.5 branch May 11, 2018 01:52
srawlins added a commit to srawlins/flutter that referenced this pull request May 11, 2018
* master:
  Add a golden image test for centered text (flutter#17517)
  Gallery a11y fix: give the categories and demos pages "route" scope (flutter#17516)
  Stop Gallery the logo to back-button cross fade shaking (flutter#17513)
  Correct a typo in InputDecorator, affects computeMinIntrinsicHeight() (flutter#17512)
  don't fail a test when there are issues deleting a temp dir (flutter#17498)
  Roll engine to 9ae10ef (flutter#17503)
  Roll engine to b856303 (flutter#17499)
  Rebase after package:isolate fixes. (flutter#17289)
  Add more unit tests for AOT snapshotting (flutter#17493)
  Update a TODO with issue number (flutter#17494)
  Fix backdrop demo margin for iPhone X (flutter#17480)
  Post libtxt/post iOS 11 fidelity fine tuning (flutter#17366)
  Add onChangeStart and onChangeEnd to slider. (flutter#17298)
  Use deprecated I/O constants (flutter#17491)
  Augment `flutter screenshot` with all supported screenshot types (flutter#17478)
  Roll engine to fade83c (flutter#17488)
  Fix handling of null body2 text style for chip and slider (flutter#17311)
  Roll engine to 37e20af (flutter#17481)
  Mark test as flaky (flutter#17486)
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants