Allow empty initial time when using text input mode in showTimePicker dialog #172847

azatech · 2025-07-28T11:35:21Z

Added ability to allow empty initial time when using text input mode in showTimePicker dialog #169131

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

… dialog

azatech · 2025-07-28T11:39:41Z

@dkwingsmt @MitchellGoodwin

Created a new PR to address issues found in the previously reviewed one. Old PR link: #170694

MitchellGoodwin · 2025-07-29T16:59:59Z

Linux analyze is complaining about formatting. Copying from the logs in the check:

Found 1 Dart file which was formatted incorrectly.
To fix, run `dart format packages/flutter/test/material/time_picker_test.dart` or:

git apply <<DONE
diff --git a/packages/flutter/test/material/time_picker_test.dart b/packages/flutter/test/material/time_picker_test.dart
index 59f9f506c56..00000000000 100644
--- a/packages/flutter/test/material/time_picker_test.dart
+++ b/packages/flutter/test/material/time_picker_test.dart
@@ -2273,28 +2273,28 @@ void main() {
     });
 
     group('Time picker - emptyInitialInput (${materialType.name})', () {
-      testWidgets(
-        'Fields are empty and show correct hints when emptyInitialInput is true',
-        (WidgetTester tester) async {
-          await startPicker(
-            tester,
-            (_) {},
-            entryMode: TimePickerEntryMode.input,
-            materialType: materialType,
-            emptyInitialInput: true,
-          );
-          await tester.pump();
+      testWidgets('Fields are empty and show correct hints when emptyInitialInput is true', (
+        WidgetTester tester,
+      ) async {
+        await startPicker(
+          tester,
+          (_) {},
+          entryMode: TimePickerEntryMode.input,
+          materialType: materialType,
+          emptyInitialInput: true,
+        );
+        await tester.pump();
 
-          final List<TextField> textFields =
-              tester.widgetList<TextField>(find.byType(TextField)).toList();
+        final List<TextField> textFields = tester
+            .widgetList<TextField>(find.byType(TextField))
+            .toList();
 
-          expect(textFields[0].controller?.text, isEmpty); // hour
-          expect(textFields[1].controller?.text, isEmpty); // minute
-          expect(textFields[0].decoration?.hintText, isNull);
-          expect(textFields[1].decoration?.hintText, isNull);
-          await finishPicker(tester);
-        },
-      );
+        expect(textFields[0].controller?.text, isEmpty); // hour
+        expect(textFields[1].controller?.text, isEmpty); // minute
+        expect(textFields[0].decoration?.hintText, isNull);
+        expect(textFields[1].decoration?.hintText, isNull);
+        await finishPicker(tester);
+      });
 
       testWidgets('User sets hour/minute after initially empty fields', (
         WidgetTester tester,
@@ -2310,8 +2310,9 @@ void main() {
           emptyInitialInput: true,
         );
 
-        final List<TextField> textFields =
-            tester.widgetList<TextField>(find.byType(TextField)).toList();
+        final List<TextField> textFields = tester
+            .widgetList<TextField>(find.byType(TextField))
+            .toList();
 
         expect(textFields[0].controller?.text, isEmpty); // hour
         expect(textFields[1].controller?.text, isEmpty); // minute
@@ -2338,8 +2339,9 @@ void main() {
           materialType: materialType,
         );
 
-        final List<TextField> textFields =
-            tester.widgetList<TextField>(find.byType(TextField)).toList();
+        final List<TextField> textFields = tester
+            .widgetList<TextField>(find.byType(TextField))
+            .toList();
 
         expect(textFields[0].controller?.text, '7'); // hour
         expect(textFields[1].controller?.text, '00'); // minute
@@ -2797,3 +2799,4 @@ Future<void> finishPicker(WidgetTester tester) async {
   await tester.tap(find.text(materialLocalizations.okButtonLabel));
   await tester.pumpAndSettle(const Duration(seconds: 1));
 }
DONE

dkwingsmt · 2025-07-29T20:18:14Z

(You should be able to automatically apply them by running dart format packages/flutter/test/material/time_picker_test.dart, although make sure you have the latest packages with flutter update-packages.)

dkwingsmt

LGTM

MitchellGoodwin

LGTM as well!

…TimePicker dialog (flutter/flutter#172847)

flutter/flutter@34c2a3b...f4334d2 2025-08-14 [email protected] Roll Dart SDK from 9b4691f35139 to 214a7f829913 (2 revisions) (flutter/flutter#173769) 2025-08-14 [email protected] Roll Skia from b3e86773dae1 to dca5f05fee87 (4 revisions) (flutter/flutter#173763) 2025-08-14 [email protected] Roll Dart SDK from 73153bdc1459 to 9b4691f35139 (3 revisions) (flutter/flutter#173755) 2025-08-14 [email protected] Roll Skia from 5852eddfd404 to b3e86773dae1 (1 revision) (flutter/flutter#173750) 2025-08-14 [email protected] Allow empty initial time when using text input mode in showTimePicker dialog (flutter/flutter#172847) 2025-08-13 [email protected] Roll Skia from 525e2bf80559 to 5852eddfd404 (2 revisions) (flutter/flutter#173740) 2025-08-13 [email protected] [web] Popping a nameless route should preserve the correct route name (flutter/flutter#173652) 2025-08-13 [email protected] Make sure that a ChoiceChip doesn't crash in 0x0 environment (flutter/flutter#173322) 2025-08-13 [email protected] [ Tool ] Fix missing import for widget_preview.dart (flutter/flutter#173731) 2025-08-13 [email protected] Roll Skia from f7fdda3cd0e6 to 525e2bf80559 (7 revisions) (flutter/flutter#173727) 2025-08-13 [email protected] Do not include `:unittests` unless `enable_unittests` (flutter/flutter#173729) 2025-08-13 [email protected] Roll Packages from 08a9b2c to 6cb9113 (1 revision) (flutter/flutter#173726) 2025-08-13 [email protected] fix: selected date decorator renders outside PageView in `DatePickerDialog` dialog (flutter/flutter#171718) 2025-08-13 [email protected] [ Widget Preview ] Add `--machine` mode (flutter/flutter#173654) 2025-08-13 [email protected] Make sure that a Chip doesn't crash in 0x0 environment (flutter/flutter#173245) 2025-08-13 [email protected] feat: Cupertino sheet implement upward stretch on full sheet (flutter/flutter#168547) 2025-08-13 [email protected] Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder (flutter/flutter#167032) 2025-08-13 [email protected] Fix `ChipThemeData` lerp for `BorderSide` (flutter/flutter#173160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… dialog (flutter#172847) Added ability to allow empty initial time when using text input mode in showTimePicker dialog flutter#169131 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Tong Mu <[email protected]>

…r#9807) flutter/flutter@34c2a3b...f4334d2 2025-08-14 [email protected] Roll Dart SDK from 9b4691f35139 to 214a7f829913 (2 revisions) (flutter/flutter#173769) 2025-08-14 [email protected] Roll Skia from b3e86773dae1 to dca5f05fee87 (4 revisions) (flutter/flutter#173763) 2025-08-14 [email protected] Roll Dart SDK from 73153bdc1459 to 9b4691f35139 (3 revisions) (flutter/flutter#173755) 2025-08-14 [email protected] Roll Skia from 5852eddfd404 to b3e86773dae1 (1 revision) (flutter/flutter#173750) 2025-08-14 [email protected] Allow empty initial time when using text input mode in showTimePicker dialog (flutter/flutter#172847) 2025-08-13 [email protected] Roll Skia from 525e2bf80559 to 5852eddfd404 (2 revisions) (flutter/flutter#173740) 2025-08-13 [email protected] [web] Popping a nameless route should preserve the correct route name (flutter/flutter#173652) 2025-08-13 [email protected] Make sure that a ChoiceChip doesn't crash in 0x0 environment (flutter/flutter#173322) 2025-08-13 [email protected] [ Tool ] Fix missing import for widget_preview.dart (flutter/flutter#173731) 2025-08-13 [email protected] Roll Skia from f7fdda3cd0e6 to 525e2bf80559 (7 revisions) (flutter/flutter#173727) 2025-08-13 [email protected] Do not include `:unittests` unless `enable_unittests` (flutter/flutter#173729) 2025-08-13 [email protected] Roll Packages from 08a9b2c to 6cb9113 (1 revision) (flutter/flutter#173726) 2025-08-13 [email protected] fix: selected date decorator renders outside PageView in `DatePickerDialog` dialog (flutter/flutter#171718) 2025-08-13 [email protected] [ Widget Preview ] Add `--machine` mode (flutter/flutter#173654) 2025-08-13 [email protected] Make sure that a Chip doesn't crash in 0x0 environment (flutter/flutter#173245) 2025-08-13 [email protected] feat: Cupertino sheet implement upward stretch on full sheet (flutter/flutter#168547) 2025-08-13 [email protected] Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder (flutter/flutter#167032) 2025-08-13 [email protected] Fix `ChipThemeData` lerp for `BorderSide` (flutter/flutter#173160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… dialog (flutter#172847) Added ability to allow empty initial time when using text input mode in showTimePicker dialog flutter#169131 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Tong Mu <[email protected]>

…TimePicker dialog (flutter/flutter#172847)

… dialog (flutter#172847) Added ability to allow empty initial time when using text input mode in showTimePicker dialog flutter#169131 - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Tong Mu <[email protected]>

azatech and others added 4 commits July 28, 2025 14:22

Allow empty initial time when using text input mode in showTimePicker…

053c01c

… dialog

Allow empty initial time when using text input mode in showTimePicker…

5aad0bd

… dialog

Code, comments and tests enhancements

a8ce770

Update packages/flutter/lib/src/material/time_picker.dart

3c05dbd

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 28, 2025

azatech changed the title ~~Allow empty initial time when using text input mode in showTimePicker dialog #170694~~ Allow empty initial time when using text input mode in showTimePicker dialog Jul 28, 2025

dkwingsmt requested review from MitchellGoodwin and dkwingsmt July 29, 2025 20:16

dkwingsmt added 2 commits August 13, 2025 15:40

Format

163cdc0

Merge branch 'master' into 169131

bdd696b

dkwingsmt approved these changes Aug 13, 2025

View reviewed changes

MitchellGoodwin approved these changes Aug 13, 2025

View reviewed changes

MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2025

auto-submit bot added this pull request to the merge queue Aug 14, 2025

Merged via the queue into flutter:master with commit e1eb1a6 Aug 14, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2025

engine-flutter-autoroll mentioned this pull request Aug 14, 2025

Roll Flutter from 34c2a3b158b2 to c932faf75472 (17 revisions) flutter/packages#9806

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

e1eb1a67d Allow empty initial time when using text input mode in show…

1531ea8

…TimePicker dialog (flutter/flutter#172847)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

e1eb1a67d Allow empty initial time when using text input mode in show…

e47e150

…TimePicker dialog (flutter/flutter#172847)

engine-flutter-autoroll mentioned this pull request Aug 14, 2025

Roll Flutter from 34c2a3b158b2 to f4334d27934b (18 revisions) flutter/packages#9807

Merged

Piinks mentioned this pull request Aug 15, 2025

Flutter Notable Commits - 2025 #161460

Open

bleroux mentioned this pull request Nov 4, 2025

TimePicker: Typing a new value in hour/minute field does not auto-clear the previous input #177973

Closed

tirth-patel-nc mentioned this pull request Nov 5, 2025

Allow empty or overwritable initial time when using text input mode in showTimePicker #169131

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

e1eb1a67d Allow empty initial time when using text input mode in show…

ad932d7

…TimePicker dialog (flutter/flutter#172847)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow empty initial time when using text input mode in showTimePicker dialog #172847

Allow empty initial time when using text input mode in showTimePicker dialog #172847

Uh oh!

azatech commented Jul 28, 2025 •

edited

Loading

Uh oh!

azatech commented Jul 28, 2025

Uh oh!

MitchellGoodwin commented Jul 29, 2025

Uh oh!

dkwingsmt commented Jul 29, 2025 •

edited

Loading

Uh oh!

dkwingsmt left a comment

Uh oh!

MitchellGoodwin left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Allow empty initial time when using text input mode in showTimePicker dialog #172847

Allow empty initial time when using text input mode in showTimePicker dialog #172847

Uh oh!

Conversation

azatech commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azatech commented Jul 28, 2025

Uh oh!

MitchellGoodwin commented Jul 29, 2025

Uh oh!

dkwingsmt commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

azatech commented Jul 28, 2025 •

edited

Loading

dkwingsmt commented Jul 29, 2025 •

edited

Loading