Remove 'v' Open DevTools from help on web in profile/release mode #172829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
Contributor
Author
|
@nt4f04uNd hi, can i have a review, please |
nt4f04uNd
reviewed
Aug 3, 2025
Member
nt4f04uNd
left a comment
nt4f04uNd
left a comment
There was a problem hiding this comment.
Hi @danwirele, welcome here with your first contribution!
It mostly looks good, just small comments about docs here and there.
I am not terribly familiar with the flutter_tools, so I will also seek for one more reviewer to confirm all is good.
It's great that you added multiple tests for this!
nt4f04uNd
reviewed
Aug 4, 2025
Co-authored-by: Daniil Lipatkin <[email protected]>
Co-authored-by: Daniil Lipatkin <[email protected]>
nt4f04uNd
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
This comment has been minimized.
This comment has been minimized.
nt4f04uNd
approved these changes
Aug 20, 2025
Member
|
LGTM! |
nt4f04uNd
added
the
autosubmit
This comment has been minimized.
This comment has been minimized.
auto-submit
bot
removed
the
autosubmit
Member
|
Swapping for @bkonyi |
bkonyi
approved these changes
Sep 15, 2025
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/172829, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
bkonyi
added
platform-web
Contributor
|
autosubmit label was removed for flutter/flutter/172829, because - The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 15, 2025
…72829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes #143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <[email protected]> Co-authored-by: Ben Konyi <[email protected]>
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 16, 2025
flutter/flutter@29a238d...8d0b31d 2025-09-16 [email protected] Roll Packages from fcd5f68 to 0255ac9 (2 revisions) (flutter/flutter#175427) 2025-09-16 [email protected] Adds a11y section locale support for iOS (flutter/flutter#175005) 2025-09-16 [email protected] Roll Skia from 4e9c86d4a6d9 to 7d160bbf9403 (3 revisions) (flutter/flutter#175404) 2025-09-16 [email protected] [native_assets] Find more `CCompilerConfig` on Linux (flutter/flutter#175323) 2025-09-16 [email protected] Roll Dart SDK from 50e61e5bff51 to 700de52f29a9 (3 revisions) (flutter/flutter#175395) 2025-09-16 [email protected] Fix default overlay color in `TabBar` (flutter/flutter#175270) 2025-09-16 [email protected] Migrate to widget state (flutter/flutter#175242) 2025-09-16 [email protected] Roll Skia from 01b0ede33ae9 to 4e9c86d4a6d9 (1 revision) (flutter/flutter#175387) 2025-09-15 [email protected] Merge the engine README into the README of the old buildroot. (flutter/flutter#175384) 2025-09-15 [email protected] Marks Mac_ios microbenchmarks_ios to be unflaky (flutter/flutter#171146) 2025-09-15 [email protected] Deprecate Objective-C plugin template (flutter/flutter#174003) 2025-09-15 [email protected] Add a gn --ccache argument (flutter/flutter#174621) 2025-09-15 [email protected] Update `build.gradle` to remove deprecation warning in `flutter\engine\src\flutter\shell\platform\android` (flutter/flutter#175305) 2025-09-15 [email protected] Show cursor after swipe only if TextField has focus (flutter/flutter#175044) 2025-09-15 [email protected] Roll Skia from f950263bb3d4 to 01b0ede33ae9 (7 revisions) (flutter/flutter#175373) 2025-09-15 [email protected] Update Chromium sysroot to pick up RISC-V support. (flutter/flutter#173671) 2025-09-15 [email protected] Set Gemini Code Assist `include_drafts` to false (flutter/flutter#175098) 2025-09-15 [email protected] Roll Packages from 15e7e89 to fcd5f68 (3 revisions) (flutter/flutter#175366) 2025-09-15 [email protected] Remove 'v' Open DevTools from help on web in profile/release mode (flutter/flutter#172829) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dixita0607
pushed a commit
to dixita0607/flutter
that referenced
this pull request
Sep 17, 2025
…utter#172829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes flutter#143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <[email protected]> Co-authored-by: Ben Konyi <[email protected]>
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…utter#172829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes flutter#143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <[email protected]> Co-authored-by: Ben Konyi <[email protected]>
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
…utter#172829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes flutter#143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <[email protected]> Co-authored-by: Ben Konyi <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…utter#172829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes flutter#143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <[email protected]> Co-authored-by: Ben Konyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
vfrom the help menu on web in profile/release modevavailable in debug and on native platformsvnow appears beforesin help_commonTerminalInputHandlerto blockvon web in release modeTesting:
printHelpDetails hides v on web in profile modevbefores)fixes #143451
Pre-launch Checklist
///).