Skip to content

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Jul 25, 2025

Towards #171900.

I'll make a breaking change announcement before landing this PR.

We can keep the flag for a stable release (allow folks to write flutter config --no-enable-omit-legacy-version-file if they still need the file), or we can decide it's not worth it and just rely on the breaking change announcement.

@matanlurey matanlurey requested a review from bkonyi July 25, 2025 21:17
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 25, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 28, 2025
…ersion`) (#172798)

Towards #171900.

Discovered during #172793.

It's unfortunate that `DefaultPub` (and tests) need some massaging to
work, but the fact the tool is so inconsistent about global versus local
state is not a new thing, so I didn't worry about it in the context of
this PR.
@matanlurey matanlurey marked this pull request as ready for review August 14, 2025 22:28
@matanlurey
Copy link
Contributor Author

As of flutter/website#12310, I am ready to merge this!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 14, 2025

autosubmit label was removed for flutter/flutter/172793, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Aug 15, 2025
Merged via the queue into flutter:master with commit 2d2070c Aug 15, 2025
144 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 15, 2025
flutter/flutter@f4334d2...52af7a5

2025-08-15 [email protected] Roll Packages from 09533b7 to 5c52c55 (6 revisions) (flutter/flutter#173854)
2025-08-15 [email protected] Roll Skia from 46ec77ae3954 to 5654ac32ede0 (1 revision) (flutter/flutter#173848)
2025-08-15 [email protected] Roll Skia from 162f47d6b6bd to 46ec77ae3954 (2 revisions) (flutter/flutter#173833)
2025-08-15 [email protected] Roll Dart SDK from c7faab270f27 to cc008dc8e7aa (2 revisions) (flutter/flutter#173826)
2025-08-15 [email protected] Roll Skia from ad5d04000101 to 162f47d6b6bd (5 revisions) (flutter/flutter#173822)
2025-08-15 [email protected] Update the RBE configuration for the recent Clang update (flutter/flutter#173803)
2025-08-15 [email protected] Stop writing legacy `FLUTTER_ROOT/version` file (by default?) (flutter/flutter#172793)
2025-08-15 [email protected] Remove `luci_flags.parallel_download_builds` and friends (flutter/flutter#173799)
2025-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Predictive back route transitions by default (#165832)" (flutter/flutter#173809)
2025-08-14 [email protected] Roll Skia from dca5f05fee87 to ad5d04000101 (8 revisions) (flutter/flutter#173798)
2025-08-14 [email protected] [web] Cleanup usages of deprecated `routeUpdated` message (flutter/flutter#173782)
2025-08-14 [email protected] Make sure that DataTable, DataColumn, DataRow, and DataCell don't crash in 0x0 environment (flutter/flutter#173515)
2025-08-14 [email protected] Make sure that a TableRowInkWell doesn't crash in 0x0 environment (flutter/flutter#173627)
2025-08-14 [email protected] Make sure that a DatePickerDialog doesn't crash in 0x0 environment (flutter/flutter#173677)
2025-08-14 [email protected] Return result of setting OpenGL contexts back to Flutter (flutter/flutter#173757)
2025-08-14 [email protected] Read `bin/cache/flutter.version.json` instead of `version` for `flutter_gallery` (flutter/flutter#173797)
2025-08-14 [email protected] Predictive back route transitions by default (flutter/flutter#165832)
2025-08-14 [email protected] feat: add onLongPressUp callback to InkWell widget (flutter/flutter#173221)
2025-08-14 [email protected] Roll Dart SDK from 214a7f829913 to c7faab270f27 (1 revision) (flutter/flutter#173792)
2025-08-14 [email protected] Add error handling for `Element` lifecycle user callbacks (flutter/flutter#173148)
2025-08-14 [email protected] Roll Fuchsia Linux SDK from I1TfNmsqTp7t3rO8e... to zWRpLglb48zC1vZLv... (flutter/flutter#173784)
2025-08-14 [email protected] [Range slider] Tap on active range,  the thumb closest to the mouse cursor should move to the cursor position. (flutter/flutter#173725)
2025-08-14 [email protected] Roll Packages from 6cb9113 to 09533b7 (4 revisions) (flutter/flutter#173789)
2025-08-14 [email protected] Implements the Android native stretch effect as a fragment shader (Impeller-only). (flutter/flutter#169293)
2025-08-14 [email protected] Sync `CHANGELOG.md` (3.35 -> `master`) (flutter/flutter#173790)
2025-08-14 [email protected] [VPAT][A11y] Announce Autocomplete search results status (flutter/flutter#173480)
2025-08-14 [email protected] Fix InputDecorator label padding (flutter/flutter#173344)
2025-08-14 [email protected] Fix default minimumSize in dropdownMenu when maximumSize is null (flutter/flutter#169438)
2025-08-14 [email protected] Thread sub-builders for every engine-uploading builder (flutter/flutter#173742)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
…ersion`) (flutter#172798)

Towards flutter#171900.

Discovered during flutter#172793.

It's unfortunate that `DefaultPub` (and tests) need some massaging to
work, but the fact the tool is so inconsistent about global versus local
state is not a new thing, so I didn't worry about it in the context of
this PR.
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
…r#172793)

Towards flutter#171900.

I'll make a breaking change announcement before landing this PR.

We can keep the flag for a stable release (allow folks to write `flutter
config --no-enable-omit-legacy-version-file` if they still need the
file), or we can decide it's not worth it and just rely on the breaking
change announcement.
WillBLogical pushed a commit to WillBLogical/packages that referenced this pull request Aug 20, 2025
…r#9832)

flutter/flutter@f4334d2...52af7a5

2025-08-15 [email protected] Roll Packages from 09533b7 to 5c52c55 (6 revisions) (flutter/flutter#173854)
2025-08-15 [email protected] Roll Skia from 46ec77ae3954 to 5654ac32ede0 (1 revision) (flutter/flutter#173848)
2025-08-15 [email protected] Roll Skia from 162f47d6b6bd to 46ec77ae3954 (2 revisions) (flutter/flutter#173833)
2025-08-15 [email protected] Roll Dart SDK from c7faab270f27 to cc008dc8e7aa (2 revisions) (flutter/flutter#173826)
2025-08-15 [email protected] Roll Skia from ad5d04000101 to 162f47d6b6bd (5 revisions) (flutter/flutter#173822)
2025-08-15 [email protected] Update the RBE configuration for the recent Clang update (flutter/flutter#173803)
2025-08-15 [email protected] Stop writing legacy `FLUTTER_ROOT/version` file (by default?) (flutter/flutter#172793)
2025-08-15 [email protected] Remove `luci_flags.parallel_download_builds` and friends (flutter/flutter#173799)
2025-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Predictive back route transitions by default (#165832)" (flutter/flutter#173809)
2025-08-14 [email protected] Roll Skia from dca5f05fee87 to ad5d04000101 (8 revisions) (flutter/flutter#173798)
2025-08-14 [email protected] [web] Cleanup usages of deprecated `routeUpdated` message (flutter/flutter#173782)
2025-08-14 [email protected] Make sure that DataTable, DataColumn, DataRow, and DataCell don't crash in 0x0 environment (flutter/flutter#173515)
2025-08-14 [email protected] Make sure that a TableRowInkWell doesn't crash in 0x0 environment (flutter/flutter#173627)
2025-08-14 [email protected] Make sure that a DatePickerDialog doesn't crash in 0x0 environment (flutter/flutter#173677)
2025-08-14 [email protected] Return result of setting OpenGL contexts back to Flutter (flutter/flutter#173757)
2025-08-14 [email protected] Read `bin/cache/flutter.version.json` instead of `version` for `flutter_gallery` (flutter/flutter#173797)
2025-08-14 [email protected] Predictive back route transitions by default (flutter/flutter#165832)
2025-08-14 [email protected] feat: add onLongPressUp callback to InkWell widget (flutter/flutter#173221)
2025-08-14 [email protected] Roll Dart SDK from 214a7f829913 to c7faab270f27 (1 revision) (flutter/flutter#173792)
2025-08-14 [email protected] Add error handling for `Element` lifecycle user callbacks (flutter/flutter#173148)
2025-08-14 [email protected] Roll Fuchsia Linux SDK from I1TfNmsqTp7t3rO8e... to zWRpLglb48zC1vZLv... (flutter/flutter#173784)
2025-08-14 [email protected] [Range slider] Tap on active range,  the thumb closest to the mouse cursor should move to the cursor position. (flutter/flutter#173725)
2025-08-14 [email protected] Roll Packages from 6cb9113 to 09533b7 (4 revisions) (flutter/flutter#173789)
2025-08-14 [email protected] Implements the Android native stretch effect as a fragment shader (Impeller-only). (flutter/flutter#169293)
2025-08-14 [email protected] Sync `CHANGELOG.md` (3.35 -> `master`) (flutter/flutter#173790)
2025-08-14 [email protected] [VPAT][A11y] Announce Autocomplete search results status (flutter/flutter#173480)
2025-08-14 [email protected] Fix InputDecorator label padding (flutter/flutter#173344)
2025-08-14 [email protected] Fix default minimumSize in dropdownMenu when maximumSize is null (flutter/flutter#169438)
2025-08-14 [email protected] Thread sub-builders for every engine-uploading builder (flutter/flutter#173742)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
…r#172793)

Towards flutter#171900.

I'll make a breaking change announcement before landing this PR.

We can keep the flag for a stable release (allow folks to write `flutter
config --no-enable-omit-legacy-version-file` if they still need the
file), or we can decide it's not worth it and just rely on the breaking
change announcement.
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
…r#172793)

Towards flutter#171900.

I'll make a breaking change announcement before landing this PR.

We can keep the flag for a stable release (allow folks to write `flutter
config --no-enable-omit-legacy-version-file` if they still need the
file), or we can decide it's not worth it and just rely on the breaking
change announcement.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…ersion`) (flutter#172798)

Towards flutter#171900.

Discovered during flutter#172793.

It's unfortunate that `DefaultPub` (and tests) need some massaging to
work, but the fact the tool is so inconsistent about global versus local
state is not a new thing, so I didn't worry about it in the context of
this PR.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…r#172793)

Towards flutter#171900.

I'll make a breaking change announcement before landing this PR.

We can keep the flag for a stable release (allow folks to write `flutter
config --no-enable-omit-legacy-version-file` if they still need the
file), or we can decide it's not worth it and just rely on the breaking
change announcement.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
…ersion`) (flutter#172798)

Towards flutter#171900.

Discovered during flutter#172793.

It's unfortunate that `DefaultPub` (and tests) need some massaging to
work, but the fact the tool is so inconsistent about global versus local
state is not a new thing, so I didn't worry about it in the context of
this PR.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
…r#172793)

Towards flutter#171900.

I'll make a breaking change announcement before landing this PR.

We can keep the flag for a stable release (allow folks to write `flutter
config --no-enable-omit-legacy-version-file` if they still need the
file), or we can decide it's not worth it and just rely on the breaking
change announcement.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
…ersion`) (flutter#172798)

Towards flutter#171900.

Discovered during flutter#172793.

It's unfortunate that `DefaultPub` (and tests) need some massaging to
work, but the fact the tool is so inconsistent about global versus local
state is not a new thing, so I didn't worry about it in the context of
this PR.
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
…r#172793)

Towards flutter#171900.

I'll make a breaking change announcement before landing this PR.

We can keep the flag for a stable release (allow folks to write `flutter
config --no-enable-omit-legacy-version-file` if they still need the
file), or we can decide it's not worth it and just rely on the breaking
change announcement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants