Skip to content

Conversation

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jul 25, 2025
@a-siva a-siva changed the title Manual roll of Dart from 5ede85aff798 to a58517fea52f Manual roll of Dart from 5ede85aff798 to 14ea8d342149 Jul 27, 2025
@a-siva a-siva requested a review from jason-simmons July 28, 2025 23:47
@a-siva a-siva added this pull request to the merge queue Jul 29, 2025
Merged via the queue into flutter:master with commit 9ceb761 Jul 29, 2025
176 checks passed
@a-siva a-siva deleted the dartroll branch July 29, 2025 01:25
@gemini-code-assist
Copy link
Contributor

Warning

There is an error in the Gemini Code Assist config file for this repository at .gemini/config.yaml. The configuration cannot be used until the file is fixed.

@jtmcdole
Copy link
Member

Reason for revert: Failing in post submit tests:

╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ UNEXPECTED ERROR!
║ Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dartvm
║ #0      verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:198:9)
║ <asynchronous suspension>
║ #1      verifyPreCodesignedTestRunner (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:39:3)
║ <asynchronous suspension>
║ #2      _runFromList (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/utils.dart:729:7)
║ <asynchronous suspension>
║ #3      main (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/test.dart:123:5)
║ <asynchronous suspension>
║ 
║ The test.dart script should be corrected to catch this error and call foundError().
║ Some tests are likely to have been skipped.
╚═══════════════════════════════════════════════════════════════════════════════
 00:59 +1550 ~1 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/text_field_test.dart: long press drag selects word by word and shows toolbar on lift on non-Apple platforms (variant: TargetPlatform.android)
 00:59 +1550 ~1 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/foundation/isolates_test.dart: compute() closes all ports with valid message [E]
   Expected: <0>
     Actual: <-1073740791>
   
   package:matcher                                     expect
   package:flutter_test/src/widget_tester.dart 473:18  expect
   test\foundation\isolates_test.dart 107:3            expectFileSuccessfullyCompletes

@jtmcdole jtmcdole added the revert Autorevert PR (with "Reason for revert:" comment) label Jul 29, 2025
auto-submit bot pushed a commit that referenced this pull request Jul 29, 2025
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jul 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2025
…)" (#172900)

<!-- start_original_pr_link -->
Reverts: #172783
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Failing in post submit tests:

```
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ UNEXPECTED ERROR!
║ Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dartvm
║ #0      verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:198:9)
║ <asynchron
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: a-siva
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jason-simmons}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149

https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 29, 2025
flutter/flutter@cfbaa18...46b097a

2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)" (flutter/flutter#172900)
2025-07-29 [email protected] Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (flutter/flutter#172783)
2025-07-29 [email protected] Revert "Remove 2023 deprecated `'platforms'` key from daemon output (#172593)" (flutter/flutter#172883)
2025-07-29 [email protected] Migrate Embedder code to impeller/DL geometry classes (flutter/flutter#172804)
2025-07-28 [email protected] [Flutter GPU] Fix Android/GLES crashers. (flutter/flutter#172588)
2025-07-28 [email protected] Roll Packages from 963550c to 6b2e34e (7 revisions) (flutter/flutter#172869)
2025-07-28 [email protected] Reland licenses cpp switch (flutter/flutter#172671)
2025-07-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Add --no-codesign support for macOS build (#169034)" (flutter/flutter#172878)
2025-07-28 [email protected] [flutter_tools] Add --no-codesign support for macOS build (flutter/flutter#169034)
2025-07-28 [email protected] Add `--config-only` build option for Linux and Windows (flutter/flutter#172239)
2025-07-28 [email protected] Add Gemini Code Assist review config and style guide (flutter/flutter#172785)
2025-07-28 [email protected] [ios]update provisioning profile for 2025-2026 cert for chromium bots (flutter/flutter#171021)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9695)

flutter/flutter@cfbaa18...46b097a

2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)" (flutter/flutter#172900)
2025-07-29 [email protected] Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (flutter/flutter#172783)
2025-07-29 [email protected] Revert "Remove 2023 deprecated `'platforms'` key from daemon output (#172593)" (flutter/flutter#172883)
2025-07-29 [email protected] Migrate Embedder code to impeller/DL geometry classes (flutter/flutter#172804)
2025-07-28 [email protected] [Flutter GPU] Fix Android/GLES crashers. (flutter/flutter#172588)
2025-07-28 [email protected] Roll Packages from 963550c to 6b2e34e (7 revisions) (flutter/flutter#172869)
2025-07-28 [email protected] Reland licenses cpp switch (flutter/flutter#172671)
2025-07-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Add --no-codesign support for macOS build (#169034)" (flutter/flutter#172878)
2025-07-28 [email protected] [flutter_tools] Add --no-codesign support for macOS build (flutter/flutter#169034)
2025-07-28 [email protected] Add `--config-only` build option for Linux and Windows (flutter/flutter#172239)
2025-07-28 [email protected] Add Gemini Code Assist review config and style guide (flutter/flutter#172785)
2025-07-28 [email protected] [ios]update provisioning profile for 2025-2026 cert for chromium bots (flutter/flutter#171021)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
…er#172783)" (flutter#172900)

<!-- start_original_pr_link -->
Reverts: flutter#172783
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Failing in post submit tests:

```
╔═╡ERROR flutter#1╞════════════════════════════════════════════════════════════════════
║ UNEXPECTED ERROR!
║ Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dartvm
║ #0      verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:198:9)
║ <asynchron
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: a-siva
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jason-simmons}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149

https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…er#172783)" (flutter#172900)

<!-- start_original_pr_link -->
Reverts: flutter#172783
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Failing in post submit tests:

```
╔═╡ERROR flutter#1╞════════════════════════════════════════════════════════════════════
║ UNEXPECTED ERROR!
║ Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dartvm
║ #0      verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:198:9)
║ <asynchron
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: a-siva
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jason-simmons}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149

https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
…er#172783)" (flutter#172900)

<!-- start_original_pr_link -->
Reverts: flutter#172783
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Failing in post submit tests:

```
╔═╡ERROR flutter#1╞════════════════════════════════════════════════════════════════════
║ UNEXPECTED ERROR!
║ Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dartvm
║ #0      verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:198:9)
║ <asynchron
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: a-siva
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jason-simmons}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149

https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
…er#172783)" (flutter#172900)

<!-- start_original_pr_link -->
Reverts: flutter#172783
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Failing in post submit tests:

```
╔═╡ERROR flutter#1╞════════════════════════════════════════════════════════════════════
║ UNEXPECTED ERROR!
║ Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dartvm
║ #0      verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:198:9)
║ <asynchron
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: a-siva
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jason-simmons}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149

https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev
https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants