-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[CP-stable]Revert #160653 Fix view removal process for AutofillContextAction.cancel #172676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP-stable]Revert #160653 Fix view removal process for AutofillContextAction.cancel #172676
Conversation
…ion.cancel (flutter#172490) Between flutter#145681 (autofill save prompt shows up for password fields when you dismiss the keyboard) and flutter#172250 (calling `TextInput.hide` causes the current active text field to lose its text) the latter seems to be the worse bug. The framework `EditableText` implementation only calls `TextInput.hide` when switching input controls, so flutter#172250 typically does not affect flutter text fields itself, but becomes a problem if the app wishes to add UI (similar to the iOS down-arrow button that would show up above the keyboard when you're filling out a form) to dismiss the keyboard. This reopens flutter#145681. See flutter#145681 (comment) @koji-1009 does reverting sound ok to you? ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
@LongCatIsLooong please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
ef0cd00
into
flutter:flutter-3.32-candidate.0
…fillContextAction.cancel (flutter/flutter#172676)
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#172250
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Fixes a bug where
TextInput.hidecall incorrect clears the text in the active text field.Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
If an app calls
TextInput.hideto hide the software keyboard, the user input in the current active text field will also be erased. It impacts the production app.The framework itself doesn't seem to call
TextInput.hidein a way that would affect the user.Workaround:
Is there a workaround for this issue?
Yes, in theory, developers can store and restore the
TextEditingValue, when they need to callTextInput.hide, to undo the clear. However I suspect the reverted PR may also break voiceover.Risk:
What is the risk level of this cherry-pick?
This is a revert of #160653. The reverted PR was merged in February, and the previous implementation was introduced in 2021.
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
This change is a revert so the added test will also get reverted.
Validation Steps:
What are the steps to validate that this fix works?
To verify the fix on master (it has already landed on master), run this app:
focus the text field and then click the hide keyboard button. The text "aaaaaa..." should remain after the button is clicked.