Update the AccessibilityPlugin::Announce method to account for the view #172669

mattkae · 2025-07-23T20:31:57Z

What's new?

The accessibility "announce" method now takes a view_id
The view_id is used to lookup the corresponding FlutterView in the win32 embedder
Updated the associated tests

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

engine/src/flutter/shell/platform/windows/accessibility_plugin.cc

packages/flutter/lib/src/semantics/semantics_service.dart

loic-sharma · 2025-07-24T23:30:56Z

@hannah-hyj Could you also review this as it affects accessibility announcements? For multi-window on Windows, we need to route the accessibility announcement to the right window. This requires piping a view ID in the accessibility announcement.

loic-sharma

Functionally this looks good to me, but we should avoid the breaking change.

packages/flutter/lib/src/semantics/semantics_event.dart

packages/flutter/lib/src/semantics/semantics_service.dart

loic-sharma

Windows changes look good to me!

Framework changes look to good to me as well, but please get an approval from an accessibility expert like @hannah-hyj before merging.

flutter-dashboard · 2025-07-25T18:54:04Z

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: d1d01ef.

Possible causes:

Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

GitHub Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 9770:2E63:2B814:59FA1:6883D2CC.

Stack trace:

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:486:5)
#1      GitHub.request (package:github/src/common/github.dart:422:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:323:22)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      LuciBuildService.scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:246:24)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1250:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1311:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1122:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompletion (package:cocoon_service/src/service/scheduler.dart:1055:9)
<asynchronous suspension>
#9      Scheduler.processCheckRun (package:cocoon_service/src/service/scheduler.dart:1395:9)
<asynchronous suspension>
#10     GithubWebhookSubscription.post (package:cocoon_service/src/request_handlers/github/webhook_subscription.dart:118:24)
<asynchronous suspension>
#11     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:45:20)
<asynchronous suspension>
#12     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:140:5)
<asynchronous suspension>
#13     createServer.<anonymous closure> (package:cocoon_service/server.dart:329:7)
<asynchronous suspension>

packages/flutter/lib/src/semantics/semantics_service.dart

…for the view (flutter/flutter#172669)

…9862) Manual roll Flutter from e65380a22076 to 960d1078f876 (36 revisions) Manual roll requested by [email protected] flutter/flutter@e65380a...960d107 2025-08-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reapply "Add set semantics enabled API and wire iOS a11y bridge (#161… (#171198)" (flutter/flutter#174153) 2025-08-20 [email protected] Make sure that a Badge doesn't crash in 0x0 environment (flutter/flutter#172065) 2025-08-20 [email protected] Make sure that CalendarDatePicker & YearPicker don't crash in 0x0 environment (flutter/flutter#173408) 2025-08-20 [email protected] Roll Packages from 953cae0 to 58c02e0 (2 revisions) (flutter/flutter#174142) 2025-08-20 [email protected] Make sure that a CircleAvatar doesn't crash in 0x0 environment (flutter/flutter#173498) 2025-08-20 [email protected] Roll Dart SDK from 0d674ff61e2e to 0d0a0c394381 (1 revision) (flutter/flutter#174126) 2025-08-20 [email protected] [Android] Fix version code override calculation in FlutterPlugin (flutter/flutter#174081) 2025-08-20 [email protected] Make sure that a BackButton doesn't crash in 0x0 environment (flutter/flutter#172817) 2025-08-20 [email protected] Roll Dart SDK from c5f5a32df36c to 0d674ff61e2e (1 revision) (flutter/flutter#174099) 2025-08-20 [email protected] feat: Added FocusNode prop for DropdownMenu Trailing Icon Button (flutter/flutter#172753) 2025-08-20 [email protected] Make component theme data defaults use `WidgetStateProperty` (flutter/flutter#173893) 2025-08-20 [email protected] Fix Menu anchor reduce padding on web and desktop (flutter/flutter#172691) 2025-08-20 [email protected] Roll Skia from 4b788d0e5e63 to 721e68fe652a (2 revisions) (flutter/flutter#174095) 2025-08-20 [email protected] Fix time picker period selector a11y touch targets (flutter/flutter#170060) 2025-08-20 [email protected] Fix SegmentedButton focus issue (flutter/flutter#173953) 2025-08-20 [email protected] Roll Dart SDK from e936404543f1 to c5f5a32df36c (1 revision) (flutter/flutter#174089) 2025-08-20 [email protected] Roll Skia from 953bfc0e2f2a to 4b788d0e5e63 (1 revision) (flutter/flutter#174086) 2025-08-19 [email protected] Roll Skia from 07d71ea4d056 to 953bfc0e2f2a (18 revisions) (flutter/flutter#174072) 2025-08-19 [email protected] Roll Dart SDK from 9105d946af95 to e936404543f1 (5 revisions) (flutter/flutter#174074) 2025-08-19 [email protected] NavigationRail correct traversal order (flutter/flutter#173891) 2025-08-19 [email protected] Update CupertinoSliverNavigationBar.middle (flutter/flutter#173868) 2025-08-19 [email protected] Update the AccessibilityPlugin::Announce method to account for the view (flutter/flutter#172669) 2025-08-19 [email protected] [ Widget Preview ] Report an error if a web device is unavailable (flutter/flutter#174036) 2025-08-19 [email protected] [web] Fix error in ClickDebouncer when using VoiceOver (flutter/flutter#174046) 2025-08-19 [email protected] [ Tool ] Add logging to test_adapter_test.dart (flutter/flutter#174073) 2025-08-19 [email protected] Roll Fuchsia Linux SDK from n0EnLlotF2wczlOq_... to V1A1J6uXZ62Q10i9u... (flutter/flutter#174059) 2025-08-19 [email protected] Cleanup legacy `bringup: true` tasks, either removing or enabling (flutter/flutter#173815) 2025-08-19 [email protected] Add Shift+Enter shortcut example for TextField. (flutter/flutter#167952) 2025-08-19 [email protected] Check that the windows architecture is 64-bit and not the process architecture (flutter/flutter#174019) 2025-08-19 [email protected] Improve Stack widget error message for bounded constraints (flutter/flutter#173352) 2025-08-19 [email protected] [VPAT][A11y] AutoComplete dropdown option is missing button role (flutter/flutter#173297) 2025-08-19 [email protected] fix: Android build fails when minSdk is set below 24 in build.gradle.kts (#173823) (flutter/flutter#173825) 2025-08-19 [email protected] Reapply "Add set semantics enabled API and wire iOS a11y bridge (#161… (flutter/flutter#171198) 2025-08-19 [email protected] fix: only use library props for libraries (flutter/flutter#172704) 2025-08-19 [email protected] Roll Packages from 5c52c55 to 953cae0 (22 revisions) (flutter/flutter#174040) 2025-08-19 [email protected] Add `open_jdk` to `Linux linux_android_emulator.debug_x64` (flutter/flutter#173989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

auto-submit · 2025-08-21T16:45:03Z

Time to revert pull request flutter/flutter/172669 has elapsed.
You need to open the revert manually and process as a regular pull request.

…r the view (flutter#172669)" This reverts commit e131243.

chunhtai · 2025-08-21T16:49:26Z

This pr is reverted due to it causes internal breakage, some of the internal code does use AnnounceSemanticsEvent directly

chunhtai · 2025-08-21T16:50:00Z

internal only link https://fusion2.corp.google.com/presubmit/797456459/OCL:797456459:BASE:797786988:1755792153310:a7ce45f7/targets

mattkae · 2025-08-21T17:46:20Z

@chunhtai Can you provide any guidance as to how I should unblock this? Maybe making the viewId in the constructor be optional is the solution?

CC: @loic-sharma

chunhtai · 2025-08-21T18:05:09Z

can you open a new pr with the exact same change? no action from you, we will take care of the internal migration

…ew (flutter#172669) ## What's new? - The accessibility "announce" method now takes a `view_id` - The `view_id` is used to lookup the corresponding `FlutterView` in the win32 embedder - Updated the associated tests ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <[email protected]>

…ew (flutter#172669) ## What's new? - The accessibility "announce" method now takes a `view_id` - The `view_id` is used to lookup the corresponding `FlutterView` in the win32 embedder - Updated the associated tests ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <[email protected]>

…ew (flutter#172669) ## What's new? - The accessibility "announce" method now takes a `view_id` - The `view_id` is used to lookup the corresponding `FlutterView` in the win32 embedder - Updated the associated tests ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <[email protected]>

…ew (flutter#172669) ## What's new? - The accessibility "announce" method now takes a `view_id` - The `view_id` is used to lookup the corresponding `FlutterView` in the win32 embedder - Updated the associated tests ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <[email protected]>

…ew (flutter#172669) ## What's new? - The accessibility "announce" method now takes a `view_id` - The `view_id` is used to lookup the corresponding `FlutterView` in the win32 embedder - Updated the associated tests ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <[email protected]>

…for the view (flutter/flutter#172669)

…ew (flutter#172669) ## What's new? - The accessibility "announce" method now takes a `view_id` - The `view_id` is used to lookup the corresponding `FlutterView` in the win32 embedder - Updated the associated tests ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <[email protected]>

mattkae force-pushed the announce-event-multi-view branch 2 times, most recently from 0f84654 to e81b319 Compare July 24, 2025 13:51

mattkae marked this pull request as ready for review July 24, 2025 14:14

mattkae requested review from knopp and loic-sharma July 24, 2025 14:14

Update the AccessibilityPlugin::Announce method to account for the view

29aa8c9

mattkae force-pushed the announce-event-multi-view branch from e81b319 to 29aa8c9 Compare July 24, 2025 14:52

github-actions bot added the a: tests "flutter test", flutter_test, or one of our tests label Jul 24, 2025

loic-sharma reviewed Jul 24, 2025

View reviewed changes

engine/src/flutter/shell/platform/windows/accessibility_plugin.cc Show resolved Hide resolved

loic-sharma reviewed Jul 24, 2025

View reviewed changes

packages/flutter/lib/src/semantics/semantics_service.dart Outdated Show resolved Hide resolved

loic-sharma requested a review from hannah-hyj July 24, 2025 23:29

loic-sharma reviewed Jul 25, 2025

View reviewed changes

mattkae and others added 3 commits July 25, 2025 12:16

Various bits of PR feedback

6d98c0a

Missed a spot!

0de9a8e

Formatting

6e9a70d

loic-sharma reviewed Jul 25, 2025

View reviewed changes

packages/flutter/lib/src/semantics/semantics_event.dart Outdated Show resolved Hide resolved

Remove erroneous viewId accessor

d62d1eb

loic-sharma reviewed Jul 25, 2025

View reviewed changes

packages/flutter/lib/src/semantics/semantics_service.dart Outdated Show resolved Hide resolved

loic-sharma approved these changes Jul 25, 2025

View reviewed changes

mattkae added 2 commits July 25, 2025 14:29

PR feedback

118d90a

Remove erroneous return statement

d1d01ef

loic-sharma reviewed Jul 25, 2025

View reviewed changes

packages/flutter/lib/src/semantics/semantics_service.dart Show resolved Hide resolved

engine-flutter-autoroll mentioned this pull request Aug 20, 2025

Roll Flutter from e65380a22076 to 07bbaf07353d (28 revisions) flutter/packages#9858

Closed

loic-sharma mentioned this pull request Aug 20, 2025

Add accessibility announcements to a11y_assessments's SnackBars #173686

Closed

9 tasks

engine-flutter-autoroll mentioned this pull request Aug 20, 2025

Roll Flutter from e65380a22076 to 07bbaf07353d (28 revisions) flutter/packages#9859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 20, 2025

e131243b0 Update the AccessibilityPlugin::Announce method to account …

91d0f38

…for the view (flutter/flutter#172669)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 20, 2025

e131243b0 Update the AccessibilityPlugin::Announce method to account …

5c80f69

…for the view (flutter/flutter#172669)

engine-flutter-autoroll mentioned this pull request Aug 20, 2025

Manual roll Flutter from e65380a22076 to 960d1078f876 (36 revisions) flutter/packages#9862

Merged

chunhtai added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 21, 2025

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Aug 21, 2025

chunhtai added a commit to chunhtai/flutter that referenced this pull request Aug 21, 2025

Revert "Update the AccessibilityPlugin::Announce method to account fo…

e25d6f2

…r the view (flutter#172669)" This reverts commit e131243.

chunhtai mentioned this pull request Aug 21, 2025

Revert "Update the AccessibilityPlugin::Announce method to account fo… #174223

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

e131243b0 Update the AccessibilityPlugin::Announce method to account …

c1b5f84

…for the view (flutter/flutter#172669)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update the AccessibilityPlugin::Announce method to account for the view #172669

Update the AccessibilityPlugin::Announce method to account for the view #172669

Uh oh!

mattkae commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

loic-sharma commented Jul 24, 2025

Uh oh!

loic-sharma left a comment

Uh oh!

Uh oh!

Uh oh!

loic-sharma left a comment

Uh oh!

flutter-dashboard bot commented Jul 25, 2025

Uh oh!

Uh oh!

auto-submit bot commented Aug 21, 2025

Uh oh!

chunhtai commented Aug 21, 2025

Uh oh!

chunhtai commented Aug 21, 2025

Uh oh!

mattkae commented Aug 21, 2025

Uh oh!

chunhtai commented Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Update the AccessibilityPlugin::Announce method to account for the view #172669

Update the AccessibilityPlugin::Announce method to account for the view #172669

Uh oh!

Conversation

mattkae commented Jul 23, 2025

What's new?

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

loic-sharma commented Jul 24, 2025

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Jul 25, 2025

Uh oh!

Uh oh!

auto-submit bot commented Aug 21, 2025

Uh oh!

chunhtai commented Aug 21, 2025

Uh oh!

chunhtai commented Aug 21, 2025

Uh oh!

mattkae commented Aug 21, 2025

Uh oh!

chunhtai commented Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants