Skip to content

Conversation

@matanlurey
Copy link
Contributor

Towards #150279.

I'll CP this into 3.35, and then we can remove support for the flag on master.

(IIRC this only still existed because of google3)

@matanlurey matanlurey requested a review from chingjun July 22, 2025 23:36
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 22, 2025
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 23, 2025

autosubmit label was removed for flutter/flutter/172595, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2025
@matanlurey matanlurey added this pull request to the merge queue Jul 23, 2025
Merged via the queue into flutter:master with commit 1e84cbe Jul 23, 2025
141 of 142 checks passed
@matanlurey matanlurey deleted the deprecate-disable-dds branch July 23, 2025 17:54
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 24, 2025
flutter/flutter@afba7d7...20788c0

2025-07-24 [email protected] Roll Packages from 9c85e5e to 963550c (4 revisions) (flutter/flutter#172696)
2025-07-24 [email protected] Add missing deprecations to CupertinoDynamicColor. (flutter/flutter#171160)
2025-07-24 [email protected] Roll Dart SDK from a181fe571dc8 to 26dece893751 (2 revisions) (flutter/flutter#172683)
2025-07-24 [email protected] Migrate to null aware elements - Part 1 (flutter/flutter#172198)
2025-07-24 [email protected] licenses_cpp: implements extracting regions from matched text (flutter/flutter#172655)
2025-07-24 [email protected] Roll pub packages (flutter/flutter#172677)
2025-07-24 [email protected] Marks Mac_ios keyboard_hot_restart_ios to be unflaky (flutter/flutter#168053)
2025-07-24 [email protected] Roll Abseil and remove a workaround for a Fuchsia target that was unable to build Abseil (flutter/flutter#172665)
2025-07-24 [email protected] Add `automaticallyImplyActions` property to AppBar (flutter/flutter#171113)
2025-07-24 [email protected] fix: TabBar fontFamily inheritance with custom label styles (flutter/flutter#171699)
2025-07-23 [email protected] Marks Linux_mokey new_gallery__crane_perf to be unflaky (flutter/flutter#167633)
2025-07-23 [email protected] [android] Fix broken `--android-skip-build-dependency-validation` flag (flutter/flutter#172581)
2025-07-23 [email protected] Fix: Ensure Text widget locale is included in semantics language tag (flutter/flutter#172034)
2025-07-23 [email protected] [Web][a11y] Update selected chips semantics  (flutter/flutter#172660)
2025-07-23 [email protected] Roll Skia from eea1c33fbe84 to 094ac350125f (29 revisions) (flutter/flutter#172664)
2025-07-23 [email protected] Marks Mac_arm64_ios imitation_game_flutter to be unflaky (flutter/flutter#168052)
2025-07-23 [email protected] Roll Dart SDK from a31774a3d049 to a181fe571dc8 (2 revisions) (flutter/flutter#172667)
2025-07-23 [email protected] Adapt xcresult parser for Xcode 16 changes (flutter/flutter#172596)
2025-07-23 [email protected] Update excluded_files to match the current output of the old license checker (flutter/flutter#172670)
2025-07-23 [email protected] Manual Roll of Dart SDK from da9e0299c120 to a31774a3d049 (flutter/flutter#172616)
2025-07-23 [email protected] [FGP] Small restructuring of Android Studio native flutter dependency support (flutter/flutter#172651)
2025-07-23 [email protected] revert:  Replaces legacy licenses check with licenses_cpp (flutter/flutter#172568)
2025-07-23 [email protected] fix: size-exp naming (flutter/flutter#172647)
2025-07-23 [email protected] Roll Fuchsia Test Scripts from MnFlN7VWM_7h7EmBV... to BWj3yYC74ud58QhN0... (flutter/flutter#172646)
2025-07-23 [email protected] [DisplayList] implement shadow bounds without relying on Skia utilities (flutter/flutter#172572)
2025-07-23 [email protected] Update `dev/bots/post_process_docs.dart` to use `flutter.version.json` (flutter/flutter#172601)
2025-07-23 [email protected] Emit a warning on `--[no-]disable-dds`, preferring `--no-dds` (flutter/flutter#172595)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@matanlurey matanlurey added the cp: beta cherry pick this pull request to beta release candidate branch label Jul 25, 2025
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Jul 25, 2025
…r#172595)

Towards flutter#150279.

I'll CP this into 3.35, and then we can remove support for the flag on
`master`.

(IIRC this only still existed because of google3)
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2025
Closes #150279.

Made a warning in #172595 and
cherry-picked into the next beta (will be stable) as
#172790.
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
…r#172595)

Towards flutter#150279.

I'll CP this into 3.35, and then we can remove support for the flag on
`master`.

(IIRC this only still existed because of google3)
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
Closes flutter#150279.

Made a warning in flutter#172595 and
cherry-picked into the next beta (will be stable) as
flutter#172790.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9670)

flutter/flutter@afba7d7...20788c0

2025-07-24 [email protected] Roll Packages from 9c85e5e to 963550c (4 revisions) (flutter/flutter#172696)
2025-07-24 [email protected] Add missing deprecations to CupertinoDynamicColor. (flutter/flutter#171160)
2025-07-24 [email protected] Roll Dart SDK from a181fe571dc8 to 26dece893751 (2 revisions) (flutter/flutter#172683)
2025-07-24 [email protected] Migrate to null aware elements - Part 1 (flutter/flutter#172198)
2025-07-24 [email protected] licenses_cpp: implements extracting regions from matched text (flutter/flutter#172655)
2025-07-24 [email protected] Roll pub packages (flutter/flutter#172677)
2025-07-24 [email protected] Marks Mac_ios keyboard_hot_restart_ios to be unflaky (flutter/flutter#168053)
2025-07-24 [email protected] Roll Abseil and remove a workaround for a Fuchsia target that was unable to build Abseil (flutter/flutter#172665)
2025-07-24 [email protected] Add `automaticallyImplyActions` property to AppBar (flutter/flutter#171113)
2025-07-24 [email protected] fix: TabBar fontFamily inheritance with custom label styles (flutter/flutter#171699)
2025-07-23 [email protected] Marks Linux_mokey new_gallery__crane_perf to be unflaky (flutter/flutter#167633)
2025-07-23 [email protected] [android] Fix broken `--android-skip-build-dependency-validation` flag (flutter/flutter#172581)
2025-07-23 [email protected] Fix: Ensure Text widget locale is included in semantics language tag (flutter/flutter#172034)
2025-07-23 [email protected] [Web][a11y] Update selected chips semantics  (flutter/flutter#172660)
2025-07-23 [email protected] Roll Skia from eea1c33fbe84 to 094ac350125f (29 revisions) (flutter/flutter#172664)
2025-07-23 [email protected] Marks Mac_arm64_ios imitation_game_flutter to be unflaky (flutter/flutter#168052)
2025-07-23 [email protected] Roll Dart SDK from a31774a3d049 to a181fe571dc8 (2 revisions) (flutter/flutter#172667)
2025-07-23 [email protected] Adapt xcresult parser for Xcode 16 changes (flutter/flutter#172596)
2025-07-23 [email protected] Update excluded_files to match the current output of the old license checker (flutter/flutter#172670)
2025-07-23 [email protected] Manual Roll of Dart SDK from da9e0299c120 to a31774a3d049 (flutter/flutter#172616)
2025-07-23 [email protected] [FGP] Small restructuring of Android Studio native flutter dependency support (flutter/flutter#172651)
2025-07-23 [email protected] revert:  Replaces legacy licenses check with licenses_cpp (flutter/flutter#172568)
2025-07-23 [email protected] fix: size-exp naming (flutter/flutter#172647)
2025-07-23 [email protected] Roll Fuchsia Test Scripts from MnFlN7VWM_7h7EmBV... to BWj3yYC74ud58QhN0... (flutter/flutter#172646)
2025-07-23 [email protected] [DisplayList] implement shadow bounds without relying on Skia utilities (flutter/flutter#172572)
2025-07-23 [email protected] Update `dev/bots/post_process_docs.dart` to use `flutter.version.json` (flutter/flutter#172601)
2025-07-23 [email protected] Emit a warning on `--[no-]disable-dds`, preferring `--no-dds` (flutter/flutter#172595)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
…r#172595)

Towards flutter#150279.

I'll CP this into 3.35, and then we can remove support for the flag on
`master`.

(IIRC this only still existed because of google3)
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
Closes flutter#150279.

Made a warning in flutter#172595 and
cherry-picked into the next beta (will be stable) as
flutter#172790.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…r#172595)

Towards flutter#150279.

I'll CP this into 3.35, and then we can remove support for the flag on
`master`.

(IIRC this only still existed because of google3)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
Closes flutter#150279.

Made a warning in flutter#172595 and
cherry-picked into the next beta (will be stable) as
flutter#172790.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
…r#172595)

Towards flutter#150279.

I'll CP this into 3.35, and then we can remove support for the flag on
`master`.

(IIRC this only still existed because of google3)
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
Closes flutter#150279.

Made a warning in flutter#172595 and
cherry-picked into the next beta (will be stable) as
flutter#172790.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
…r#172595)

Towards flutter#150279.

I'll CP this into 3.35, and then we can remove support for the flag on
`master`.

(IIRC this only still existed because of google3)
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
Closes flutter#150279.

Made a warning in flutter#172595 and
cherry-picked into the next beta (will be stable) as
flutter#172790.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cp: beta cherry pick this pull request to beta release candidate branch tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants