Refactor checks for --machine
#172504
Merged
Refactor checks for --machine
#172504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
the
tool
chingjun
approved these changes
Jul 21, 2025
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/172504, because - The status or check suite Linux tool_integration_tests_2_7 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 22, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 22, 2025
flutter/flutter@70cdc0c...ee0cc66 2025-07-22 [email protected] Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 [email protected] fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 [email protected] Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 [email protected] Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 [email protected] Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 [email protected] Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 [email protected] Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 [email protected] Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 [email protected] Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 [email protected] feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 [email protected] Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 [email protected] Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 [email protected] Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 [email protected] Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 [email protected] fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 [email protected] Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 [email protected] Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 [email protected] Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 [email protected] Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 [email protected] Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 [email protected] Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 [email protected] Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 [email protected] Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 [email protected] Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 [email protected] Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 [email protected] Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9662) flutter/flutter@70cdc0c...ee0cc66 2025-07-22 [email protected] Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 [email protected] fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 [email protected] Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 [email protected] Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 [email protected] Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 [email protected] Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 [email protected] Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 [email protected] Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 [email protected] Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 [email protected] feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 [email protected] Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 [email protected] Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 [email protected] Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 [email protected] Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 [email protected] fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 [email protected] Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 [email protected] Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 [email protected] Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 [email protected] Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 [email protected] Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 [email protected] Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 [email protected] Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 [email protected] Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 [email protected] Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 [email protected] Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 [email protected] Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was already fixed in #150138, so removes duplicate flag.
Already tested by existing test suite.