Skip to content

Conversation

@matanlurey
Copy link
Contributor

... so that it doesn't require downloading cache artifacts to run general.shard/project_test.dart.

Closes #83275.

@matanlurey matanlurey requested a review from jmagman July 21, 2025 22:59
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 21, 2025
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the tool is downloading gradle here even if it isn't required? If so this LGTM, though I am curious if we could avoid triggering gradle downloading in the first place if it isn't needed?

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jul 22, 2025
Merged via the queue into flutter:master with commit 3038239 Jul 22, 2025
142 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 23, 2025
flutter/flutter@ee0cc66...afba7d7

2025-07-23 [email protected] Remove GtkGLArea and render directly into GtkDrawingArea (flutter/flutter#172343)
2025-07-23 [email protected] Prefix generated Dart plugin imports for `registerWith` (flutter/flutter#172511)
2025-07-23 [email protected] Remove stale references to `.packages` in tool tests (flutter/flutter#172582)
2025-07-23 [email protected] Wraps all `git` executions in a `Git(...).*`, use `*=noglob` on Windows (flutter/flutter#172495)
2025-07-22 [email protected] Omit instruction to `cd .` after `flutter create` (flutter/flutter#172513)
2025-07-22 [email protected] Improve assertion message in `AlignmentDirectional.resolve` (flutter/flutter#172096)
2025-07-22 [email protected] Update warnGradleVersion to `8.7.0` (flutter/flutter#172576)
2025-07-22 [email protected] Use a fake representation of `cache/artifacts/gradle_wrapper` (flutter/flutter#172503)
2025-07-22 [email protected] Revert #160653 Fix view removal process for AutofillContextAction.cancel (flutter/flutter#172490)
2025-07-22 [email protected] Bump meta to 0.17.0 (flutter/flutter#172541)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
…r#172503)

... so that it doesn't require downloading cache artifacts to run
`general.shard/project_test.dart`.

Closes flutter#83275.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9665)

flutter/flutter@ee0cc66...afba7d7

2025-07-23 [email protected] Remove GtkGLArea and render directly into GtkDrawingArea (flutter/flutter#172343)
2025-07-23 [email protected] Prefix generated Dart plugin imports for `registerWith` (flutter/flutter#172511)
2025-07-23 [email protected] Remove stale references to `.packages` in tool tests (flutter/flutter#172582)
2025-07-23 [email protected] Wraps all `git` executions in a `Git(...).*`, use `*=noglob` on Windows (flutter/flutter#172495)
2025-07-22 [email protected] Omit instruction to `cd .` after `flutter create` (flutter/flutter#172513)
2025-07-22 [email protected] Improve assertion message in `AlignmentDirectional.resolve` (flutter/flutter#172096)
2025-07-22 [email protected] Update warnGradleVersion to `8.7.0` (flutter/flutter#172576)
2025-07-22 [email protected] Use a fake representation of `cache/artifacts/gradle_wrapper` (flutter/flutter#172503)
2025-07-22 [email protected] Revert #160653 Fix view removal process for AutofillContextAction.cancel (flutter/flutter#172490)
2025-07-22 [email protected] Bump meta to 0.17.0 (flutter/flutter#172541)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
…r#172503)

... so that it doesn't require downloading cache artifacts to run
`general.shard/project_test.dart`.

Closes flutter#83275.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…r#172503)

... so that it doesn't require downloading cache artifacts to run
`general.shard/project_test.dart`.

Closes flutter#83275.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
…r#172503)

... so that it doesn't require downloading cache artifacts to run
`general.shard/project_test.dart`.

Closes flutter#83275.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
…r#172503)

... so that it doesn't require downloading cache artifacts to run
`general.shard/project_test.dart`.

Closes flutter#83275.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter tool general.shard/project_test.dart fails run locally when Android artifacts not downloaded

2 participants