Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented May 3, 2018

The "about" text was apparently too long.

The "about" text was apparently too long.
@Hixie
Copy link
Contributor Author

Hixie commented May 3, 2018

See https://github.com/flutter/flutter/pull/17250/files?w=1 for a version of the diff with GitHub's whitespace mangling hidden (I used the UI to edit this, but had written the original files in a different UI).

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor Author

Hixie commented May 3, 2018

Landing on red by popular demand.

@Hixie Hixie merged commit 0317308 into master May 3, 2018
@Hixie Hixie deleted the Hixie-patch-2 branch May 3, 2018 21:51
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
The "about" text was apparently too long.
Copy link

@mdale00o mdale00o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoechi zoechi added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 12, 2018
gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Mar 24, 2020
git log 2d42c74..d7ad50c --first-parent --oneline
d7ad50c Roll src/third_party/skia c97c90072499..6cb8168c2b9b (1 commits) (flutter#17287)
704a869 Roll src/third_party/dart cbd67124d10e..8246621d4da3 (39 commits) (flutter#17286)
33895cf Roll src/third_party/skia d1988219065a..c97c90072499 (2 commits) (flutter#17285)
48d1165 Roll fuchsia/sdk/core/linux-amd64 from h8m0G... to y2Piw... (flutter#17283)
0015b19 Roll fuchsia/sdk/core/mac-amd64 from WaNBa... to gkIC0... (flutter#17282)
518c9e0 Remove checks for the always true using_fuchsia_sdk flag in all GN files. (flutter#17261)
1eea062 Roll src/third_party/skia 3c358420df4a..d1988219065a (3 commits) (flutter#17279)
ad8ccf4 [Fuchsia] Move physical shape layer compositing to Flutter (flutter#17005)
c490cb9 Roll src/third_party/skia 165b68ebb6ad..3c358420df4a (5 commits) (flutter#17277)
4c41b14 [web] Introduce js interop to enable experimental flags on web (flutter#17099)
21f5d7f Roll src/third_party/skia 4098719375d8..165b68ebb6ad (7 commits) (flutter#17274)
6fef0d0 Removed a text input trait that causes VoiceOver to be incorrect when tapping a text input. (flutter#17203)
9343c5e added missing mock to MockEngine for iOS unit tests (flutter#17273)
af056a8 Roll src/third_party/skia 6f60a859c628..4098719375d8 (6 commits) (flutter#17271)
33a21d1 Add DartProject for Windows embedding API (flutter#17210)
8a8b298 Added a log message when sharing a FlutterEngine across multiple FlutterViewControllers. (flutter#17186)
11f5521 Roll src/third_party/skia f04f21a5c913..6f60a859c628 (2 commits) (flutter#17268)
da9e778 Roll fuchsia/sdk/core/linux-amd64 from k4zbT... to h8m0G... (flutter#17264)
c86a4cc Roll fuchsia/sdk/core/mac-amd64 from bgp6U... to WaNBa... (flutter#17263)
35e8303 Roll src/third_party/skia 538e358b0d82..f04f21a5c913 (2 commits) (flutter#17260)
e56b335 Allow external texture sources when using the Metal backend. (flutter#17154)
c0deb23 Don’t depend on an implicit transaction when no external view embedder is present. (flutter#17258)
80846b0 Roll src/third_party/dart b7455646f90d..cbd67124d10e (3 commits) (flutter#17257)
9c64029 Documentation cleanups to RuntimeController. (flutter#17256)
209e786 Roll fuchsia/sdk/core/linux-amd64 from kGu6P... to k4zbT... (flutter#17255)
aa26106 Roll fuchsia/sdk/core/mac-amd64 from nmCXC... to bgp6U... (flutter#17254)
eec7447 Roll src/third_party/dart bdf14543576a..b7455646f90d (1 commits) (flutter#17253)
ba26ce3 Roll src/third_party/dart 861708483217..bdf14543576a (5 commits) (flutter#17252)
c9a24af Roll src/third_party/skia cf3594b60362..538e358b0d82 (4 commits) (flutter#17251)
59406cc Roll src/third_party/skia e41fa2d5e44d..cf3594b60362 (1 commits) (flutter#17249)
7d21f97 Roll src/third_party/dart f247613737ec..861708483217 (1 commits) (flutter#17248)
db02fa1 Roll fuchsia/sdk/core/linux-amd64 from pTJOm... to kGu6P... (flutter#17247)
f5314ea Roll fuchsia/sdk/core/mac-amd64 from uyg4y... to nmCXC... (flutter#17246)
31c4727 Document flutter::RuntimeController. (flutter#17250)
7b9a678 Roll src/third_party/dart 82f8a5451fae..f247613737ec (3 commits) (flutter#17245)
3dd688c Roll src/third_party/dart ba8baa46b452..82f8a5451fae (40 commits) (flutter#17244)
cafa097 Revert "Roll src/third_party/dart ba8baa46b452..fbd0c8a46813 (35 commits) (flutter#17241)" (flutter#17243)
2f769be Soften shadows (flutter#17231)
48902d1 Felt add integration (flutter#17190)
047c03b Roll src/third_party/dart ba8baa46b452..fbd0c8a46813 (35 commits) (flutter#17241)
f5d25da Reland: Implement unobstructed Platform Views on iOS (flutter#17237)
d79170f Roll src/third_party/skia 933926683991..e41fa2d5e44d (2 commits) (flutter#17240)
46cc35f Roll fuchsia/sdk/core/mac-amd64 from MKYwg... to uyg4y... (flutter#17234)
060cbc4 Revert "Roll src/third_party/dart ba8baa46b452..0296286c03f6 (11 commits) (flutter#17226)" (flutter#17239)
1152709 Roll fuchsia/sdk/core/linux-amd64 from ZmlfS... to pTJOm... (flutter#17235)
47ae84b Run web framework tests on third-party rolls (flutter#17238)
e2ec94b Roll src/third_party/skia 7b7b78cb9f1b..933926683991 (6 commits) (flutter#17232)
f58967f Re-land "Enable unified OpenGL/Metal builds." (flutter#17230)
70f6d18 Revert "Implement unobstructed Platform Views on iOS (flutter#17049)" (flutter#17233)
bba1a3c Roll buildroot to a0fb98a (flutter#17229)
2627634 Implement unobstructed Platform Views on iOS (flutter#17049)
49f8dba Sync Cirrus web test config from flutter/flutter (flutter#17228)
fdf4f78 Roll src/third_party/skia 85755f46a881..7b7b78cb9f1b (6 commits) (flutter#17227)
6c757f3 Roll src/third_party/dart ba8baa46b452..0296286c03f6 (11 commits) (flutter#17226)
gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Mar 24, 2020
git log 2d42c74..d7ad50c --first-parent --oneline
d7ad50c Roll src/third_party/skia c97c90072499..6cb8168c2b9b (1 commits) (flutter#17287)
704a869 Roll src/third_party/dart cbd67124d10e..8246621d4da3 (39 commits) (flutter#17286)
33895cf Roll src/third_party/skia d1988219065a..c97c90072499 (2 commits) (flutter#17285)
48d1165 Roll fuchsia/sdk/core/linux-amd64 from h8m0G... to y2Piw... (flutter#17283)
0015b19 Roll fuchsia/sdk/core/mac-amd64 from WaNBa... to gkIC0... (flutter#17282)
518c9e0 Remove checks for the always true using_fuchsia_sdk flag in all GN files. (flutter#17261)
1eea062 Roll src/third_party/skia 3c358420df4a..d1988219065a (3 commits) (flutter#17279)
ad8ccf4 [Fuchsia] Move physical shape layer compositing to Flutter (flutter#17005)
c490cb9 Roll src/third_party/skia 165b68ebb6ad..3c358420df4a (5 commits) (flutter#17277)
4c41b14 [web] Introduce js interop to enable experimental flags on web (flutter#17099)
21f5d7f Roll src/third_party/skia 4098719375d8..165b68ebb6ad (7 commits) (flutter#17274)
6fef0d0 Removed a text input trait that causes VoiceOver to be incorrect when tapping a text input. (flutter#17203)
9343c5e added missing mock to MockEngine for iOS unit tests (flutter#17273)
af056a8 Roll src/third_party/skia 6f60a859c628..4098719375d8 (6 commits) (flutter#17271)
33a21d1 Add DartProject for Windows embedding API (flutter#17210)
8a8b298 Added a log message when sharing a FlutterEngine across multiple FlutterViewControllers. (flutter#17186)
11f5521 Roll src/third_party/skia f04f21a5c913..6f60a859c628 (2 commits) (flutter#17268)
da9e778 Roll fuchsia/sdk/core/linux-amd64 from k4zbT... to h8m0G... (flutter#17264)
c86a4cc Roll fuchsia/sdk/core/mac-amd64 from bgp6U... to WaNBa... (flutter#17263)
35e8303 Roll src/third_party/skia 538e358b0d82..f04f21a5c913 (2 commits) (flutter#17260)
e56b335 Allow external texture sources when using the Metal backend. (flutter#17154)
c0deb23 Don’t depend on an implicit transaction when no external view embedder is present. (flutter#17258)
80846b0 Roll src/third_party/dart b7455646f90d..cbd67124d10e (3 commits) (flutter#17257)
9c64029 Documentation cleanups to RuntimeController. (flutter#17256)
209e786 Roll fuchsia/sdk/core/linux-amd64 from kGu6P... to k4zbT... (flutter#17255)
aa26106 Roll fuchsia/sdk/core/mac-amd64 from nmCXC... to bgp6U... (flutter#17254)
eec7447 Roll src/third_party/dart bdf14543576a..b7455646f90d (1 commits) (flutter#17253)
ba26ce3 Roll src/third_party/dart 861708483217..bdf14543576a (5 commits) (flutter#17252)
c9a24af Roll src/third_party/skia cf3594b60362..538e358b0d82 (4 commits) (flutter#17251)
59406cc Roll src/third_party/skia e41fa2d5e44d..cf3594b60362 (1 commits) (flutter#17249)
7d21f97 Roll src/third_party/dart f247613737ec..861708483217 (1 commits) (flutter#17248)
db02fa1 Roll fuchsia/sdk/core/linux-amd64 from pTJOm... to kGu6P... (flutter#17247)
f5314ea Roll fuchsia/sdk/core/mac-amd64 from uyg4y... to nmCXC... (flutter#17246)
31c4727 Document flutter::RuntimeController. (flutter#17250)
7b9a678 Roll src/third_party/dart 82f8a5451fae..f247613737ec (3 commits) (flutter#17245)
3dd688c Roll src/third_party/dart ba8baa46b452..82f8a5451fae (40 commits) (flutter#17244)
cafa097 Revert "Roll src/third_party/dart ba8baa46b452..fbd0c8a46813 (35 commits) (flutter#17241)" (flutter#17243)
2f769be Soften shadows (flutter#17231)
48902d1 Felt add integration (flutter#17190)
047c03b Roll src/third_party/dart ba8baa46b452..fbd0c8a46813 (35 commits) (flutter#17241)
f5d25da Reland: Implement unobstructed Platform Views on iOS (flutter#17237)
d79170f Roll src/third_party/skia 933926683991..e41fa2d5e44d (2 commits) (flutter#17240)
46cc35f Roll fuchsia/sdk/core/mac-amd64 from MKYwg... to uyg4y... (flutter#17234)
060cbc4 Revert "Roll src/third_party/dart ba8baa46b452..0296286c03f6 (11 commits) (flutter#17226)" (flutter#17239)
1152709 Roll fuchsia/sdk/core/linux-amd64 from ZmlfS... to pTJOm... (flutter#17235)
47ae84b Run web framework tests on third-party rolls (flutter#17238)
e2ec94b Roll src/third_party/skia 7b7b78cb9f1b..933926683991 (6 commits) (flutter#17232)
f58967f Re-land "Enable unified OpenGL/Metal builds." (flutter#17230)
70f6d18 Revert "Implement unobstructed Platform Views on iOS (flutter#17049)" (flutter#17233)
bba1a3c Roll buildroot to a0fb98a (flutter#17229)
2627634 Implement unobstructed Platform Views on iOS (flutter#17049)
49f8dba Sync Cirrus web test config from flutter/flutter (flutter#17228)
fdf4f78 Roll src/third_party/skia 85755f46a881..7b7b78cb9f1b (6 commits) (flutter#17227)
6c757f3 Roll src/third_party/dart ba8baa46b452..0296286c03f6 (11 commits) (flutter#17226)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants