Skip to content

Conversation

@ricardodalarme
Copy link
Contributor

@ricardodalarme ricardodalarme commented Jul 19, 2025

Description

Continuing the work from @jamilsaadeh97 to replace verbose null checks with modern null_aware_elements syntax.

This PR cleans up the remaining files not covered in the previous parts, making the code more concise.

Related PRs

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@ricardodalarme ricardodalarme requested review from a team and matanlurey as code owners July 19, 2025 22:40
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. f: integration_test The flutter/packages/integration_test plugin team-ios Owned by iOS platform team labels Jul 19, 2025
@ricardodalarme ricardodalarme force-pushed the refactor/use-null-aware-elements branch from 9406cc0 to b30bf95 Compare July 19, 2025 22:44
@chinmaygarde chinmaygarde removed the engine flutter/engine related. See also e: labels. label Jul 21, 2025
@ricardodalarme ricardodalarme force-pushed the refactor/use-null-aware-elements branch from b30bf95 to 81420c8 Compare July 21, 2025 20:28
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jul 21, 2025
@ricardodalarme ricardodalarme force-pushed the refactor/use-null-aware-elements branch from 81420c8 to dc09046 Compare July 24, 2025 03:37
@github-actions github-actions bot removed a: tests "flutter test", flutter_test, or one of our tests f: integration_test The flutter/packages/integration_test plugin labels Jul 24, 2025
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 1, 2025
Roll Flutter from c3279caa127d to 871849e4b6bf (56 revisions)

flutter/flutter@c3279ca...871849e

2025-08-01 [email protected] Roll Dart SDK from 6832e04cf2f9 to 6e1bb159c860 (8 revisions) (flutter/flutter#173119)
2025-08-01 [email protected] Add `--profile-startup` flag to `flutter run` (flutter/flutter#172990)
2025-08-01 [email protected] Add `side` to `RadioThemeData` (flutter/flutter#171945)
2025-08-01 [email protected] Update GCA instructions (flutter/flutter#173001)
2025-08-01 [email protected] [engine] Null aware elements clean-ups (flutter/flutter#173075)
2025-08-01 [email protected] Roll Packages from db6988d to f0645d8 (3 revisions) (flutter/flutter#173111)
2025-08-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland licenses cpp switch 3 (#173063)" (flutter/flutter#173113)
2025-08-01 [email protected] Update embedder API CODEOWNERS (flutter/flutter#173081)
2025-08-01 [email protected] Move android_obfuscate_test from devicelab into tools integration.shard (flutter/flutter#169798)
2025-08-01 [email protected] [A11y] RangeSlider should have 2 focus node (flutter/flutter#172729)
2025-07-31 [email protected] Upload the linux arm64 embedder to cloud buckets. (flutter/flutter#173068)
2025-07-31 [email protected] Reland licenses cpp switch 3 (flutter/flutter#173063)
2025-07-31 [email protected] [ Tool ] Mark IOOverrides subclasses as `final` (flutter/flutter#173078)
2025-07-31 [email protected] [macOS] Remove duplicate object initialization (flutter/flutter#171767)
2025-07-31 [email protected] Redistribute Android test owners (flutter/flutter#172886)
2025-07-31 [email protected] Avoid negatives in the styleguide.md (flutter/flutter#172917)
2025-07-31 [email protected] Roll Skia from 42e3bed42110 to 49e39cd3cf18 (7 revisions) (flutter/flutter#173069)
2025-07-31 [email protected] Fix the issue where calling showOnScreen on a sliver after a pinned child in SliverMainAxisGroup does not reveal it. (flutter/flutter#171339)
2025-07-31 [email protected] Improve assertion message in `EdgeInsetsDirectional.resolve` (flutter/flutter#172099)
2025-07-31 [email protected] licenses_cpp: Switched to lexically_relative for 2x speed boost. (flutter/flutter#173048)
2025-07-31 [email protected] Add dartvm to the dart_sdk_entitlement_config list. (flutter/flutter#173044)
2025-07-31 [email protected] [web] ClickDebouncer workaround for iOS Safari click behavior (flutter/flutter#172995)
2025-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland licenses cpp switch 2 (#172996)" (flutter/flutter#173059)
2025-07-31 [email protected] [web] Text editing test accepts both behaviors in Firefox (flutter/flutter#172767)
2025-07-31 [email protected] Reland licenses cpp switch 2 (flutter/flutter#172996)
2025-07-31 [email protected] Roll Packages from d914120 to db6988d (2 revisions) (flutter/flutter#173039)
2025-07-31 [email protected] Add a SliverList code sample (flutter/flutter#172986)
2025-07-31 [email protected] fix: adjust scrollable size assertion with tolerance (flutter/flutter#171426)
2025-07-31 [email protected] impeller: Shrink `Command` 40 bytes (flutter/flutter#173004)
2025-07-31 [email protected] [web] Remove outdated comment about HTML renderer (flutter/flutter#172877)
2025-07-31 [email protected] Roll Skia from ff4da49305c5 to 42e3bed42110 (1 revision) (flutter/flutter#173038)
2025-07-31 [email protected] Roll Skia from 7d468a4868cb to ff4da49305c5 (3 revisions) (flutter/flutter#173028)
2025-07-31 [email protected] Roll Skia from 951277895c86 to 7d468a4868cb (1 revision) (flutter/flutter#173027)
2025-07-31 [email protected] Manual roll of Dart from 14ea8d342149 to 6832e04cf2f9 (flutter/flutter#173015)
2025-07-31 [email protected] Roll Skia from 8bdf4cdcf4ed to 951277895c86 (2 revisions) (flutter/flutter#173022)
2025-07-31 [email protected] Roll Fuchsia Linux SDK from bQVQlLssTxxLjoDU0... to xo_bqOoFuBKFmgKxn... (flutter/flutter#173021)
2025-07-31 [email protected] feat: Add `cursorHeight` to `DropdownMenu` (flutter/flutter#172615)
2025-07-31 [email protected] Roll Skia from a3347cee2d73 to 8bdf4cdcf4ed (3 revisions) (flutter/flutter#173013)
2025-07-31 [email protected] [ Widget Preview ] Add `--web-server` support (flutter/flutter#172978)
2025-07-30 [email protected] Bump customer tests for zulip fix 2 (flutter/flutter#173003)
2025-07-30 [email protected] Migrate to null aware elements - Part 4 (flutter/flutter#172322)
2025-07-30 [email protected] Marks Linux linux_feature_flags_test to be unflaky (flutter/flutter#172629)
2025-07-30 [email protected] [ Widget Previews ] Add support for `MultiPreview`s (flutter/flutter#172852)
2025-07-30 [email protected] Made licenses_cpp simpatico with google licenses (flutter/flutter#172991)
2025-07-30 [email protected] Roll Skia from d579722d65c6 to a3347cee2d73 (6 revisions) (flutter/flutter#172989)
2025-07-30 [email protected] Migrate to null aware elements - Part 5 (flutter/flutter#172418)
...
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
## Description

Continuing the work from @jamilsaadeh97 to replace verbose null checks
with modern
[null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements)
syntax.

This PR cleans up the remaining files not covered in the previous parts,
making the code more concise.

## Related PRs

- flutter#172198
- flutter#172306
- flutter#172307
- flutter#172322

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
## Description

Continuing the work from @jamilsaadeh97 to replace verbose null checks
with modern
[null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements)
syntax.

This PR cleans up the remaining files not covered in the previous parts,
making the code more concise.

## Related PRs

- flutter#172198
- flutter#172306
- flutter#172307
- flutter#172322

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
## Description

Continuing the work from @jamilsaadeh97 to replace verbose null checks
with modern
[null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements)
syntax.

This PR cleans up the remaining files not covered in the previous parts,
making the code more concise.

## Related PRs

- flutter#172198
- flutter#172306
- flutter#172307
- flutter#172322

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
## Description

Continuing the work from @jamilsaadeh97 to replace verbose null checks
with modern
[null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements)
syntax.

This PR cleans up the remaining files not covered in the previous parts,
making the code more concise.

## Related PRs

- flutter#172198
- flutter#172306
- flutter#172307
- flutter#172322

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants