Skip to content

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jul 18, 2025

See #172375

@mdebbar mdebbar requested a review from dkwingsmt July 18, 2025 18:53
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mdebbar mdebbar added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Jul 18, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@mdebbar mdebbar added this pull request to the merge queue Jul 18, 2025
Merged via the queue into master with commit 47a476a Jul 18, 2025
149 of 156 checks passed
@mdebbar mdebbar deleted the mdebbar-patch-5 branch July 18, 2025 19:31
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Jul 19, 2025
Also restore the Mac tool_tests_commands that were temporarily disabled in flutter#172388

Fixes flutter#172375
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 20, 2025
flutter/flutter@440713c...70a3c3c

2025-07-20 [email protected] Add optional splashColor property to ExpansionTile (flutter/flutter#172224)
2025-07-20 [email protected] Roll Fuchsia Linux SDK from 6agRTm-nf09sDmfQG... to 8MyOdk7FEK-MqkzIF... (flutter/flutter#172420)
2025-07-19 [email protected] Roll Dart SDK from ca7224f7dfd7 to a821b47e7a4d (1 revision) (flutter/flutter#172407)
2025-07-19 [email protected] Roll Dart SDK from 9982ab49440a to ca7224f7dfd7 (2 revisions) (flutter/flutter#172401)
2025-07-19 [email protected] fix: produce pom/jar files with content_hash (flutter/flutter#172378)
2025-07-18 [email protected] Roll Dart SDK from fe2232bd5b9f to 9982ab49440a (2 revisions) (flutter/flutter#172393)
2025-07-18 [email protected] Roll Fuchsia Linux SDK from HXdm7P0a4ZJVm_TE-... to 6agRTm-nf09sDmfQG... (flutter/flutter#172392)
2025-07-18 [email protected] Adopt Null-Aware Elements in `packages/flutter/lib/src/material` (flutter/flutter#172285)
2025-07-18 [email protected] Recommend using Flutter feature flags over platform-specific configs (flutter/flutter#172324)
2025-07-18 [email protected] TestTextInput should reset its key handler between tests (flutter/flutter#172323)
2025-07-18 [email protected] Mark Mac_* tool_tests_commands as bringup to unblock tree (flutter/flutter#172388)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot pushed a commit that referenced this pull request Jul 21, 2025
The version of flutter_lints used by newly created projects should match
the version used by flutter_tools. This ensures that "pub get --offline"
will work on a project that was generated by "flutter create".

Also restore the Mac tool_tests_commands that were temporarily disabled
in #172388

Fixes #172375
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
…#172400)

The version of flutter_lints used by newly created projects should match
the version used by flutter_tools. This ensures that "pub get --offline"
will work on a project that was generated by "flutter create".

Also restore the Mac tool_tests_commands that were temporarily disabled
in flutter#172388

Fixes flutter#172375
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9653)

flutter/flutter@440713c...70a3c3c

2025-07-20 [email protected] Add optional splashColor property to ExpansionTile (flutter/flutter#172224)
2025-07-20 [email protected] Roll Fuchsia Linux SDK from 6agRTm-nf09sDmfQG... to 8MyOdk7FEK-MqkzIF... (flutter/flutter#172420)
2025-07-19 [email protected] Roll Dart SDK from ca7224f7dfd7 to a821b47e7a4d (1 revision) (flutter/flutter#172407)
2025-07-19 [email protected] Roll Dart SDK from 9982ab49440a to ca7224f7dfd7 (2 revisions) (flutter/flutter#172401)
2025-07-19 [email protected] fix: produce pom/jar files with content_hash (flutter/flutter#172378)
2025-07-18 [email protected] Roll Dart SDK from fe2232bd5b9f to 9982ab49440a (2 revisions) (flutter/flutter#172393)
2025-07-18 [email protected] Roll Fuchsia Linux SDK from HXdm7P0a4ZJVm_TE-... to 6agRTm-nf09sDmfQG... (flutter/flutter#172392)
2025-07-18 [email protected] Adopt Null-Aware Elements in `packages/flutter/lib/src/material` (flutter/flutter#172285)
2025-07-18 [email protected] Recommend using Flutter feature flags over platform-specific configs (flutter/flutter#172324)
2025-07-18 [email protected] TestTextInput should reset its key handler between tests (flutter/flutter#172323)
2025-07-18 [email protected] Mark Mac_* tool_tests_commands as bringup to unblock tree (flutter/flutter#172388)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
…#172400)

The version of flutter_lints used by newly created projects should match
the version used by flutter_tools. This ensures that "pub get --offline"
will work on a project that was generated by "flutter create".

Also restore the Mac tool_tests_commands that were temporarily disabled
in flutter#172388

Fixes flutter#172375
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…#172400)

The version of flutter_lints used by newly created projects should match
the version used by flutter_tools. This ensures that "pub get --offline"
will work on a project that was generated by "flutter create".

Also restore the Mac tool_tests_commands that were temporarily disabled
in flutter#172388

Fixes flutter#172375
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
…#172400)

The version of flutter_lints used by newly created projects should match
the version used by flutter_tools. This ensures that "pub get --offline"
will work on a project that was generated by "flutter create".

Also restore the Mac tool_tests_commands that were temporarily disabled
in flutter#172388

Fixes flutter#172375
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
…#172400)

The version of flutter_lints used by newly created projects should match
the version used by flutter_tools. This ensures that "pub get --offline"
will work on a project that was generated by "flutter create".

Also restore the Mac tool_tests_commands that were temporarily disabled
in flutter#172388

Fixes flutter#172375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants