Remove GtkGLArea and render directly into GtkDrawingArea #172343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compositing is now done on the Flutter rendering thread and we block the GTK rendering until the frame is generated. This no longer requires the task runner to be involved.
This allows Flutter to render without any GTK windows present (required for multi-window)
github-actions
bot
added
engine
Contributor
Author
|
Builds on #172330 |
This simplifies the OpenGL/software case and allows us more control over the buffering.
robert-ancell
force-pushed
the
linux-remove-gtkglarea4
branch
from
b48db2a to
562262f
Compare
mattkae
approved these changes
Jul 22, 2025
Contributor
mattkae
left a comment
mattkae
left a comment
There was a problem hiding this comment.
One minor thing, but LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 23, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 23, 2025
flutter/flutter@ee0cc66...afba7d7 2025-07-23 [email protected] Remove GtkGLArea and render directly into GtkDrawingArea (flutter/flutter#172343) 2025-07-23 [email protected] Prefix generated Dart plugin imports for `registerWith` (flutter/flutter#172511) 2025-07-23 [email protected] Remove stale references to `.packages` in tool tests (flutter/flutter#172582) 2025-07-23 [email protected] Wraps all `git` executions in a `Git(...).*`, use `*=noglob` on Windows (flutter/flutter#172495) 2025-07-22 [email protected] Omit instruction to `cd .` after `flutter create` (flutter/flutter#172513) 2025-07-22 [email protected] Improve assertion message in `AlignmentDirectional.resolve` (flutter/flutter#172096) 2025-07-22 [email protected] Update warnGradleVersion to `8.7.0` (flutter/flutter#172576) 2025-07-22 [email protected] Use a fake representation of `cache/artifacts/gradle_wrapper` (flutter/flutter#172503) 2025-07-22 [email protected] Revert #160653 Fix view removal process for AutofillContextAction.cancel (flutter/flutter#172490) 2025-07-22 [email protected] Bump meta to 0.17.0 (flutter/flutter#172541) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9665) flutter/flutter@ee0cc66...afba7d7 2025-07-23 [email protected] Remove GtkGLArea and render directly into GtkDrawingArea (flutter/flutter#172343) 2025-07-23 [email protected] Prefix generated Dart plugin imports for `registerWith` (flutter/flutter#172511) 2025-07-23 [email protected] Remove stale references to `.packages` in tool tests (flutter/flutter#172582) 2025-07-23 [email protected] Wraps all `git` executions in a `Git(...).*`, use `*=noglob` on Windows (flutter/flutter#172495) 2025-07-22 [email protected] Omit instruction to `cd .` after `flutter create` (flutter/flutter#172513) 2025-07-22 [email protected] Improve assertion message in `AlignmentDirectional.resolve` (flutter/flutter#172096) 2025-07-22 [email protected] Update warnGradleVersion to `8.7.0` (flutter/flutter#172576) 2025-07-22 [email protected] Use a fake representation of `cache/artifacts/gradle_wrapper` (flutter/flutter#172503) 2025-07-22 [email protected] Revert #160653 Fix view removal process for AutofillContextAction.cancel (flutter/flutter#172490) 2025-07-22 [email protected] Bump meta to 0.17.0 (flutter/flutter#172541) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
robert-ancell
added a commit
to robert-ancell/flutter
that referenced
this pull request
Sep 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the OpenGL/software case and allows us more control over the buffering.