Skip [tool] crash reporting on `--local-engine` #172326

matanlurey · 2025-07-17T22:36:56Z

gaaclarke · 2025-07-21T16:47:18Z

packages/flutter_tools/lib/runner.dart

  bool reportCrashes,
  String Function() getFlutterVersion,
  ShutdownHooks shutdownHooks, {
+  required bool usingLocalEngine,


Instead of introducing a new instance variable, can't we just set reportCrashes appropriately when we have a local engine? (ie solve this problem one level higher?)

@matanlurey friendly ping on this question. I don't think it was worth holding back the approval, but I'm still interested in a response

justinmc

LGTM 👍

…utter#172326)

flutter/flutter@70cdc0c...ee0cc66 2025-07-22 [email protected] Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 [email protected] fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 [email protected] Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 [email protected] Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 [email protected] Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 [email protected] Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 [email protected] Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 [email protected] Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 [email protected] Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 [email protected] feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 [email protected] Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 [email protected] Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 [email protected] Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 [email protected] Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 [email protected] fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 [email protected] Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 [email protected] Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 [email protected] Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 [email protected] Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 [email protected] Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 [email protected] Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 [email protected] Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 [email protected] Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 [email protected] Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 [email protected] Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 [email protected] Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Closes flutter#70238.

…r#9662) flutter/flutter@70cdc0c...ee0cc66 2025-07-22 [email protected] Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 [email protected] fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 [email protected] Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 [email protected] Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 [email protected] Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 [email protected] Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 [email protected] Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 [email protected] Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 [email protected] Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 [email protected] feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 [email protected] Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 [email protected] Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 [email protected] Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 [email protected] Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 [email protected] fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 [email protected] Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 [email protected] Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 [email protected] Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 [email protected] Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 [email protected] Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 [email protected] Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 [email protected] Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 [email protected] Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 [email protected] Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 [email protected] Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 [email protected] Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Closes flutter#70238.

…utter#172326)

Closes flutter#70238.

Skip crash reporting on --local-engine

cbab1b0

matanlurey requested a review from bkonyi July 17, 2025 22:36

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 17, 2025

++

ee97d7b

matanlurey changed the title ~~Skip [tool] rash reporting on --local-engine~~ Skip [tool] crash reporting on --local-engine Jul 21, 2025

jason-simmons approved these changes Jul 21, 2025

View reviewed changes

gaaclarke approved these changes Jul 21, 2025

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

justinmc approved these changes Jul 21, 2025

View reviewed changes

auto-submit bot added this pull request to the merge queue Jul 21, 2025

Merged via the queue into flutter:master with commit 599ed52 Jul 21, 2025
142 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

599ed5252 Skip [tool] crash reporting on --local-engine (flutter/fl…

6c3111d

…utter#172326)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to d16e5b9971e7 (26 revisions) flutter/packages#9659

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

599ed5252 Skip [tool] crash reporting on --local-engine (flutter/fl…

499b51e

…utter#172326)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to 404fb3f14fdd (27 revisions) flutter/packages#9660

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

599ed5252 Skip [tool] crash reporting on --local-engine (flutter/fl…

58a424f

…utter#172326)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to 404fb3f14fdd (27 revisions) flutter/packages#9661

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

599ed5252 Skip [tool] crash reporting on --local-engine (flutter/fl…

1fa8097

…utter#172326)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to ee0cc6652be7 (29 revisions) flutter/packages#9662

Merged

azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025

Skip [tool] crash reporting on --local-engine (flutter#172326)

804afbe

Closes flutter#70238.

ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025

Skip [tool] crash reporting on --local-engine (flutter#172326)

8fafff3

Closes flutter#70238.

mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025

Skip [tool] crash reporting on --local-engine (flutter#172326)

2029b34

Closes flutter#70238.

korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025

Skip [tool] crash reporting on --local-engine (flutter#172326)

af75b57

Closes flutter#70238.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

599ed5252 Skip [tool] crash reporting on --local-engine (flutter/fl…

4f02340

…utter#172326)

lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025

Skip [tool] crash reporting on --local-engine (flutter#172326)

8d3d744

Closes flutter#70238.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip [tool] crash reporting on `--local-engine` #172326

Skip [tool] crash reporting on `--local-engine` #172326

Uh oh!

matanlurey commented Jul 17, 2025

Uh oh!

gaaclarke Jul 21, 2025

Uh oh!

gaaclarke Jul 21, 2025

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Skip [tool] crash reporting on --local-engine #172326

Skip [tool] crash reporting on --local-engine #172326

Uh oh!

Conversation

matanlurey commented Jul 17, 2025

Uh oh!

gaaclarke Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Skip [tool] crash reporting on `--local-engine` #172326

Skip [tool] crash reporting on `--local-engine` #172326