TestTextInput should reset its key handler between tests #172323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs two tests back-to-back that try to receive a keyboard shortcut selector. Without this fix, the first run passes and second run fails.
github-actions
bot
added
a: tests
justinmc
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 20, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 20, 2025
flutter/flutter@440713c...70a3c3c 2025-07-20 [email protected] Add optional splashColor property to ExpansionTile (flutter/flutter#172224) 2025-07-20 [email protected] Roll Fuchsia Linux SDK from 6agRTm-nf09sDmfQG... to 8MyOdk7FEK-MqkzIF... (flutter/flutter#172420) 2025-07-19 [email protected] Roll Dart SDK from ca7224f7dfd7 to a821b47e7a4d (1 revision) (flutter/flutter#172407) 2025-07-19 [email protected] Roll Dart SDK from 9982ab49440a to ca7224f7dfd7 (2 revisions) (flutter/flutter#172401) 2025-07-19 [email protected] fix: produce pom/jar files with content_hash (flutter/flutter#172378) 2025-07-18 [email protected] Roll Dart SDK from fe2232bd5b9f to 9982ab49440a (2 revisions) (flutter/flutter#172393) 2025-07-18 [email protected] Roll Fuchsia Linux SDK from HXdm7P0a4ZJVm_TE-... to 6agRTm-nf09sDmfQG... (flutter/flutter#172392) 2025-07-18 [email protected] Adopt Null-Aware Elements in `packages/flutter/lib/src/material` (flutter/flutter#172285) 2025-07-18 [email protected] Recommend using Flutter feature flags over platform-specific configs (flutter/flutter#172324) 2025-07-18 [email protected] TestTextInput should reset its key handler between tests (flutter/flutter#172323) 2025-07-18 [email protected] Mark Mac_* tool_tests_commands as bringup to unblock tree (flutter/flutter#172388) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
) Looks like we forgot to reset _keyHandler in TestTextInput. Fixes flutter#171491
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9653) flutter/flutter@440713c...70a3c3c 2025-07-20 [email protected] Add optional splashColor property to ExpansionTile (flutter/flutter#172224) 2025-07-20 [email protected] Roll Fuchsia Linux SDK from 6agRTm-nf09sDmfQG... to 8MyOdk7FEK-MqkzIF... (flutter/flutter#172420) 2025-07-19 [email protected] Roll Dart SDK from ca7224f7dfd7 to a821b47e7a4d (1 revision) (flutter/flutter#172407) 2025-07-19 [email protected] Roll Dart SDK from 9982ab49440a to ca7224f7dfd7 (2 revisions) (flutter/flutter#172401) 2025-07-19 [email protected] fix: produce pom/jar files with content_hash (flutter/flutter#172378) 2025-07-18 [email protected] Roll Dart SDK from fe2232bd5b9f to 9982ab49440a (2 revisions) (flutter/flutter#172393) 2025-07-18 [email protected] Roll Fuchsia Linux SDK from HXdm7P0a4ZJVm_TE-... to 6agRTm-nf09sDmfQG... (flutter/flutter#172392) 2025-07-18 [email protected] Adopt Null-Aware Elements in `packages/flutter/lib/src/material` (flutter/flutter#172285) 2025-07-18 [email protected] Recommend using Flutter feature flags over platform-specific configs (flutter/flutter#172324) 2025-07-18 [email protected] TestTextInput should reset its key handler between tests (flutter/flutter#172323) 2025-07-18 [email protected] Mark Mac_* tool_tests_commands as bringup to unblock tree (flutter/flutter#172388) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
) Looks like we forgot to reset _keyHandler in TestTextInput. Fixes flutter#171491
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
) Looks like we forgot to reset _keyHandler in TestTextInput. Fixes flutter#171491
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
) Looks like we forgot to reset _keyHandler in TestTextInput. Fixes flutter#171491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we forgot to reset _keyHandler in TestTextInput.
Fixes #171491