Skip to content

Conversation

@flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented Jul 16, 2025

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#172257

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

N/A

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Cannot release (Windows builder fails)

Workaround:

Is there a workaround for this issue?

No

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

Try publishing another release

… silly reason (flutter#172256)

WARNING: codefu's snark level is approaching maximums.
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Jul 16, 2025
@flutteractionsbot
Copy link
Author

@matanlurey please fill out the PR description above, afterwards the release team will review this request.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jul 16, 2025
@matanlurey matanlurey self-requested a review July 16, 2025 23:14
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 16, 2025

autosubmit label was removed for flutter/flutter/172263, because - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 16, 2025

autosubmit label was removed for flutter/flutter/172263, because - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 17, 2025

autosubmit label was removed for flutter/flutter/172263, because - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 17, 2025

autosubmit label was removed for flutter/flutter/172263, because - The status or check suite Linux_android_emu native_assets_android has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux build_aar_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2025
@auto-submit auto-submit bot merged commit 1c9c20e into flutter:flutter-3.35-candidate.0 Jul 18, 2025
164 checks passed
korca0220 added a commit to korca0220/flutter that referenced this pull request Aug 4, 2025
…uniform-table-border

* commit '1c9c20e7c3dd48c66f400a24d48ea806b4ab312a':
  [CP-beta]Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason (flutter#172263)
  [3.35] Update `engine.version` (+CPs Use `release-*.version`) (flutter#172237)
  [3.35] Create `release-candidate-branch.version` (flutter#172191)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants