-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[CP-beta]Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason #172263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP-beta]Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason #172263
Conversation
… silly reason (flutter#172256) WARNING: codefu's snark level is approaching maximums.
|
@matanlurey please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
autosubmit label was removed for flutter/flutter/172263, because - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
autosubmit label was removed for flutter/flutter/172263, because - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
autosubmit label was removed for flutter/flutter/172263, because - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/172263, because - The status or check suite Linux_android_emu native_assets_android has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
1c9c20e
into
flutter:flutter-3.35-candidate.0
…uniform-table-border * commit '1c9c20e7c3dd48c66f400a24d48ea806b4ab312a': [CP-beta]Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason (flutter#172263) [3.35] Update `engine.version` (+CPs Use `release-*.version`) (flutter#172237) [3.35] Create `release-candidate-branch.version` (flutter#172191)
…ith CP1252 for some silly reason (flutter/flutter#172263)
…ith CP1252 for some silly reason (flutter/flutter#172263)
…ith CP1252 for some silly reason (flutter/flutter#172263)
…ith CP1252 for some silly reason (flutter/flutter#172263)
…ith CP1252 for some silly reason (flutter/flutter#172263)
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#172257
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
N/A
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Cannot release (Windows builder fails)
Workaround:
Is there a workaround for this issue?
No
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Try publishing another release