Skip to content

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Jul 16, 2025

Cherrypick's #172236 into the 3.35 release branch and tests it live by setting engine.version in this PR.

@matanlurey matanlurey changed the title [3.35] CP Use release-*.version (https://github.com/flutter/flutter/pull/172236) [3.35] Update engine.version (+CPs Use release-*.version) Jul 16, 2025
@matanlurey matanlurey requested a review from jtmcdole July 16, 2025 17:17
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@matanlurey matanlurey enabled auto-merge July 16, 2025 17:31
@matanlurey matanlurey disabled auto-merge July 16, 2025 17:32
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 16, 2025

autosubmit label was removed for flutter/flutter/172237, because - The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@matanlurey matanlurey added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Jul 16, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@auto-submit auto-submit bot added this pull request to the merge queue Jul 16, 2025
@matanlurey matanlurey removed this pull request from the merge queue due to a manual request Jul 16, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@matanlurey matanlurey removed the emergency Jump the queue; land PR in front of all others; only use for emergencies label Jul 16, 2025
@matanlurey matanlurey changed the base branch from master to flutter-3.35-candidate.0 July 16, 2025 18:59
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@matanlurey matanlurey force-pushed the cp-29e67150078a66842682c12d7d7083831e0f975f branch from 3bcb575 to c234e50 Compare July 16, 2025 19:04
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically labels Jul 16, 2025
@matanlurey matanlurey force-pushed the cp-29e67150078a66842682c12d7d7083831e0f975f branch from c234e50 to 5099950 Compare July 16, 2025 19:07
@github-actions github-actions bot removed a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically labels Jul 16, 2025
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@auto-submit auto-submit bot merged commit d86b4e9 into flutter:flutter-3.35-candidate.0 Jul 16, 2025
142 checks passed
korca0220 added a commit to korca0220/flutter that referenced this pull request Aug 4, 2025
…uniform-table-border

* commit '1c9c20e7c3dd48c66f400a24d48ea806b4ab312a':
  [CP-beta]Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason (flutter#172263)
  [3.35] Update `engine.version` (+CPs Use `release-*.version`) (flutter#172237)
  [3.35] Create `release-candidate-branch.version` (flutter#172191)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
…r#172237)

Cherrypick's flutter#172236 into the 3.35 release branch _and_ tests it live by setting `engine.version` in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants