Gallery demos: reordered and retitled #17220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
approved these changes
May 2, 2018
| // Cupertino Components | ||
| new GalleryDemo( | ||
| title: 'Activity Indicator', | ||
| subtitle: 'Cupertino styled activity indicator', |
cbracken
pushed a commit
to cbracken/flutter
that referenced
this pull request
May 4, 2018
cbracken
added a commit
that referenced
this pull request
May 4, 2018
Member
|
Note: this (fixed in #17273) severely regressed the gallery transition benchmarks. |
Member
|
I wonder if we're leaking the time of navigating around the categories trying to find the demo into the calculated sum of the transition time costs |
Contributor
Author
|
Right, this sounds like a bug in the benchmark since the reordering the lists of demos should not have any effect on the time required to launch (the very same) demos. |
Member
|
The benchmarks only count the (avg/max) build time and raster time across all frames, so the total time or number of frames shouldn't significantly matter unless we're running different demos or running more/different transitions than we previously were. Will see if I can track down what's going on. |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This was referenced May 25, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated per Liam Spradlin's design.