[ Tool ] Fix flutter upgrade stating that an upgrade is available on main when up to date
#172141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n main when up to date The `frameworkVersion` string written to the version files wasn't actually parsable by `GitTagVersion` as it didn't match the format output by `git`. This change updates the `frameworkVersion` format to use a `-` instead of a `.` before the commit count and adds support to the version parsing regex to handle both `.` and `-` separators before the commit count. Fixes #172091
github-actions
bot
added
the
tool
matanlurey
approved these changes
Jul 14, 2025
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Nice regression tests! LGTM~!
Contributor
|
autosubmit label was removed for flutter/flutter/172141, because - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
bot
removed
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 15, 2025
…vailable on `main` when up to date (flutter/flutter#172141)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 15, 2025
…vailable on `main` when up to date (flutter/flutter#172141)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 15, 2025
flutter/flutter@a930ec1...cc3110c 2025-07-15 [email protected] feat: Tag Fuchsia artifacts by content hash (flutter/flutter#172132) 2025-07-15 [email protected] Marks Linux_android_emu native_assets_android to be unflaky (flutter/flutter#171145) 2025-07-15 [email protected] [ Tool ] Fix `flutter upgrade` stating that an upgrade is available on `main` when up to date (flutter/flutter#172141) 2025-07-15 [email protected] Reland "Add feature flags to the framework" (flutter/flutter#171545) 2025-07-14 [email protected] chore: unskip tests cases (flutter/flutter#172031) 2025-07-14 [email protected] Route transition duration (flutter/flutter#171109) 2025-07-14 [email protected] [Impeller] libImpeller: Correctly release mappings created using the C++ API wrapper. (flutter/flutter#172136) 2025-07-14 [email protected] Roll Skia from 5f7adef2ac25 to 2f4ad5d83704 (3 revisions) (flutter/flutter#172134) 2025-07-14 [email protected] Migrate to arm based firebase test devices for api 26 and 27 (flutter/flutter#172128) 2025-07-14 [email protected] [web] Cleanup unnecessary dart defines and renderer in web tests (flutter/flutter#172130) 2025-07-14 [email protected] Use granular skparagraph targets (flutter/flutter#161676) 2025-07-14 [email protected] [ Widget Preview ] Initial work to support reacting to IDE events (flutter/flutter#172040) 2025-07-14 [email protected] Roll Skia from e95c92d867b5 to 5f7adef2ac25 (8 revisions) (flutter/flutter#172123) 2025-07-14 [email protected] [skia] Set GN flags explicitly for fuchsia build (flutter/flutter#172104) 2025-07-14 [email protected] fix: documentation around led launch broken (flutter/flutter#171983) 2025-07-14 [email protected] [ Tool ] Downgrade and pin DDS to 5.0.3 (flutter/flutter#172120) 2025-07-14 [email protected] Apply superellipse clipping to iOS platform views using an approximated round rect (flutter/flutter#172033) 2025-07-14 [email protected] [Impeller] Fix broken image links in documentation. (flutter/flutter#171465) 2025-07-14 [email protected] remove `x86` in CI builder linux_android_emulator (flutter/flutter#170964) 2025-07-14 [email protected] remove `x86` in flutter_gdb (flutter/flutter#170966) 2025-07-14 [email protected] fix android studio lint about lambda function (flutter/flutter#172063) 2025-07-14 [email protected] Roll Fuchsia Linux SDK from qw0YTtPhosk3-rr4h... to tQAtsLtpc0oBIqRwC... (flutter/flutter#172116) 2025-07-14 [email protected] Roll Skia from 92354f64e37f to e95c92d867b5 (1 revision) (flutter/flutter#172111) 2025-07-14 [email protected] [web] Delete unused files in the engine (flutter/flutter#172035) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
…n `main` when up to date (flutter#172141) The `frameworkVersion` string written to the version files wasn't actually parsable by `GitTagVersion` as it didn't match the format output by `git`. This change updates the `frameworkVersion` format to use a `-` instead of a `.` before the commit count and adds support to the version parsing regex to handle both `.` and `-` separators before the commit count. Fixes flutter#172091
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this pull request
Jul 28, 2025
These changed in a recent upstream PR to look a bit more like the output of `git describe`: flutter/flutter#172141 That causes an upgrade by `tools/upgrade flutter-local` past that upstream change to break an assumption made by this check; the check notices that up front, and sensibly fails. So update the check to accept both ways.
chrisbobbe
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Jul 29, 2025
These changed in a recent upstream PR to look a bit more like the output of `git describe`: flutter/flutter#172141 That causes an upgrade by `tools/upgrade flutter-local` past that upstream change to break an assumption made by this check; the check notices that up front, and sensibly fails. So update the check to accept both ways.
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this pull request
Jul 29, 2025
These changed in a recent upstream PR to look a bit more like the output of `git describe`: flutter/flutter#172141 That causes an upgrade by `tools/upgrade flutter-local` past that upstream change to break an assumption made by this check; the check notices that up front, and sensibly fails. So update the check to accept both ways.
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this pull request
Jul 29, 2025
These changed in a recent upstream PR to look a bit more like the output of `git describe`: flutter/flutter#172141 That causes an upgrade by `tools/upgrade flutter-local` past that upstream change to break an assumption made by this check; the check notices that up front, and sensibly fails. So update the check to accept both ways.
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9631) flutter/flutter@a930ec1...cc3110c 2025-07-15 [email protected] feat: Tag Fuchsia artifacts by content hash (flutter/flutter#172132) 2025-07-15 [email protected] Marks Linux_android_emu native_assets_android to be unflaky (flutter/flutter#171145) 2025-07-15 [email protected] [ Tool ] Fix `flutter upgrade` stating that an upgrade is available on `main` when up to date (flutter/flutter#172141) 2025-07-15 [email protected] Reland "Add feature flags to the framework" (flutter/flutter#171545) 2025-07-14 [email protected] chore: unskip tests cases (flutter/flutter#172031) 2025-07-14 [email protected] Route transition duration (flutter/flutter#171109) 2025-07-14 [email protected] [Impeller] libImpeller: Correctly release mappings created using the C++ API wrapper. (flutter/flutter#172136) 2025-07-14 [email protected] Roll Skia from 5f7adef2ac25 to 2f4ad5d83704 (3 revisions) (flutter/flutter#172134) 2025-07-14 [email protected] Migrate to arm based firebase test devices for api 26 and 27 (flutter/flutter#172128) 2025-07-14 [email protected] [web] Cleanup unnecessary dart defines and renderer in web tests (flutter/flutter#172130) 2025-07-14 [email protected] Use granular skparagraph targets (flutter/flutter#161676) 2025-07-14 [email protected] [ Widget Preview ] Initial work to support reacting to IDE events (flutter/flutter#172040) 2025-07-14 [email protected] Roll Skia from e95c92d867b5 to 5f7adef2ac25 (8 revisions) (flutter/flutter#172123) 2025-07-14 [email protected] [skia] Set GN flags explicitly for fuchsia build (flutter/flutter#172104) 2025-07-14 [email protected] fix: documentation around led launch broken (flutter/flutter#171983) 2025-07-14 [email protected] [ Tool ] Downgrade and pin DDS to 5.0.3 (flutter/flutter#172120) 2025-07-14 [email protected] Apply superellipse clipping to iOS platform views using an approximated round rect (flutter/flutter#172033) 2025-07-14 [email protected] [Impeller] Fix broken image links in documentation. (flutter/flutter#171465) 2025-07-14 [email protected] remove `x86` in CI builder linux_android_emulator (flutter/flutter#170964) 2025-07-14 [email protected] remove `x86` in flutter_gdb (flutter/flutter#170966) 2025-07-14 [email protected] fix android studio lint about lambda function (flutter/flutter#172063) 2025-07-14 [email protected] Roll Fuchsia Linux SDK from qw0YTtPhosk3-rr4h... to tQAtsLtpc0oBIqRwC... (flutter/flutter#172116) 2025-07-14 [email protected] Roll Skia from 92354f64e37f to e95c92d867b5 (1 revision) (flutter/flutter#172111) 2025-07-14 [email protected] [web] Delete unused files in the engine (flutter/flutter#172035) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…vailable on `main` when up to date (flutter/flutter#172141)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…vailable on `main` when up to date (flutter/flutter#172141)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…vailable on `main` when up to date (flutter/flutter#172141)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…vailable on `main` when up to date (flutter/flutter#172141)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
…vailable on `main` when up to date (flutter/flutter#172141)
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
…n `main` when up to date (flutter#172141) The `frameworkVersion` string written to the version files wasn't actually parsable by `GitTagVersion` as it didn't match the format output by `git`. This change updates the `frameworkVersion` format to use a `-` instead of a `.` before the commit count and adds support to the version parsing regex to handle both `.` and `-` separators before the commit count. Fixes flutter#172091
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…n `main` when up to date (flutter#172141) The `frameworkVersion` string written to the version files wasn't actually parsable by `GitTagVersion` as it didn't match the format output by `git`. This change updates the `frameworkVersion` format to use a `-` instead of a `.` before the commit count and adds support to the version parsing regex to handle both `.` and `-` separators before the commit count. Fixes flutter#172091
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…n `main` when up to date (flutter#172141) The `frameworkVersion` string written to the version files wasn't actually parsable by `GitTagVersion` as it didn't match the format output by `git`. This change updates the `frameworkVersion` format to use a `-` instead of a `.` before the commit count and adds support to the version parsing regex to handle both `.` and `-` separators before the commit count. Fixes flutter#172091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
frameworkVersionstring written to the version files wasn't actually parsable byGitTagVersionas it didn't match the format output bygit.This change updates the
frameworkVersionformat to use a-instead of a.before the commit count and adds support to the version parsing regex to handle both.and-separators before the commit count.Fixes #172091